mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
## What changed? Move some code around to avoid import cycles with future changes: - `common` depends on `common/dynamicconfig` (not changing) - I want to move dynamic config default values from all over into `common/dynamicconfig` - Some constants in `common` are used as default values. Moving them into `common/dynamicconfig` would create an import cycle. - So move the constants into `common/primitives` instead and reference them there. Also move `GetDefaultRetryPolicyConfigOptions`, `DefaultRetrySettings`, `FromConfigToDefaultRetrySettings`, `EnsureRetryPolicyDefaults`, `ValidateRetryPolicy` and associated unit test into new package `common/retrypolicy` with shorter names. Arguably more constants should move out of `common`, that package is too big. But these are the only ones that needed to be moved for now. ## Why? Split off from future PR to make reviews easier. ## How did you test it? existing tests
172 lines
6.4 KiB
Go
172 lines
6.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package retrypolicy
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
|
|
"go.temporal.io/server/common/number"
|
|
"go.temporal.io/server/common/primitives/timestamp"
|
|
)
|
|
|
|
const (
|
|
// TimeoutFailureTypePrefix is the prefix for timeout failure types
|
|
// used in retry policy
|
|
// the actual failure type will be prefix + enums.TimeoutType.String()
|
|
// e.g. "TemporalTimeout:StartToClose" or "TemporalTimeout:Heartbeat"
|
|
TimeoutFailureTypePrefix = "TemporalTimeout:"
|
|
|
|
defaultInitialInterval = time.Second
|
|
defaultMaximumIntervalCoefficient = 100.0
|
|
defaultBackoffCoefficient = 2.0
|
|
defaultMaximumAttempts = 0
|
|
|
|
initialIntervalInSecondsConfigKey = "InitialIntervalInSeconds"
|
|
maximumIntervalCoefficientConfigKey = "MaximumIntervalCoefficient"
|
|
backoffCoefficientConfigKey = "BackoffCoefficient"
|
|
maximumAttemptsConfigKey = "MaximumAttempts"
|
|
)
|
|
|
|
func GetDefault() map[string]any {
|
|
return map[string]any{
|
|
initialIntervalInSecondsConfigKey: int(defaultInitialInterval.Seconds()),
|
|
maximumIntervalCoefficientConfigKey: defaultMaximumIntervalCoefficient,
|
|
backoffCoefficientConfigKey: defaultBackoffCoefficient,
|
|
maximumAttemptsConfigKey: defaultMaximumAttempts,
|
|
}
|
|
}
|
|
|
|
// DefaultRetrySettings indicates what the "default" retry settings
|
|
// are if it is not specified on an Activity or for any unset fields
|
|
// if a policy is explicitly set on a workflow
|
|
type DefaultRetrySettings struct {
|
|
InitialInterval time.Duration
|
|
MaximumIntervalCoefficient float64
|
|
BackoffCoefficient float64
|
|
MaximumAttempts int32
|
|
}
|
|
|
|
func FromConfigToDefault(options map[string]interface{}) DefaultRetrySettings {
|
|
defaultSettings := DefaultRetrySettings{
|
|
InitialInterval: defaultInitialInterval,
|
|
MaximumAttempts: defaultMaximumAttempts,
|
|
}
|
|
|
|
if seconds, ok := options[initialIntervalInSecondsConfigKey]; ok {
|
|
defaultSettings.InitialInterval = time.Duration(
|
|
number.NewNumber(
|
|
seconds,
|
|
).GetIntOrDefault(int(defaultInitialInterval.Nanoseconds())),
|
|
) * time.Second
|
|
}
|
|
|
|
if coefficient, ok := options[maximumIntervalCoefficientConfigKey]; ok {
|
|
defaultSettings.MaximumIntervalCoefficient = number.NewNumber(
|
|
coefficient,
|
|
).GetFloatOrDefault(defaultMaximumIntervalCoefficient)
|
|
}
|
|
|
|
if coefficient, ok := options[backoffCoefficientConfigKey]; ok {
|
|
defaultSettings.BackoffCoefficient = number.NewNumber(
|
|
coefficient,
|
|
).GetFloatOrDefault(defaultBackoffCoefficient)
|
|
}
|
|
|
|
if attempts, ok := options[maximumAttemptsConfigKey]; ok {
|
|
defaultSettings.MaximumAttempts = int32(number.NewNumber(
|
|
attempts,
|
|
).GetIntOrDefault(defaultMaximumAttempts))
|
|
}
|
|
|
|
return defaultSettings
|
|
}
|
|
|
|
// EnsureDefaults ensures the policy subfields, if not explicitly set, are set to the specified defaults
|
|
func EnsureDefaults(originalPolicy *commonpb.RetryPolicy, defaultSettings DefaultRetrySettings) {
|
|
if originalPolicy.GetMaximumAttempts() == 0 {
|
|
originalPolicy.MaximumAttempts = defaultSettings.MaximumAttempts
|
|
}
|
|
|
|
if timestamp.DurationValue(originalPolicy.GetInitialInterval()) == 0 {
|
|
originalPolicy.InitialInterval = durationpb.New(defaultSettings.InitialInterval)
|
|
}
|
|
|
|
if timestamp.DurationValue(originalPolicy.GetMaximumInterval()) == 0 {
|
|
originalPolicy.MaximumInterval = durationpb.New(time.Duration(defaultSettings.MaximumIntervalCoefficient) * timestamp.DurationValue(originalPolicy.GetInitialInterval()))
|
|
}
|
|
|
|
if originalPolicy.GetBackoffCoefficient() == 0 {
|
|
originalPolicy.BackoffCoefficient = defaultSettings.BackoffCoefficient
|
|
}
|
|
}
|
|
|
|
// Validate validates a retry policy
|
|
func Validate(policy *commonpb.RetryPolicy) error {
|
|
if policy == nil {
|
|
// nil policy is valid which means no retry
|
|
return nil
|
|
}
|
|
|
|
if policy.GetMaximumAttempts() == 1 {
|
|
// One maximum attempt effectively disable retries. Validating the
|
|
// rest of the arguments is pointless
|
|
return nil
|
|
}
|
|
if timestamp.DurationValue(policy.GetInitialInterval()) < 0 {
|
|
return serviceerror.NewInvalidArgument("InitialInterval cannot be negative on retry policy.")
|
|
}
|
|
if policy.GetBackoffCoefficient() < 1 {
|
|
return serviceerror.NewInvalidArgument("BackoffCoefficient cannot be less than 1 on retry policy.")
|
|
}
|
|
if timestamp.DurationValue(policy.GetMaximumInterval()) < 0 {
|
|
return serviceerror.NewInvalidArgument("MaximumInterval cannot be negative on retry policy.")
|
|
}
|
|
if timestamp.DurationValue(policy.GetMaximumInterval()) > 0 && timestamp.DurationValue(policy.GetMaximumInterval()) < timestamp.DurationValue(policy.GetInitialInterval()) {
|
|
return serviceerror.NewInvalidArgument("MaximumInterval cannot be less than InitialInterval on retry policy.")
|
|
}
|
|
if policy.GetMaximumAttempts() < 0 {
|
|
return serviceerror.NewInvalidArgument("MaximumAttempts cannot be negative on retry policy.")
|
|
}
|
|
|
|
for _, nrt := range policy.NonRetryableErrorTypes {
|
|
if strings.HasPrefix(nrt, TimeoutFailureTypePrefix) {
|
|
timeoutTypeValue := nrt[len(TimeoutFailureTypePrefix):]
|
|
timeoutType, err := enumspb.TimeoutTypeFromString(timeoutTypeValue)
|
|
if err != nil || enumspb.TimeoutType(timeoutType) == enumspb.TIMEOUT_TYPE_UNSPECIFIED {
|
|
return serviceerror.NewInvalidArgument(fmt.Sprintf("Invalid timeout type value: %v.", timeoutTypeValue))
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|