mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
7921c5d55f
## What changed? <!-- Describe what has changed in this PR --> Happy-path implementation for https://github.com/temporalio/api/pull/367 This is just the first version; it'll need more work (e.g. more validation and tests) before it can be production-ready. It is behind a feature flag. ## Why? <!-- Tell your future self why have you made these changes --> Putting up the review now so the [API change](https://github.com/temporalio/api/pull/367) can be merged; and no feature branch is necessary anymore. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Net new API behind feature flag, needs more testing. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> It's behind a feature flag. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> --------- Co-authored-by: Alex Shtin <[email protected]>
110 lines
3.7 KiB
Go
110 lines
3.7 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package pollupdate
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
"go.temporal.io/api/workflowservice/v1"
|
|
|
|
updatepb "go.temporal.io/api/update/v1"
|
|
"go.temporal.io/server/api/historyservice/v1"
|
|
"go.temporal.io/server/common/definition"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/service/history/api"
|
|
"go.temporal.io/server/service/history/shard"
|
|
"go.temporal.io/server/service/history/workflow"
|
|
"go.temporal.io/server/service/history/workflow/update"
|
|
)
|
|
|
|
func Invoke(
|
|
ctx context.Context,
|
|
req *historyservice.PollWorkflowExecutionUpdateRequest,
|
|
shardContext shard.Context,
|
|
ctxLookup api.WorkflowConsistencyChecker,
|
|
) (*historyservice.PollWorkflowExecutionUpdateResponse, error) {
|
|
waitStage := req.GetRequest().GetWaitPolicy().GetLifecycleStage()
|
|
updateRef := req.GetRequest().GetUpdateRef()
|
|
wfexec := updateRef.GetWorkflowExecution()
|
|
wfKey, upd, ok, err := func() (*definition.WorkflowKey, *update.Update, bool, error) {
|
|
workflowLease, err := ctxLookup.GetWorkflowLease(
|
|
ctx,
|
|
nil,
|
|
api.BypassMutableStateConsistencyPredicate,
|
|
definition.NewWorkflowKey(
|
|
req.GetNamespaceId(),
|
|
wfexec.GetWorkflowId(),
|
|
wfexec.GetRunId(),
|
|
),
|
|
workflow.LockPriorityHigh,
|
|
)
|
|
if err != nil {
|
|
return nil, nil, false, err
|
|
}
|
|
release := workflowLease.GetReleaseFn()
|
|
defer release(nil)
|
|
wfCtx := workflowLease.GetContext()
|
|
upd, found := wfCtx.UpdateRegistry(ctx, nil).Find(ctx, updateRef.UpdateId)
|
|
wfKey := wfCtx.GetWorkflowKey()
|
|
return &wfKey, upd, found, nil
|
|
}()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !ok {
|
|
return nil, serviceerror.NewNotFound(fmt.Sprintf("update %q not found", updateRef.GetUpdateId()))
|
|
}
|
|
|
|
namespaceID := namespace.ID(req.GetNamespaceId())
|
|
ns, err := shardContext.GetNamespaceRegistry().GetNamespaceByID(namespaceID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
softTimeout := shardContext.GetConfig().LongPollExpirationInterval(ns.Name().String())
|
|
// If the long-poll times out due to softTimeout
|
|
// then return a non-error empty response with actual reached stage.
|
|
status, err := upd.WaitLifecycleStage(ctx, waitStage, softTimeout)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &historyservice.PollWorkflowExecutionUpdateResponse{
|
|
Response: &workflowservice.PollWorkflowExecutionUpdateResponse{
|
|
Outcome: status.Outcome,
|
|
Stage: status.Stage,
|
|
UpdateRef: &updatepb.UpdateRef{
|
|
WorkflowExecution: &commonpb.WorkflowExecution{
|
|
WorkflowId: wfKey.WorkflowID,
|
|
RunId: wfKey.RunID,
|
|
},
|
|
UpdateId: updateRef.UpdateId,
|
|
},
|
|
},
|
|
}, nil
|
|
}
|