Files
Yichao YangandGitHub 35bc043690 Remove runID from persistence addTasks request (#5594)
## What changed?
<!-- Describe what has changed in this PR -->
- Remove runID from persistence addTasks request

## Why?
<!-- Tell your future self why have you made these changes -->
- Not used. NamespaceID and workflowID could be used by some persistence
implementation.
- A task may target a workflowID (a workflow chain) instead of an
specific run of the workflow

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Existing tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
- N/A, the field is not used.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
- N/A

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
- No.
2024-03-28 15:33:51 -07:00

82 lines
2.6 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package refreshworkflow
import (
"context"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/service/history/api"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/workflow"
)
func Invoke(
ctx context.Context,
workflowKey definition.WorkflowKey,
shard shard.Context,
workflowConsistencyChecker api.WorkflowConsistencyChecker,
) (retError error) {
err := api.ValidateNamespaceUUID(namespace.ID(workflowKey.NamespaceID))
if err != nil {
return err
}
workflowLease, err := workflowConsistencyChecker.GetWorkflowLease(
ctx,
nil,
api.BypassMutableStateConsistencyPredicate,
workflowKey,
workflow.LockPriorityLow,
)
if err != nil {
return err
}
defer func() { workflowLease.GetReleaseFn()(retError) }()
mutableState := workflowLease.GetMutableState()
mutableStateTaskRefresher := workflow.NewTaskRefresher(
shard,
shard.GetConfig(),
shard.GetNamespaceRegistry(),
shard.GetLogger(),
)
err = mutableStateTaskRefresher.RefreshTasks(ctx, mutableState)
if err != nil {
return err
}
return shard.AddTasks(ctx, &persistence.AddHistoryTasksRequest{
ShardID: shard.GetShardID(),
// RangeID is set by shard
NamespaceID: workflowKey.NamespaceID,
WorkflowID: workflowKey.WorkflowID,
Tasks: mutableState.PopTasks(),
})
}