mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Stephan BehnkeandGitHub
e2a5ab2e9b
## What changed? <!-- Describe what has changed in this PR --> Set default for `WorkflowIdConflictPolicy` in History as well. ## Why? <!-- Tell your future self why have you made these changes --> An issue can happen on downgrade where the Frontend is running a previous version that doesn't set the default but the newer History expects it. ## How did you test it? Tested locally by commenting out the code in Frontend and History; ensuring it fails and then re-enabling the code in History to verify it fixes it. ## Potential risks None; if there is a policy already, nothing happens. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
115 lines
3.8 KiB
Go
115 lines
3.8 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package signalwithstartworkflow
|
|
|
|
import (
|
|
"context"
|
|
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
"go.temporal.io/server/common/enums"
|
|
|
|
"go.temporal.io/server/api/historyservice/v1"
|
|
"go.temporal.io/server/common/definition"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/service/history/api"
|
|
"go.temporal.io/server/service/history/shard"
|
|
"go.temporal.io/server/service/history/workflow"
|
|
)
|
|
|
|
func Invoke(
|
|
ctx context.Context,
|
|
signalWithStartRequest *historyservice.SignalWithStartWorkflowExecutionRequest,
|
|
shard shard.Context,
|
|
workflowConsistencyChecker api.WorkflowConsistencyChecker,
|
|
) (_ *historyservice.SignalWithStartWorkflowExecutionResponse, retError error) {
|
|
namespaceEntry, err := api.GetActiveNamespace(shard, namespace.ID(signalWithStartRequest.GetNamespaceId()))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
namespaceID := namespaceEntry.ID()
|
|
|
|
var currentWorkflowLease api.WorkflowLease
|
|
currentWorkflowLease, err = workflowConsistencyChecker.GetWorkflowLease(
|
|
ctx,
|
|
nil,
|
|
api.BypassMutableStateConsistencyPredicate,
|
|
definition.NewWorkflowKey(
|
|
string(namespaceID),
|
|
signalWithStartRequest.SignalWithStartRequest.WorkflowId,
|
|
"",
|
|
),
|
|
workflow.LockPriorityHigh,
|
|
)
|
|
switch err.(type) {
|
|
case nil:
|
|
defer func() { currentWorkflowLease.GetReleaseFn()(retError) }()
|
|
case *serviceerror.NotFound:
|
|
currentWorkflowLease = nil
|
|
default:
|
|
return nil, err
|
|
}
|
|
|
|
// TODO: remove this call in 1.25
|
|
enums.SetDefaultWorkflowIdConflictPolicy(
|
|
&signalWithStartRequest.SignalWithStartRequest.WorkflowIdConflictPolicy,
|
|
enumspb.WORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING)
|
|
|
|
api.MigrateWorkflowIdReusePolicyForRunningWorkflow(
|
|
&signalWithStartRequest.SignalWithStartRequest.WorkflowIdReusePolicy,
|
|
&signalWithStartRequest.SignalWithStartRequest.WorkflowIdConflictPolicy)
|
|
|
|
startRequest := ConvertToStartRequest(
|
|
namespaceID,
|
|
signalWithStartRequest.SignalWithStartRequest,
|
|
shard.GetTimeSource().Now(),
|
|
)
|
|
request := startRequest.StartRequest
|
|
|
|
api.OverrideStartWorkflowExecutionRequest(request, metrics.HistorySignalWithStartWorkflowExecutionScope, shard, shard.GetMetricsHandler())
|
|
|
|
err = api.ValidateStartWorkflowExecutionRequest(ctx, request, shard, namespaceEntry, "SignalWithStartWorkflowExecution")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
runID, started, err := SignalWithStartWorkflow(
|
|
ctx,
|
|
shard,
|
|
namespaceEntry,
|
|
currentWorkflowLease,
|
|
startRequest,
|
|
signalWithStartRequest.SignalWithStartRequest,
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &historyservice.SignalWithStartWorkflowExecutionResponse{
|
|
RunId: runID,
|
|
Started: started,
|
|
}, nil
|
|
}
|