Files
tasks/service/history/replication/sequential_batch_queue.go
Will DuanandGitHub 9f18a0b527 Implement the batching functionality on history event replication task (#4916)
<!-- Describe what has changed in this PR -->
**What changed?**
Implement the batching functionality on history event replication task

<!-- Tell your future self why have you made these changes -->
**Why?**
Improve performance of history event replication task

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
manually tested locally. Unit tests.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
N/a. Feature is behind a feature flag.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
no
2023-10-16 19:02:02 +00:00

142 lines
4.4 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package replication
import (
"sync"
"go.temporal.io/server/common/collection"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
ctasks "go.temporal.io/server/common/tasks"
)
type (
SequentialBatchableTaskQueue struct {
id interface{}
sync.Mutex
taskQueue collection.Queue[*batchedTask]
lastTask *batchedTask
batchedIndividualTaskHandler func(task TrackableExecutableTask)
logger log.Logger
metricsHandler metrics.Handler
}
)
func NewSequentialBatchableTaskQueue(
task TrackableExecutableTask,
batchedIndividualTaskHandler func(task TrackableExecutableTask),
logger log.Logger,
metricsHandler metrics.Handler,
) ctasks.SequentialTaskQueue[TrackableExecutableTask] {
return &SequentialBatchableTaskQueue{
id: task.QueueID(),
taskQueue: collection.NewPriorityQueue[*batchedTask](
sequentialBatchableTaskQueueCompareLess,
),
batchedIndividualTaskHandler: batchedIndividualTaskHandler,
logger: logger,
metricsHandler: metricsHandler,
}
}
func (q *SequentialBatchableTaskQueue) ID() interface{} {
return q.id
}
func (q *SequentialBatchableTaskQueue) Peek() TrackableExecutableTask {
q.Lock()
defer q.Unlock()
return q.taskQueue.Peek()
}
// Add will try to batch input task with the last task in the queue. Since most likely incoming task
// are ordered by task ID, we only try to batch incoming task with last task in the queue.
func (q *SequentialBatchableTaskQueue) Add(task TrackableExecutableTask) {
q.Lock()
defer q.Unlock()
if q.lastTask != nil && q.lastTask.AddTask(task) {
return
}
incomingTask := q.createBatchedTask(task)
q.taskQueue.Add(incomingTask)
q.updateLastTask(incomingTask)
}
func (q *SequentialBatchableTaskQueue) Remove() (task TrackableExecutableTask) {
q.Lock()
defer q.Unlock()
taskToRemove := q.taskQueue.Remove()
if taskToRemove == q.lastTask {
q.lastTask = nil
}
return taskToRemove
}
func (q *SequentialBatchableTaskQueue) IsEmpty() bool {
q.Lock()
defer q.Unlock()
return q.taskQueue.IsEmpty()
}
func (q *SequentialBatchableTaskQueue) Len() int {
q.Lock()
defer q.Unlock()
return q.taskQueue.Len()
}
func (q *SequentialBatchableTaskQueue) updateLastTask(task *batchedTask) {
if q.lastTask == nil || sequentialBatchableTaskQueueCompareLess(q.lastTask, task) {
q.lastTask = task
}
}
func (q *SequentialBatchableTaskQueue) createBatchedTask(task TrackableExecutableTask) *batchedTask {
return &batchedTask{
batchedTask: task,
individualTasks: []TrackableExecutableTask{task},
state: batchStateOpen,
// This is to add individual task back to this queue, so it can be processed again. This is based on an assumption: only one thread is
// interacting with the queue. And this is a shortcut because a proper way is to resubmit the individual tasks back to scheduler.
// But that requires a refactor on scheduler and task lifecycle and could be risky to included in this feature implementation.
//
individualTaskHandler: func(task TrackableExecutableTask) {
q.Add(task)
},
logger: q.logger,
metricsHandler: q.metricsHandler,
}
}
func sequentialBatchableTaskQueueCompareLess(this *batchedTask, that *batchedTask) bool {
return SequentialTaskQueueCompareLess(this, that)
}