Files
tasks/service/matching/reachability.go
Carly de FrondevilleandGitHub 41993fb63f Reachability optimization: add caching for visibility (#5816)
## What changed?
Add an LRU cache that reachability calls before reaching out to
visibility. Separate cache for open and closed workflow executions so
that there can be separate TTL. TTL configurable via dynamic config.
Include cache hit/miss in `reachabilityExitPoint` so that it can be
logged and tracked in prometheus, making there be 6
`reachabilityExitPoint` options.

## Why?
To reduce load on visibility.

## How did you test it?
Tested with unit tests and existing functional tests.
Added additional functional test that exercises the reachability cache
by doing:
1. Add assignment rule `A` and start workflow with build id `A`
2. Wait for `A` to show up as `running` in visibility db
3. Commit a different build id --> `A` should now only be reachable via
visibility query
4. Query `reachability(A)` --> `reachable` by visibility db, populating
reachability open WF cache with `A: true`
5. Signal workflow with build id `A` so that it completes
6. Wait for `A` to show up as `closed` in visibility db (cache TTL must
be longer than this wait time)
7. Query `reachability(A)` --> `reachable` by reachability cache
8. Wait for `testReachabilityCacheOpenWFsTTL` to pass
9. Query `reachability(A)` --> `closed_only` by visibility db,
populating reachability closed WF cache with `A: true`

## Potential risks
Worst case scenario would be that reachability returns a false-negative.
Due to cache TTL there is the possibility of a false-positive, but
eventually the false positive will resolve due to TTL

## Documentation
Make sure to add the false-positive caveat to docs.

## Is hotfix candidate?
No
2024-05-03 18:35:09 -07:00

374 lines
14 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package matching
import (
"context"
"fmt"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"slices"
"strings"
"time"
"github.com/temporalio/sqlparser"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/server/api/clock/v1"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common/cache"
hlc "go.temporal.io/server/common/clock/hybrid_logical_clock"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence/visibility/manager"
"go.temporal.io/server/common/searchattribute"
"go.temporal.io/server/common/util"
"go.temporal.io/server/common/worker_versioning"
)
const (
reachabilityCacheMaxSize = 10000
)
type reachabilityExitPoint int32
const (
checkedRuleSourcesForInput reachabilityExitPoint = 0
checkedRuleTargetsForUpstream reachabilityExitPoint = 1
checkedBacklogForUpstream reachabilityExitPoint = 2
checkedOpenWorkflowExecutionsForUpstreamHit reachabilityExitPoint = 3
checkedOpenWorkflowExecutionsForUpstreamMiss reachabilityExitPoint = 4
checkedClosedWorkflowExecutionsForUpstreamHit reachabilityExitPoint = 5
checkedClosedWorkflowExecutionsForUpstreamMiss reachabilityExitPoint = 6
reachabilityExitPointTagName = "reachability_exit_point"
)
var (
reachabilityExitPoint2TagValue = map[reachabilityExitPoint]string{
checkedRuleSourcesForInput: "checked_rule_sources_for_input",
checkedRuleTargetsForUpstream: "checked_rule_targets_for_upstream",
checkedBacklogForUpstream: "checked_backlog_for_upstream",
checkedOpenWorkflowExecutionsForUpstreamHit: "checked_open_wf_executions_for_upstream_hit",
checkedOpenWorkflowExecutionsForUpstreamMiss: "checked_open_wf_executions_for_upstream_miss",
checkedClosedWorkflowExecutionsForUpstreamHit: "checked_closed_wf_executions_for_upstream_hit",
checkedClosedWorkflowExecutionsForUpstreamMiss: "checked_closed_wf_executions_for_upstream_miss",
}
)
type reachabilityCalculator struct {
cache reachabilityCache
nsID namespace.ID
nsName namespace.Name
taskQueue string
assignmentRules []*persistencespb.AssignmentRule
redirectRules []*persistencespb.RedirectRule
buildIdVisibilityGracePeriod time.Duration
}
func newReachabilityCalculator(
data *persistencespb.VersioningData,
rCache reachabilityCache,
nsID,
nsName,
taskQueue string,
buildIdVisibilityGracePeriod time.Duration,
) *reachabilityCalculator {
return &reachabilityCalculator{
cache: rCache,
nsID: namespace.ID(nsID),
nsName: namespace.Name(nsName),
taskQueue: taskQueue,
assignmentRules: data.GetAssignmentRules(),
redirectRules: data.GetRedirectRules(),
buildIdVisibilityGracePeriod: buildIdVisibilityGracePeriod,
}
}
func getBuildIdTaskReachability(
ctx context.Context,
rc *reachabilityCalculator,
metricsHandler metrics.Handler,
logger log.Logger,
buildId string,
) (enumspb.BuildIdTaskReachability, error) {
reachability, exitPoint, err := rc.run(ctx, buildId)
metrics.ReachabilityExitPointCounter.With(metricsHandler.WithTags(
metrics.NamespaceTag(rc.nsName.String()),
metrics.TaskQueueTag(rc.taskQueue)),
).Record(1, metrics.StringTag(reachabilityExitPointTagName, reachabilityExitPoint2TagValue[exitPoint]))
logger.Info("Calculated reachability for build id",
tag.WorkerBuildId(buildId),
tag.BuildIdTaskReachabilityTag(reachability.String()),
tag.ReachabilityExitPointTag(reachabilityExitPoint2TagValue[exitPoint]),
tag.WorkflowNamespace(rc.nsName.String()),
tag.WorkflowTaskQueueName(rc.taskQueue),
)
return reachability, err
}
func (rc *reachabilityCalculator) run(ctx context.Context, buildId string) (enumspb.BuildIdTaskReachability, reachabilityExitPoint, error) {
// 1. Easy UNREACHABLE case
if isActiveRedirectRuleSource(buildId, rc.redirectRules) {
return enumspb.BUILD_ID_TASK_REACHABILITY_UNREACHABLE, checkedRuleSourcesForInput, nil
}
// Gather list of all build ids that could point to buildId
buildIdsOfInterest := rc.getBuildIdsOfInterest(buildId, time.Duration(0))
// 2. Cases for REACHABLE
// 2a. If buildId is assignable to new tasks
for _, bid := range buildIdsOfInterest {
if rc.isReachableActiveAssignmentRuleTargetOrDefault(bid) {
return enumspb.BUILD_ID_TASK_REACHABILITY_REACHABLE, checkedRuleTargetsForUpstream, nil
}
}
// 2b. If buildId could be reached from the backlog
if existsBacklog, err := rc.existsBackloggedActivityOrWFTaskAssignedToAny(ctx, buildIdsOfInterest); err != nil {
return enumspb.BUILD_ID_TASK_REACHABILITY_UNSPECIFIED, checkedBacklogForUpstream, err
} else if existsBacklog {
return enumspb.BUILD_ID_TASK_REACHABILITY_REACHABLE, checkedBacklogForUpstream, nil
}
// Note: The below cases are not applicable to activity-only task queues, since we don't record those in visibility
// Gather list of all build ids that could point to buildId, now including deleted rules to account for the delay in updating visibility
buildIdsOfInterest = rc.getBuildIdsOfInterest(buildId, rc.buildIdVisibilityGracePeriod)
// 2c. If buildId is assignable to tasks from open workflows
existsOpenWFAssignedToBuildId, hit, err := rc.existsWFAssignedToAny(ctx, buildIdsOfInterest, true)
if err != nil {
return enumspb.BUILD_ID_TASK_REACHABILITY_UNSPECIFIED, checkedOpenWorkflowExecutionsForUpstreamMiss, err
}
if existsOpenWFAssignedToBuildId {
return enumspb.BUILD_ID_TASK_REACHABILITY_REACHABLE, getCacheExitPoint(true, hit), nil
}
// 3. Cases for CLOSED_WORKFLOWS_ONLY
existsClosedWFAssignedToBuildId, hit, err := rc.existsWFAssignedToAny(ctx, buildIdsOfInterest, false)
if err != nil {
return enumspb.BUILD_ID_TASK_REACHABILITY_UNSPECIFIED, checkedClosedWorkflowExecutionsForUpstreamMiss, err
}
if existsClosedWFAssignedToBuildId {
return enumspb.BUILD_ID_TASK_REACHABILITY_CLOSED_WORKFLOWS_ONLY, getCacheExitPoint(false, hit), nil
}
// 4. Otherwise, UNREACHABLE
return enumspb.BUILD_ID_TASK_REACHABILITY_UNREACHABLE, getCacheExitPoint(false, hit), nil
}
func getCacheExitPoint(open, hit bool) reachabilityExitPoint {
if open {
if hit {
return checkedOpenWorkflowExecutionsForUpstreamHit
}
return checkedOpenWorkflowExecutionsForUpstreamMiss
}
if hit {
return checkedClosedWorkflowExecutionsForUpstreamHit
}
return checkedClosedWorkflowExecutionsForUpstreamMiss
}
// getBuildIdsOfInterest returns a list of build ids that point to the given buildId in the graph
// of redirect rules and adds the given build id to that list.
// It considers rules if the deletion time is nil or within the given deletedRuleInclusionPeriod.
func (rc *reachabilityCalculator) getBuildIdsOfInterest(
buildId string,
deletedRuleInclusionPeriod time.Duration) []string {
withinRuleInclusionPeriod := func(clk *clock.HybridLogicalClock) bool {
if clk == nil {
return true
}
return hlc.Since(clk) <= deletedRuleInclusionPeriod
}
includedRules := util.FilterSlice(slices.Clone(rc.redirectRules), func(rr *persistencespb.RedirectRule) bool {
return rr.DeleteTimestamp == nil || withinRuleInclusionPeriod(rr.DeleteTimestamp)
})
return append(getUpstreamBuildIds(buildId, includedRules), buildId)
}
func (rc *reachabilityCalculator) existsBackloggedActivityOrWFTaskAssignedToAny(ctx context.Context, buildIdsOfInterest []string) (bool, error) {
// todo backlog
return false, nil
}
func (rc *reachabilityCalculator) isReachableActiveAssignmentRuleTargetOrDefault(buildId string) bool {
foundUnconditionalRule := false
for _, r := range getActiveAssignmentRules(rc.assignmentRules) {
if r.GetRule().GetTargetBuildId() == buildId {
return true
}
if r.GetRule().GetPercentageRamp() == nil {
// rules after an unconditional rule will not be reached
foundUnconditionalRule = true
break
}
}
if !foundUnconditionalRule && buildId == "" {
// unversioned is the default, and is reachable
return true
}
return false
}
func (rc *reachabilityCalculator) existsWFAssignedToAny(
ctx context.Context,
buildIdsOfInterest []string,
open bool,
) (exists, hit bool, err error) {
query := rc.makeBuildIdQuery(buildIdsOfInterest, open)
return rc.cache.Get(ctx, *rc.makeBuildIdCountRequest(query), open)
}
func (rc *reachabilityCalculator) makeBuildIdCountRequest(query string) *manager.CountWorkflowExecutionsRequest {
return &manager.CountWorkflowExecutionsRequest{
NamespaceID: rc.nsID,
Namespace: rc.nsName,
Query: query,
}
}
func (rc *reachabilityCalculator) makeBuildIdQuery(
buildIdsOfInterest []string,
open bool,
) string {
slices.Sort(buildIdsOfInterest)
escapedTaskQueue := sqlparser.String(sqlparser.NewStrVal([]byte(rc.taskQueue)))
var statusFilter string
var escapedBuildIds []string
var includeNull bool
if open {
statusFilter = fmt.Sprintf(` AND %s = "Running"`, searchattribute.ExecutionStatus)
// want: currently assigned to that build-id
// (b1, b2) --> (assigned:b1, assigned:b2)
// (b1, b2, "") --> (assigned:b1, assigned:b2, unversioned, null)
// ("") --> (unversioned, null)
for _, bid := range buildIdsOfInterest {
if bid == "" {
escapedBuildIds = append(escapedBuildIds, sqlparser.String(sqlparser.NewStrVal([]byte(worker_versioning.UnversionedSearchAttribute))))
includeNull = true
} else {
escapedBuildIds = append(escapedBuildIds, sqlparser.String(sqlparser.NewStrVal([]byte(worker_versioning.AssignedBuildIdSearchAttribute(bid)))))
}
}
} else {
statusFilter = fmt.Sprintf(` AND %s != "Running"`, searchattribute.ExecutionStatus)
// want: closed AT that build id, and once used that build id
// (b1, b2) --> (versioned:b1, versioned:b2)
// (b1, b2, "") --> (versioned:b1, versioned:b2, unversioned, null)
// ("") --> (unversioned, null)
for _, bid := range buildIdsOfInterest {
if bid == "" {
escapedBuildIds = append(escapedBuildIds, sqlparser.String(sqlparser.NewStrVal([]byte(worker_versioning.UnversionedSearchAttribute))))
includeNull = true
} else {
escapedBuildIds = append(escapedBuildIds, sqlparser.String(sqlparser.NewStrVal([]byte(worker_versioning.VersionedBuildIdSearchAttribute(bid)))))
}
}
}
buildIdsFilter := fmt.Sprintf("%s IN (%s)", searchattribute.BuildIds, strings.Join(escapedBuildIds, ","))
if includeNull {
buildIdsFilter = fmt.Sprintf("(%s IS NULL OR %s)", searchattribute.BuildIds, buildIdsFilter)
}
return fmt.Sprintf("%s = %s AND %s%s", searchattribute.TaskQueue, escapedTaskQueue, buildIdsFilter, statusFilter)
}
// getDefaultBuildId gets the build id mentioned in the first unconditional Assignment Rule.
// If there is no default Build ID, the result for the unversioned queue will be returned.
// This should only be called on the root.
func getDefaultBuildId(assignmentRules []*persistencespb.AssignmentRule) string {
for _, ar := range getActiveAssignmentRules(assignmentRules) {
if isUnconditional(ar.GetRule()) {
return ar.GetRule().GetTargetBuildId()
}
}
return ""
}
/*
In-memory Reachability Cache of Visibility Queries and Results
*/
type reachabilityCache struct {
openWFCache cache.Cache
closedWFCache cache.Cache // these are separate due to allow for different TTL
metricsHandler metrics.Handler
visibilityMgr manager.VisibilityManager
}
func newReachabilityCache(
handler metrics.Handler,
visibilityMgr manager.VisibilityManager,
reachabilityCacheOpenWFExecutionTTL,
reachabilityCacheClosedWFExecutionTTL time.Duration,
) reachabilityCache {
return reachabilityCache{
openWFCache: cache.New(reachabilityCacheMaxSize, &cache.Options{TTL: reachabilityCacheOpenWFExecutionTTL}, handler),
closedWFCache: cache.New(reachabilityCacheMaxSize, &cache.Options{TTL: reachabilityCacheClosedWFExecutionTTL}, handler),
metricsHandler: handler,
visibilityMgr: visibilityMgr,
}
}
// Get retrieves the Workflow Count existence value based on the query-string key.
func (c *reachabilityCache) Get(ctx context.Context, countRequest manager.CountWorkflowExecutionsRequest, open bool) (exists, hit bool, err error) {
// try cache
var result interface{}
if open {
result = c.openWFCache.Get(countRequest)
} else {
result = c.closedWFCache.Get(countRequest)
}
if result != nil {
// there's no reason that the cache would ever contain a non-bool, but just in case, treat non-bool as a miss
exists, ok := result.(bool)
if ok {
return exists, true, nil
}
}
// cache was cold, ask visibility and put result in cache
countResponse, err := c.visibilityMgr.CountWorkflowExecutions(ctx, &countRequest)
if err != nil {
return false, false, err
}
exists = countResponse.Count > 0
c.Put(countRequest, exists, open)
return exists, false, nil
}
// Put adds an element to the cache.
func (c *reachabilityCache) Put(countRequest manager.CountWorkflowExecutionsRequest, exists, open bool) {
if open {
c.openWFCache.Put(countRequest, exists)
} else {
c.closedWFCache.Put(countRequest, exists)
}
}