Files
Yichao YangandGitHub 7160aa4c0f Deprecate persistence priority rate limiting flag (#5683)
## What changed?
<!-- Describe what has changed in this PR -->
- Deprecate persistence priority rate limiting flag

## Why?
<!-- Tell your future self why have you made these changes -->
- Those flags have been enabled by default for several releases and is
stable.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Existing tests

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
- Won't be able to disable the feature in prod.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
- N/A

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
- No.
2024-04-23 21:11:06 +00:00

186 lines
6.3 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package worker
import (
"context"
"go.uber.org/fx"
"go.temporal.io/server/api/adminservice/v1"
"go.temporal.io/server/client"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/membership"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/visibility"
"go.temporal.io/server/common/persistence/visibility/manager"
esclient "go.temporal.io/server/common/persistence/visibility/store/elasticsearch/client"
"go.temporal.io/server/common/primitives"
"go.temporal.io/server/common/resolver"
"go.temporal.io/server/common/resource"
"go.temporal.io/server/common/searchattribute"
"go.temporal.io/server/service"
"go.temporal.io/server/service/worker/addsearchattributes"
"go.temporal.io/server/service/worker/batcher"
workercommon "go.temporal.io/server/service/worker/common"
"go.temporal.io/server/service/worker/deletenamespace"
"go.temporal.io/server/service/worker/dlq"
"go.temporal.io/server/service/worker/migration"
"go.temporal.io/server/service/worker/scheduler"
)
var Module = fx.Options(
migration.Module,
addsearchattributes.Module,
resource.Module,
deletenamespace.Module,
scheduler.Module,
batcher.Module,
dlq.Module,
fx.Provide(
func(c resource.HistoryClient) dlq.HistoryClient {
return c
},
func(m cluster.Metadata) dlq.CurrentClusterName {
return dlq.CurrentClusterName(m.GetCurrentClusterName())
},
func(b client.Bean) dlq.TaskClientDialer {
return dlq.TaskClientDialerFn(func(_ context.Context, address string) (dlq.TaskClient, error) {
c, err := b.GetRemoteAdminClient(address)
if err != nil {
return nil, err
}
return dlq.AddTasksFn(func(
ctx context.Context,
req *adminservice.AddTasksRequest,
) (*adminservice.AddTasksResponse, error) {
return c.AddTasks(ctx, req)
}), nil
})
},
),
fx.Provide(VisibilityManagerProvider),
fx.Provide(dynamicconfig.NewCollection),
fx.Provide(ThrottledLoggerRpsFnProvider),
fx.Provide(ConfigProvider),
fx.Provide(PersistenceRateLimitingParamsProvider),
service.PersistenceLazyLoadedServiceResolverModule,
fx.Provide(ServiceResolverProvider),
fx.Provide(func(
clusterMetadata cluster.Metadata,
metadataManager persistence.MetadataManager,
logger log.Logger,
) namespace.ReplicationTaskExecutor {
return namespace.NewReplicationTaskExecutor(
clusterMetadata.GetCurrentClusterName(),
metadataManager,
logger,
)
}),
fx.Provide(NewService),
fx.Provide(fx.Annotate(NewWorkerManager, fx.ParamTags(workercommon.WorkerComponentTag))),
fx.Provide(NewPerNamespaceWorkerManager),
fx.Invoke(ServiceLifetimeHooks),
)
func ThrottledLoggerRpsFnProvider(serviceConfig *Config) resource.ThrottledLoggerRpsFn {
return func() float64 { return float64(serviceConfig.ThrottledLogRPS()) }
}
func PersistenceRateLimitingParamsProvider(
serviceConfig *Config,
persistenceLazyLoadedServiceResolver service.PersistenceLazyLoadedServiceResolver,
logger log.SnTaggedLogger,
) service.PersistenceRateLimitingParams {
return service.NewPersistenceRateLimitingParams(
serviceConfig.PersistenceMaxQPS,
serviceConfig.PersistenceGlobalMaxQPS,
serviceConfig.PersistenceNamespaceMaxQPS,
serviceConfig.PersistenceGlobalNamespaceMaxQPS,
serviceConfig.PersistencePerShardNamespaceMaxQPS,
serviceConfig.OperatorRPSRatio,
serviceConfig.PersistenceQPSBurstRatio,
serviceConfig.PersistenceDynamicRateLimitingParams,
persistenceLazyLoadedServiceResolver,
logger,
)
}
func ServiceResolverProvider(
membershipMonitor membership.Monitor,
) (membership.ServiceResolver, error) {
return membershipMonitor.GetResolver(primitives.WorkerService)
}
func ConfigProvider(
dc *dynamicconfig.Collection,
persistenceConfig *config.Persistence,
) *Config {
return NewConfig(
dc,
persistenceConfig,
)
}
func VisibilityManagerProvider(
logger log.Logger,
metricsHandler metrics.Handler,
persistenceConfig *config.Persistence,
customVisibilityStoreFactory visibility.VisibilityStoreFactory,
serviceConfig *Config,
esClient esclient.Client,
persistenceServiceResolver resolver.ServiceResolver,
searchAttributesMapperProvider searchattribute.MapperProvider,
saProvider searchattribute.Provider,
) (manager.VisibilityManager, error) {
return visibility.NewManager(
*persistenceConfig,
persistenceServiceResolver,
customVisibilityStoreFactory,
esClient,
nil, // worker visibility never write
saProvider,
searchAttributesMapperProvider,
serviceConfig.VisibilityPersistenceMaxReadQPS,
serviceConfig.VisibilityPersistenceMaxWriteQPS,
serviceConfig.OperatorRPSRatio,
serviceConfig.EnableReadFromSecondaryVisibility,
dynamicconfig.GetStringPropertyFn(visibility.SecondaryVisibilityWritingModeOff), // worker visibility never write
serviceConfig.VisibilityDisableOrderByClause,
serviceConfig.VisibilityEnableManualPagination,
metricsHandler,
logger,
)
}
func ServiceLifetimeHooks(lc fx.Lifecycle, svc *Service) {
lc.Append(fx.StartStopHook(svc.Start, svc.Stop))
}