mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? This change adds a flag to `temporal-sql-tool` and `temporal-cassandra-tool`'s `update-schema` and `setup-schema` to specify an embedded schema instead of a path to the schema directory or schema file. ``` NAME: temporal-cassandra-tool update-schema - update cassandra schema to a specific version USAGE: temporal-cassandra-tool update-schema [command options] [arguments...] OPTIONS: --version value, -v value target version for the schema update, defaults to latest --schema-dir value, -d value path to directory containing versioned schema --schema-name value, -s value name of embedded versioned schema, one of: [cassandra/temporal cassandra/visibility] ``` ``` NAME: temporal-sql-tool update-schema - update sql schema to a specific version USAGE: temporal-sql-tool update-schema [command options] [arguments...] OPTIONS: --version value, -v value target version for the schema update, defaults to latest --schema-dir value, -d value path to directory containing versioned schema --schema-name value, -s value name of embedded versioned schema, one of: [mysql/v57/temporal mysql/v57/visibility mysql/v8/temporal mysql/v8/visibility postgresql/v96/temporal postgresql/v96/visibility postgresql/v12/temporal postgresql/v12/visibility] ``` ## Why? We want to embed the db schemas in the `temporal-sql-tool` and `temporal-cassandra-tool` with `go:embed` so that customers can simply specify which schema they want using a flag instead of having to copy the schema files to wherever they're running the db tool and passing the path to the schema. https://github.com/temporalio/temporal/issues/2059 ## How did you test it? I wrote a new unit test for reading the embedded file system, and the existing codepath of the changed functions are all tested by the existing unit tests. I also updated the unit test for config validation to reflect the new changes. I tested this locally with a locally running Postgres. Since the more complex changes are in `updatetask.go`, which is shared by the sql and the cassandra tool, I think there is no need to also test with a real cassandra db. I also built the cassandra command line tool and confirmed that the flags and validation checks behaved as expected. ## Potential risks Schema updates could fail. But the changes are pretty contained to the new `-s` flag which isn't used anywhere in production yet, so the risk is very low. The code for the `-d` flag remained basically the same. ## Is hotfix candidate? No
260 lines
7.9 KiB
Go
260 lines
7.9 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package cassandra
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/urfave/cli"
|
|
|
|
"go.temporal.io/server/common/auth"
|
|
c "go.temporal.io/server/common/config"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/environment"
|
|
"go.temporal.io/server/tools/common/schema"
|
|
)
|
|
|
|
const defaultNumReplicas = 1
|
|
|
|
// SetupSchemaConfig contains the configuration params needed to setup schema tables
|
|
type SetupSchemaConfig struct {
|
|
CQLClientConfig
|
|
schema.SetupConfig
|
|
}
|
|
|
|
// setupSchema executes the setupSchemaTask
|
|
// using the given command line arguments
|
|
// as input
|
|
func setupSchema(cli *cli.Context, logger log.Logger) error {
|
|
config, err := newCQLClientConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
client, err := newCQLClient(config, logger)
|
|
if err != nil {
|
|
logger.Error("Unable to establish CQL session.", tag.Error(err))
|
|
return err
|
|
}
|
|
defer client.Close()
|
|
if err := schema.Setup(cli, client, logger); err != nil {
|
|
logger.Error("Unable to setup CQL schema.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// updateSchema executes the updateSchemaTask
|
|
// using the given command line args as input
|
|
func updateSchema(cli *cli.Context, logger log.Logger) error {
|
|
config, err := newCQLClientConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
client, err := newCQLClient(config, logger)
|
|
if err != nil {
|
|
logger.Error("Unable to establish CQL session.", tag.Error(err))
|
|
return err
|
|
}
|
|
defer client.Close()
|
|
if err := schema.Update(cli, client, logger); err != nil {
|
|
logger.Error("Unable to update CQL schema.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func createKeyspace(cli *cli.Context, logger log.Logger) error {
|
|
config, err := newCQLClientConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
keyspace := cli.String(schema.CLIOptKeyspace)
|
|
if keyspace == "" {
|
|
err := fmt.Errorf("missing %s argument", flag(schema.CLIOptKeyspace))
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
err = doCreateKeyspace(config, keyspace, logger)
|
|
if err != nil {
|
|
logger.Error("Unable to create keyspace.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func dropKeyspace(cli *cli.Context, logger log.Logger) error {
|
|
config, err := newCQLClientConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
keyspace := cli.String(schema.CLIOptKeyspace)
|
|
if keyspace == "" {
|
|
err := fmt.Errorf("missing %s argument", flag(schema.CLIOptKeyspace))
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
err = doDropKeyspace(config, keyspace, logger)
|
|
if err != nil {
|
|
logger.Error("Unable to drop keyspace.", tag.Error(err))
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func validateHealth(cli *cli.Context, logger log.Logger) error {
|
|
config, err := newCQLClientConfig(cli)
|
|
if err != nil {
|
|
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
|
|
return err
|
|
}
|
|
|
|
config.Keyspace = systemKeyspace
|
|
|
|
client, err := newCQLClient(config, logger)
|
|
if err != nil {
|
|
logger.Error("Unable to establish CQL session.", tag.Error(err))
|
|
return err
|
|
}
|
|
|
|
defer client.Close()
|
|
return nil
|
|
}
|
|
|
|
func doCreateKeyspace(cfg *CQLClientConfig, name string, logger log.Logger) error {
|
|
cfg.Keyspace = systemKeyspace
|
|
client, err := newCQLClient(cfg, logger)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer client.Close()
|
|
return client.createKeyspace(name)
|
|
}
|
|
|
|
func doDropKeyspace(cfg *CQLClientConfig, name string, logger log.Logger) error {
|
|
cfg.Keyspace = systemKeyspace
|
|
client, err := newCQLClient(cfg, logger)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer client.Close()
|
|
return client.dropKeyspace(name)
|
|
}
|
|
|
|
func newCQLClientConfig(cli *cli.Context) (*CQLClientConfig, error) {
|
|
config := &CQLClientConfig{
|
|
Hosts: cli.GlobalString(schema.CLIOptEndpoint),
|
|
Port: cli.GlobalInt(schema.CLIOptPort),
|
|
User: cli.GlobalString(schema.CLIOptUser),
|
|
Password: cli.GlobalString(schema.CLIOptPassword),
|
|
Timeout: cli.GlobalInt(schema.CLIOptTimeout),
|
|
Keyspace: cli.GlobalString(schema.CLIOptKeyspace),
|
|
numReplicas: cli.Int(schema.CLIOptReplicationFactor),
|
|
Datacenter: cli.String(schema.CLIOptDatacenter),
|
|
Consistency: cli.String(schema.CLIOptConsistency),
|
|
DisableInitialHostLookup: cli.GlobalBool(schema.CLIFlagDisableInitialHostLookup),
|
|
}
|
|
|
|
if cli.GlobalBool(schema.CLIFlagEnableTLS) {
|
|
config.TLS = &auth.TLS{
|
|
Enabled: true,
|
|
CertFile: cli.GlobalString(schema.CLIFlagTLSCertFile),
|
|
KeyFile: cli.GlobalString(schema.CLIFlagTLSKeyFile),
|
|
CaFile: cli.GlobalString(schema.CLIFlagTLSCaFile),
|
|
ServerName: cli.GlobalString(schema.CLIFlagTLSHostName),
|
|
EnableHostVerification: !cli.GlobalBool(schema.CLIFlagTLSDisableHostVerification),
|
|
}
|
|
}
|
|
|
|
config.AddressTranslator = &c.CassandraAddressTranslator{
|
|
Translator: cli.GlobalString(schema.CLIOptAddressTranslator),
|
|
Options: parseOptionsMap(cli.GlobalString(schema.CLIOptAddressTranslatorOptions)),
|
|
}
|
|
|
|
if err := validateCQLClientConfig(config); err != nil {
|
|
return nil, err
|
|
}
|
|
return config, nil
|
|
}
|
|
|
|
func parseOptionsMap(value string) map[string]string {
|
|
if len(value) == 0 {
|
|
return make(map[string]string)
|
|
}
|
|
|
|
split := strings.Split(value, ",")
|
|
|
|
parsedMap := make(map[string]string)
|
|
|
|
for _, pair := range split {
|
|
trimmedPair := strings.ReplaceAll(pair, " ", "")
|
|
if len(trimmedPair) == 0 {
|
|
continue
|
|
}
|
|
splitPair := strings.Split(trimmedPair, "=")
|
|
if len(splitPair) != 2 {
|
|
continue
|
|
}
|
|
if len(splitPair[0]) == 0 || len(splitPair[1]) == 0 {
|
|
continue
|
|
}
|
|
parsedMap[splitPair[0]] = splitPair[1]
|
|
}
|
|
|
|
return parsedMap
|
|
}
|
|
|
|
func validateCQLClientConfig(config *CQLClientConfig) error {
|
|
if len(config.Hosts) == 0 {
|
|
return schema.NewConfigError("missing cassandra endpoint argument " + flag(schema.CLIOptEndpoint))
|
|
}
|
|
if config.Keyspace == "" {
|
|
return schema.NewConfigError("missing " + flag(schema.CLIOptKeyspace) + " argument ")
|
|
}
|
|
if config.Port == 0 {
|
|
config.Port = environment.GetCassandraPort()
|
|
}
|
|
if config.numReplicas == 0 {
|
|
config.numReplicas = defaultNumReplicas
|
|
}
|
|
|
|
if config.AddressTranslator != nil && len(config.AddressTranslator.Options) != 0 {
|
|
if len(config.AddressTranslator.Translator) == 0 {
|
|
return schema.NewConfigError("missing address translator argument " + flag(schema.CLIOptAddressTranslator))
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func flag(opt string) string {
|
|
return "(-" + opt + ")"
|
|
}
|