mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David ReissandGitHub
2e70c07199
## What changed? - Use an explicit Start for dynamicconfig.Collection (in addition to Stop) - Use fx hooks for Start/Stop - Make it clear that StaticClient should be static - Use thread-safe client in dynamic config unit tests ## Why? Fix thread-safety and cleanup ## How did you test it? existing tests
45 lines
1.7 KiB
Go
45 lines
1.7 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package dynamicconfig
|
|
|
|
import (
|
|
"go.uber.org/fx"
|
|
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/pingable"
|
|
)
|
|
|
|
var Module = fx.Options(
|
|
fx.Provide(func(client Client, logger log.Logger, lc fx.Lifecycle) *Collection {
|
|
col := NewCollection(client, logger)
|
|
lc.Append(fx.StartStopHook(col.Start, col.Stop))
|
|
return col
|
|
}),
|
|
fx.Provide(fx.Annotate(
|
|
func(c *Collection) pingable.Pingable { return c },
|
|
fx.ResultTags(`group:"deadlockDetectorRoots"`),
|
|
)),
|
|
)
|