mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
<!-- Describe what has changed in this PR --> **What changed?** I renamed all of our Go source code files so that they're snake case instead of camel case. <!-- Tell your future self why have you made these changes --> **Why?** This was an annoying inconsistency we carried over from much older code in the repo. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** The renaming process was part of an automated script (https://gist.github.com/MichaelSnowden/47576fffe27aa1cae6b26eaccec7ab55), so it should be consistent. Also, I don't see us doing anything in our codebase that involves parsing our own source files by path: <img width="687" alt="image" src="https://github.com/temporalio/temporal/assets/5942963/c6b873b0-d841-40d1-8b0f-2fe9d8079a53"> *PS: here's a link to the GPT convo I had to generate this renaming script: https://chat.openai.com/share/7f2d011a-a8da-4fa4-9c6d-e09102fdd49f* <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Mainly merge conflicts, but I used `git mv` so that these are renames instead of deletes/adds, so that shouldn't be a big issue. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
187 lines
5.4 KiB
Go
187 lines
5.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package namespace
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.temporal.io/api/serviceerror"
|
|
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common/cluster"
|
|
)
|
|
|
|
type (
|
|
attrValidatorSuite struct {
|
|
suite.Suite
|
|
|
|
controller *gomock.Controller
|
|
mockClusterMetadata *cluster.MockMetadata
|
|
|
|
validator *AttrValidatorImpl
|
|
}
|
|
)
|
|
|
|
func TestAttrValidatorSuite(t *testing.T) {
|
|
s := new(attrValidatorSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *attrValidatorSuite) SetupSuite() {
|
|
}
|
|
|
|
func (s *attrValidatorSuite) TearDownSuite() {
|
|
}
|
|
|
|
func (s *attrValidatorSuite) SetupTest() {
|
|
s.controller = gomock.NewController(s.T())
|
|
s.mockClusterMetadata = cluster.NewMockMetadata(s.controller)
|
|
|
|
s.validator = NewAttrValidator(s.mockClusterMetadata)
|
|
}
|
|
|
|
func (s *attrValidatorSuite) TearDownTest() {
|
|
s.controller.Finish()
|
|
}
|
|
|
|
func (s *attrValidatorSuite) TestClusterName() {
|
|
s.mockClusterMetadata.EXPECT().GetAllClusterInfo().Return(
|
|
cluster.TestAllClusterInfo,
|
|
).AnyTimes()
|
|
|
|
err := s.validator.validateClusterName("some random foo bar")
|
|
s.IsType(&serviceerror.InvalidArgument{}, err)
|
|
|
|
err = s.validator.validateClusterName(cluster.TestCurrentClusterName)
|
|
s.NoError(err)
|
|
|
|
err = s.validator.validateClusterName(cluster.TestAlternativeClusterName)
|
|
s.NoError(err)
|
|
}
|
|
|
|
func (s *attrValidatorSuite) TestValidateNamespaceReplicationConfigForLocalNamespace() {
|
|
s.mockClusterMetadata.EXPECT().GetCurrentClusterName().Return(
|
|
cluster.TestCurrentClusterName,
|
|
).AnyTimes()
|
|
s.mockClusterMetadata.EXPECT().GetAllClusterInfo().Return(
|
|
cluster.TestAllClusterInfo,
|
|
).AnyTimes()
|
|
|
|
err := s.validator.ValidateNamespaceReplicationConfigForLocalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestAlternativeClusterName,
|
|
Clusters: []string{
|
|
cluster.TestAlternativeClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.IsType(&serviceerror.InvalidArgument{}, err)
|
|
|
|
err = s.validator.ValidateNamespaceReplicationConfigForLocalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestAlternativeClusterName,
|
|
Clusters: []string{
|
|
cluster.TestCurrentClusterName,
|
|
cluster.TestAlternativeClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.IsType(&serviceerror.InvalidArgument{}, err)
|
|
|
|
err = s.validator.ValidateNamespaceReplicationConfigForLocalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestCurrentClusterName,
|
|
Clusters: []string{
|
|
cluster.TestCurrentClusterName,
|
|
cluster.TestAlternativeClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.IsType(&serviceerror.InvalidArgument{}, err)
|
|
|
|
err = s.validator.ValidateNamespaceReplicationConfigForLocalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestCurrentClusterName,
|
|
Clusters: []string{
|
|
cluster.TestCurrentClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.NoError(err)
|
|
}
|
|
|
|
func (s *attrValidatorSuite) TestValidateNamespaceReplicationConfigForGlobalNamespace() {
|
|
s.mockClusterMetadata.EXPECT().GetCurrentClusterName().Return(
|
|
cluster.TestCurrentClusterName,
|
|
).AnyTimes()
|
|
s.mockClusterMetadata.EXPECT().GetAllClusterInfo().Return(
|
|
cluster.TestAllClusterInfo,
|
|
).AnyTimes()
|
|
|
|
err := s.validator.ValidateNamespaceReplicationConfigForGlobalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestCurrentClusterName,
|
|
Clusters: []string{
|
|
cluster.TestCurrentClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.NoError(err)
|
|
|
|
err = s.validator.ValidateNamespaceReplicationConfigForGlobalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestAlternativeClusterName,
|
|
Clusters: []string{
|
|
cluster.TestAlternativeClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.NoError(err)
|
|
|
|
err = s.validator.ValidateNamespaceReplicationConfigForGlobalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestAlternativeClusterName,
|
|
Clusters: []string{
|
|
cluster.TestCurrentClusterName,
|
|
cluster.TestAlternativeClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.NoError(err)
|
|
|
|
err = s.validator.ValidateNamespaceReplicationConfigForGlobalNamespace(
|
|
&persistencespb.NamespaceReplicationConfig{
|
|
ActiveClusterName: cluster.TestCurrentClusterName,
|
|
Clusters: []string{
|
|
cluster.TestCurrentClusterName,
|
|
cluster.TestAlternativeClusterName,
|
|
},
|
|
},
|
|
)
|
|
s.NoError(err)
|
|
}
|