mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
## What changed? Added a DLQMEtricsEmitter which will emit DLQ message count every 3 hours. ## Why? We alredy have a counter metric for DLQ writes. This will increment each time a new message is written to DLQ. This can be used to create an alarm that fires when a message is added to DLQ. But we also need to know if DLQ messages are inspected and cleared on time. This is not possible with the existing metric. This new metric DLQMessageCount will help in monitoring the current number of messages in DLQ. This metric will only be emitted from the history service instance which hosts shard numbered 1. I also considered adding a gauge metric for DLQ message count. If the history service restarts, we will lose this count. ## How did you test it? Unit test ## Potential risks None ## Documentation ## Is hotfix candidate? --------- Co-authored-by: Yichao Yang <[email protected]>
128 lines
5.4 KiB
Go
128 lines
5.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package persistence
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/stretchr/testify/assert"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/membership"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/metrics/metricstest"
|
|
"go.temporal.io/server/service/history/tasks"
|
|
)
|
|
|
|
func TestDLQMetricsEmitter_EmitMetrics_WhenInstanceHostsShardOne(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
defer ctrl.Finish()
|
|
|
|
metricsHandler := metricstest.NewCaptureHandler()
|
|
logger := log.NewMockLogger(ctrl)
|
|
manager := NewMockHistoryTaskQueueManager(ctrl)
|
|
manager.EXPECT().ListQueues(gomock.Any(), &ListQueuesRequest{
|
|
QueueType: QueueTypeHistoryDLQ,
|
|
PageSize: 100,
|
|
NextPageToken: nil,
|
|
}).Return(&ListQueuesResponse{
|
|
Queues: []QueueInfo{
|
|
{QueueName: GetHistoryTaskQueueName(tasks.CategoryIDTransfer, "source", "target"), MessageCount: 1},
|
|
{QueueName: GetHistoryTaskQueueName(tasks.CategoryIDTimer, "source", "target"), MessageCount: 2},
|
|
{QueueName: GetHistoryTaskQueueName(tasks.CategoryIDReplication, "source", "target"), MessageCount: 3},
|
|
},
|
|
NextPageToken: []byte("test_page_token"),
|
|
}, nil).Times(1)
|
|
manager.EXPECT().ListQueues(gomock.Any(), &ListQueuesRequest{
|
|
QueueType: QueueTypeHistoryDLQ,
|
|
PageSize: 100,
|
|
NextPageToken: []byte("test_page_token"),
|
|
}).Return(&ListQueuesResponse{
|
|
Queues: []QueueInfo{
|
|
{QueueName: GetHistoryTaskQueueName(tasks.CategoryIDTransfer, "source", "target"), MessageCount: 8},
|
|
{QueueName: GetHistoryTaskQueueName(tasks.CategoryIDTimer, "source", "target"), MessageCount: 9},
|
|
{QueueName: GetHistoryTaskQueueName(tasks.CategoryIDReplication, "source", "target"), MessageCount: 10},
|
|
},
|
|
NextPageToken: nil,
|
|
}, nil).Times(1)
|
|
resolver := membership.NewMockServiceResolver(ctrl)
|
|
resolver.EXPECT().Lookup("1").Return(membership.NewHostInfoFromAddress("testAddress"), nil).Times(1)
|
|
hostInfoProvider := membership.NewMockHostInfoProvider(ctrl)
|
|
hostInfoProvider.EXPECT().HostInfo().Return(membership.NewHostInfoFromAddress("testAddress")).Times(1)
|
|
categoryRegistry := tasks.NewDefaultTaskCategoryRegistry()
|
|
emitter := NewDLQMetricsEmitter(metricsHandler, logger, manager, resolver, hostInfoProvider, categoryRegistry)
|
|
emitter.emitMetricsTimer = time.NewTicker(60 * time.Millisecond)
|
|
logger.EXPECT().Info(gomock.Any()).AnyTimes()
|
|
logger.EXPECT().Error(gomock.Any()).AnyTimes()
|
|
|
|
capture := metricsHandler.StartCapture()
|
|
snapshot := capture.Snapshot()
|
|
emitter.Start()
|
|
assert.Eventually(t, func() bool {
|
|
snapshot = capture.Snapshot()
|
|
return len(snapshot[metrics.DLQMessageCount.Name()]) == len(categoryRegistry.GetCategories())
|
|
}, 5*time.Second, 100*time.Millisecond)
|
|
|
|
emitter.Stop()
|
|
<-emitter.shutdownCh
|
|
|
|
messageCount := make(map[string]float64)
|
|
for _, recording := range snapshot[metrics.DLQMessageCount.Name()] {
|
|
value, ok := recording.Value.(float64)
|
|
assert.True(t, ok)
|
|
messageCount[recording.Tags[metrics.TaskCategoryTagName]] = value
|
|
}
|
|
assert.Equal(t, float64(9), messageCount["transfer"])
|
|
assert.Equal(t, float64(11), messageCount["timer"])
|
|
assert.Equal(t, float64(13), messageCount["replication"])
|
|
}
|
|
|
|
func TestDLQMetricsEmitter_DoesNotEmitMetrics_WhenInstanceDoesNotHostShardOne(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
defer ctrl.Finish()
|
|
|
|
metricsHandler := metricstest.NewCaptureHandler()
|
|
capture := metricsHandler.StartCapture()
|
|
logger := log.NewMockLogger(ctrl)
|
|
manager := NewMockHistoryTaskQueueManager(ctrl)
|
|
|
|
resolver := membership.NewMockServiceResolver(ctrl)
|
|
resolver.EXPECT().Lookup("1").Return(membership.NewHostInfoFromAddress("testAddress1"), nil).MinTimes(1)
|
|
hostInfoProvider := membership.NewMockHostInfoProvider(ctrl)
|
|
hostInfoProvider.EXPECT().HostInfo().Return(membership.NewHostInfoFromAddress("testAddress2")).MinTimes(1)
|
|
|
|
emitter := NewDLQMetricsEmitter(metricsHandler, logger, manager, resolver, hostInfoProvider, tasks.NewDefaultTaskCategoryRegistry())
|
|
emitter.emitMetricsTimer = time.NewTicker(time.Millisecond)
|
|
logger.EXPECT().Info(gomock.Any()).AnyTimes()
|
|
logger.EXPECT().Error(gomock.Any()).AnyTimes()
|
|
|
|
emitter.Start()
|
|
time.Sleep(100 * time.Millisecond) //nolint
|
|
emitter.Stop()
|
|
<-emitter.shutdownCh
|
|
|
|
snapshot := capture.Snapshot()
|
|
assert.Empty(t, snapshot[metrics.DLQMessageCount.Name()])
|
|
}
|