Files
Alex ShtinandGitHub 0ee9e7e4cf Refactor fault injection package (#5886)
## What changed?
<!-- Describe what has changed in this PR -->
It turned out to be more involved than I initially anticipated.
1. All persistence fault injection related code is moved to
`faultinjection` package under `common/persistence`. I split it to a few
files with better names and clear responsibilities. Unexported almost
all identifiers in the package.
2. Fault injection config used to have two modes:
    * flat rate for all APIs
* configurable rate for specific API of specific store with specific
errors.

It turned out that flat rate is not practical because tests becomes
unpredictable (can fail during init phase) and we actually don't use it.
I removed this option and it simplified fault injection code a lot.

## Why?
<!-- Tell your future self why have you made these changes -->
Refactoring, simplicity.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Existing tests + added few more tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2024-05-10 17:47:36 -07:00

127 lines
4.1 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package faultinjection
import (
"context"
"fmt"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/persistence"
)
type (
fault struct {
err error
// execOp indicates whether the operation should be executed before returning the error.
execOp bool
// How often this fault should be injected. 0.0 means never, 1.0 means always.
rate float64
}
)
func newFaultFromError(err error, rate float64) fault {
return fault{
err: err,
rate: rate,
}
}
// newFault returns an error based on the provided name. If the name is not recognized, then this method will
// panic.
func newFault(errName string, errRate float64, methodName string) fault {
header := fmt.Sprintf("fault injection error at %s with %.2f rate", methodName, errRate)
switch errName {
case "ShardOwnershipLost":
return newFaultFromError(&persistence.ShardOwnershipLostError{Msg: fmt.Sprintf("%s: persistence.ShardOwnershipLostError", header)}, errRate)
case "DeadlineExceeded":
// Real persistence store never returns context.DeadlineExceeded error. It returns persistence.TimeoutError instead.
// Therefor "DeadlineExceeded" shouldn't be used with fault injection. Use "Timeout" instead.
return newFaultFromError(fmt.Errorf("%s: %w", header, context.DeadlineExceeded), errRate)
case "Timeout":
return newFaultFromError(&persistence.TimeoutError{Msg: fmt.Sprintf("%s: persistence.TimeoutError", header)}, errRate)
case "ExecuteAndTimeout":
// Special error which emulates case, when caller got a Timeout error,
// but operation actually reached persistence and was executed successfully.
f := newFaultFromError(&persistence.TimeoutError{Msg: fmt.Sprintf("%s: persistence.TimeoutError", header)}, errRate)
f.execOp = true
return f
case "ResourceExhausted":
return newFaultFromError(&serviceerror.ResourceExhausted{
Cause: enumspb.RESOURCE_EXHAUSTED_CAUSE_SYSTEM_OVERLOADED,
Scope: enumspb.RESOURCE_EXHAUSTED_SCOPE_SYSTEM,
Message: fmt.Sprintf("%s: serviceerror.ResourceExhausted", header),
}, errRate)
case "Unavailable":
return newFaultFromError(serviceerror.NewUnavailable(fmt.Sprintf("%s: serviceerror.Unavailable", header)), errRate)
default:
panic(fmt.Sprintf("unsupported error type: %v", errName))
}
}
// Not receiver on a *fault because of generics.
func inject0(f *fault, op func() error) error {
if f == nil {
return op()
}
if f.execOp {
err := op()
if err != nil {
return err
}
}
return f.err
}
func inject1[T1 any](f *fault, op func() (T1, error)) (T1, error) {
if f == nil {
return op()
}
if f.execOp {
r1, err := op()
if err != nil {
return r1, err
}
}
var nilT1 T1
return nilT1, f.err
}
func inject2[T1 any, T2 any](f *fault, op func() (T1, T2, error)) (T1, T2, error) {
if f == nil {
return op()
}
if f.execOp {
r1, r2, err := op()
if err != nil {
return r1, r2, err
}
}
var nilT1 T1
var nilT2 T2
return nilT1, nilT2, f.err
}