mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Michael SnowdenandGitHub
d5c62e926f
<!-- Describe what has changed in this PR --> **What changed?** I renamed all of our Go source code files so that they're snake case instead of camel case. <!-- Tell your future self why have you made these changes --> **Why?** This was an annoying inconsistency we carried over from much older code in the repo. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** The renaming process was part of an automated script (https://gist.github.com/MichaelSnowden/47576fffe27aa1cae6b26eaccec7ab55), so it should be consistent. Also, I don't see us doing anything in our codebase that involves parsing our own source files by path: <img width="687" alt="image" src="https://github.com/temporalio/temporal/assets/5942963/c6b873b0-d841-40d1-8b0f-2fe9d8079a53"> *PS: here's a link to the GPT convo I had to generate this renaming script: https://chat.openai.com/share/7f2d011a-a8da-4fa4-9c6d-e09102fdd49f* <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Mainly merge conflicts, but I used `git mv` so that these are renames instead of deletes/adds, so that shouldn't be a big issue. <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
421 lines
14 KiB
Go
421 lines
14 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package persistence
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
enumsspb "go.temporal.io/server/api/enums/v1"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
)
|
|
|
|
type (
|
|
validateOperationWorkflowModeStateSuite struct {
|
|
suite.Suite
|
|
}
|
|
)
|
|
|
|
func TestValidateOperationWorkflowModeStateSuite(t *testing.T) {
|
|
s := new(validateOperationWorkflowModeStateSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) SetupSuite() {
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TearDownSuite() {
|
|
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) SetupTest() {
|
|
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TearDownTest() {
|
|
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TestCreateMode_UpdateCurrent() {
|
|
|
|
stateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
|
|
creatModes := []CreateWorkflowMode{
|
|
CreateWorkflowModeBrandNew,
|
|
CreateWorkflowModeUpdateCurrent,
|
|
}
|
|
|
|
for state, expectError := range stateToError {
|
|
testSnapshot := s.newTestWorkflowSnapshot(state)
|
|
for _, createMode := range creatModes {
|
|
err := ValidateCreateWorkflowModeState(createMode, testSnapshot)
|
|
if !expectError {
|
|
s.NoError(err, err)
|
|
} else {
|
|
s.Error(err, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TestCreateMode_BypassCurrent() {
|
|
|
|
stateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
|
|
for state, expectError := range stateToError {
|
|
testSnapshot := s.newTestWorkflowSnapshot(state)
|
|
err := ValidateCreateWorkflowModeState(CreateWorkflowModeBypassCurrent, testSnapshot)
|
|
if !expectError {
|
|
s.NoError(err, err)
|
|
} else {
|
|
s.Error(err, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TestUpdateMode_UpdateCurrent() {
|
|
|
|
// only current workflow
|
|
stateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
for state, expectError := range stateToError {
|
|
testCurrentMutation := s.newTestWorkflowMutation(state)
|
|
err := ValidateUpdateWorkflowModeState(
|
|
UpdateWorkflowModeUpdateCurrent,
|
|
testCurrentMutation,
|
|
nil,
|
|
)
|
|
if !expectError {
|
|
s.NoError(err, err)
|
|
} else {
|
|
s.Error(err, err)
|
|
}
|
|
}
|
|
|
|
// current workflow & new workflow
|
|
currentStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
newStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
for currentState, currentExpectError := range currentStateToError {
|
|
for newState, newExpectError := range newStateToError {
|
|
testCurrentMutation := s.newTestWorkflowMutation(currentState)
|
|
testNewSnapshot := s.newTestWorkflowSnapshot(newState)
|
|
err := ValidateUpdateWorkflowModeState(
|
|
UpdateWorkflowModeUpdateCurrent,
|
|
testCurrentMutation,
|
|
&testNewSnapshot,
|
|
)
|
|
if currentExpectError || newExpectError {
|
|
s.Error(err, err)
|
|
} else {
|
|
s.NoError(err, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TestUpdateMode_BypassCurrent() {
|
|
|
|
// only current workflow
|
|
stateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
for state, expectError := range stateToError {
|
|
testMutation := s.newTestWorkflowMutation(state)
|
|
err := ValidateUpdateWorkflowModeState(
|
|
UpdateWorkflowModeBypassCurrent,
|
|
testMutation,
|
|
nil,
|
|
)
|
|
if !expectError {
|
|
s.NoError(err, err)
|
|
} else {
|
|
s.Error(err, err)
|
|
}
|
|
}
|
|
|
|
// current workflow & new workflow
|
|
currentStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
newStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
for currentState, currentExpectError := range currentStateToError {
|
|
for newState, newExpectError := range newStateToError {
|
|
testCurrentMutation := s.newTestWorkflowMutation(currentState)
|
|
testNewSnapshot := s.newTestWorkflowSnapshot(newState)
|
|
err := ValidateUpdateWorkflowModeState(
|
|
UpdateWorkflowModeBypassCurrent,
|
|
testCurrentMutation,
|
|
&testNewSnapshot,
|
|
)
|
|
if currentExpectError || newExpectError {
|
|
s.Error(err, err)
|
|
} else {
|
|
s.NoError(err, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TestConflictResolveMode_UpdateCurrent() {
|
|
|
|
// only reset workflow
|
|
stateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
for state, expectError := range stateToError {
|
|
testSnapshot := s.newTestWorkflowSnapshot(state)
|
|
err := ValidateConflictResolveWorkflowModeState(
|
|
ConflictResolveWorkflowModeUpdateCurrent,
|
|
testSnapshot,
|
|
nil,
|
|
nil,
|
|
)
|
|
if !expectError {
|
|
s.NoError(err, err)
|
|
} else {
|
|
s.Error(err, err)
|
|
}
|
|
}
|
|
|
|
// reset workflow & new workflow
|
|
resetStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
newStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
for resetState, resetExpectError := range resetStateToError {
|
|
for newState, newExpectError := range newStateToError {
|
|
testResetSnapshot := s.newTestWorkflowSnapshot(resetState)
|
|
testNewSnapshot := s.newTestWorkflowSnapshot(newState)
|
|
err := ValidateConflictResolveWorkflowModeState(
|
|
ConflictResolveWorkflowModeUpdateCurrent,
|
|
testResetSnapshot,
|
|
&testNewSnapshot,
|
|
nil,
|
|
)
|
|
if resetExpectError || newExpectError {
|
|
s.Error(err, err)
|
|
} else {
|
|
s.NoError(err, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// reset workflow & current workflow
|
|
resetStateToError = map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
currentStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
for resetState, resetExpectError := range resetStateToError {
|
|
for currentState, currentExpectError := range currentStateToError {
|
|
testResetSnapshot := s.newTestWorkflowSnapshot(resetState)
|
|
testCurrentSnapshot := s.newTestWorkflowMutation(currentState)
|
|
err := ValidateConflictResolveWorkflowModeState(
|
|
ConflictResolveWorkflowModeUpdateCurrent,
|
|
testResetSnapshot,
|
|
nil,
|
|
&testCurrentSnapshot,
|
|
)
|
|
if resetExpectError || currentExpectError {
|
|
s.Error(err, err)
|
|
} else {
|
|
s.NoError(err, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// reset workflow & new workflow & current workflow
|
|
resetStateToError = map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
newStateToError = map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
currentStateToError = map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
for resetState, resetExpectError := range resetStateToError {
|
|
for newState, newExpectError := range newStateToError {
|
|
for currentState, currentExpectError := range currentStateToError {
|
|
testResetSnapshot := s.newTestWorkflowSnapshot(resetState)
|
|
testNewSnapshot := s.newTestWorkflowSnapshot(newState)
|
|
testCurrentSnapshot := s.newTestWorkflowMutation(currentState)
|
|
err := ValidateConflictResolveWorkflowModeState(
|
|
ConflictResolveWorkflowModeUpdateCurrent,
|
|
testResetSnapshot,
|
|
&testNewSnapshot,
|
|
&testCurrentSnapshot,
|
|
)
|
|
if resetExpectError || newExpectError || currentExpectError {
|
|
s.Error(err, err)
|
|
} else {
|
|
s.NoError(err, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) TestConflictResolveMode_BypassCurrent() {
|
|
|
|
// only reset workflow
|
|
stateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
for state, expectError := range stateToError {
|
|
testSnapshot := s.newTestWorkflowSnapshot(state)
|
|
err := ValidateConflictResolveWorkflowModeState(
|
|
ConflictResolveWorkflowModeBypassCurrent,
|
|
testSnapshot,
|
|
nil,
|
|
nil,
|
|
)
|
|
if !expectError {
|
|
s.NoError(err, err)
|
|
} else {
|
|
s.Error(err, err)
|
|
}
|
|
}
|
|
|
|
// reset workflow & new workflow
|
|
resetStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: true,
|
|
}
|
|
newStateToError := map[enumsspb.WorkflowExecutionState]bool{
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: true,
|
|
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: false,
|
|
}
|
|
for resetState, resetExpectError := range resetStateToError {
|
|
for newState, newExpectError := range newStateToError {
|
|
testResetSnapshot := s.newTestWorkflowSnapshot(resetState)
|
|
testNewSnapshot := s.newTestWorkflowSnapshot(newState)
|
|
err := ValidateConflictResolveWorkflowModeState(
|
|
ConflictResolveWorkflowModeBypassCurrent,
|
|
testResetSnapshot,
|
|
&testNewSnapshot,
|
|
nil,
|
|
)
|
|
if resetExpectError || newExpectError {
|
|
if err == nil {
|
|
fmt.Print("##")
|
|
}
|
|
s.Error(err, err)
|
|
} else {
|
|
s.NoError(err, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) newTestWorkflowSnapshot(
|
|
state enumsspb.WorkflowExecutionState,
|
|
) WorkflowSnapshot {
|
|
return WorkflowSnapshot{
|
|
ExecutionInfo: &persistencespb.WorkflowExecutionInfo{},
|
|
ExecutionState: &persistencespb.WorkflowExecutionState{State: state},
|
|
}
|
|
}
|
|
|
|
func (s *validateOperationWorkflowModeStateSuite) newTestWorkflowMutation(
|
|
state enumsspb.WorkflowExecutionState,
|
|
) WorkflowMutation {
|
|
return WorkflowMutation{
|
|
ExecutionInfo: &persistencespb.WorkflowExecutionInfo{},
|
|
ExecutionState: &persistencespb.WorkflowExecutionState{State: state},
|
|
}
|
|
}
|