Files
tasks/common/persistence/versionhistory/version_histories.go
Yu XiaandGitHub e260aa409f Convert version history bad request to internal error (#4690)
<!-- Describe what has changed in this PR -->
**What changed?**
Convert version history bad request to internal error

<!-- Tell your future self why have you made these changes -->
**Why?**
Bad request error will surface to users. This is the internal logic and
if something is wrong, it should be internal error.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
unit tests

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
2023-07-27 09:28:26 -07:00

192 lines
6.9 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package versionhistory
import (
"go.temporal.io/api/serviceerror"
historyspb "go.temporal.io/server/api/history/v1"
)
// NewVersionHistories create a new instance of VersionHistories.
func NewVersionHistories(versionHistory *historyspb.VersionHistory) *historyspb.VersionHistories {
if versionHistory == nil {
panic("version history cannot be null")
}
return &historyspb.VersionHistories{
CurrentVersionHistoryIndex: 0,
Histories: []*historyspb.VersionHistory{versionHistory},
}
}
// Copy VersionHistories.
func CopyVersionHistories(h *historyspb.VersionHistories) *historyspb.VersionHistories {
var histories []*historyspb.VersionHistory
for _, history := range h.Histories {
histories = append(histories, CopyVersionHistory(history))
}
return &historyspb.VersionHistories{
CurrentVersionHistoryIndex: h.CurrentVersionHistoryIndex,
Histories: histories,
}
}
// GetVersionHistory gets the VersionHistory according to index provided.
func GetVersionHistory(h *historyspb.VersionHistories, index int32) (*historyspb.VersionHistory, error) {
if index < 0 || index >= int32(len(h.Histories)) {
return nil, serviceerror.NewInternal("version histories index is out of range.")
}
return h.Histories[index], nil
}
// AddVersionHistory adds a VersionHistory and return the whether current branch is changed.
func AddVersionHistory(h *historyspb.VersionHistories, v *historyspb.VersionHistory) (bool, int32, error) {
if v == nil {
return false, 0, serviceerror.NewInternal("version histories is null.")
}
// assuming existing version histories inside are valid
incomingFirstItem, err := GetFirstVersionHistoryItem(v)
if err != nil {
return false, 0, err
}
currentVersionHistory, err := GetVersionHistory(h, h.CurrentVersionHistoryIndex)
if err != nil {
return false, 0, err
}
currentFirstItem, err := GetFirstVersionHistoryItem(currentVersionHistory)
if err != nil {
return false, 0, err
}
if incomingFirstItem.Version != currentFirstItem.Version {
return false, 0, serviceerror.NewInternal("version history first item does not match.")
}
// TODO maybe we need more strict validation
newVersionHistory := CopyVersionHistory(v)
h.Histories = append(h.Histories, newVersionHistory)
newVersionHistoryIndex := int32(len(h.Histories)) - 1
// check if need to switch current branch
newLastItem, err := GetLastVersionHistoryItem(newVersionHistory)
if err != nil {
return false, 0, err
}
currentLastItem, err := GetLastVersionHistoryItem(currentVersionHistory)
if err != nil {
return false, 0, err
}
currentBranchChanged := false
if newLastItem.Version > currentLastItem.Version {
currentBranchChanged = true
h.CurrentVersionHistoryIndex = newVersionHistoryIndex
}
return currentBranchChanged, newVersionHistoryIndex, nil
}
// FindLCAVersionHistoryItemAndIndex finds the lowest common ancestor VersionHistory index and corresponding item.
func FindLCAVersionHistoryItemAndIndex(h *historyspb.VersionHistories, incomingHistory *historyspb.VersionHistory) (*historyspb.VersionHistoryItem, int32, error) {
var versionHistoryIndex int32
var versionHistoryLength int32
var versionHistoryItem *historyspb.VersionHistoryItem
for index, localHistory := range h.Histories {
item, err := FindLCAVersionHistoryItem(localHistory, incomingHistory)
if err != nil {
return nil, 0, err
}
// if not set
if versionHistoryItem == nil ||
// if seeing LCA item with higher event ID
item.GetEventId() > versionHistoryItem.GetEventId() ||
// if seeing LCA item with equal event ID but shorter history
(item.GetEventId() == versionHistoryItem.GetEventId() && int32(len(localHistory.Items)) < versionHistoryLength) {
versionHistoryIndex = int32(index)
versionHistoryLength = int32(len(localHistory.Items))
versionHistoryItem = item
}
}
return CopyVersionHistoryItem(versionHistoryItem), versionHistoryIndex, nil
}
// FindFirstVersionHistoryIndexByVersionHistoryItem find the first VersionHistory index which contains the given version history item.
func FindFirstVersionHistoryIndexByVersionHistoryItem(h *historyspb.VersionHistories, item *historyspb.VersionHistoryItem) (int32, error) {
for versionHistoryIndex, history := range h.Histories {
if ContainsVersionHistoryItem(history, item) {
return int32(versionHistoryIndex), nil
}
}
return 0, serviceerror.NewInternal("version histories does not contains given item.")
}
// IsVersionHistoriesRebuilt returns true if the current branch index's last write version is not the largest among all branches' last write version.
func IsVersionHistoriesRebuilt(h *historyspb.VersionHistories) (bool, error) {
currentVersionHistory, err := GetCurrentVersionHistory(h)
if err != nil {
return false, err
}
currentLastItem, err := GetLastVersionHistoryItem(currentVersionHistory)
if err != nil {
return false, err
}
for _, versionHistory := range h.Histories {
lastItem, err := GetLastVersionHistoryItem(versionHistory)
if err != nil {
return false, err
}
if lastItem.GetVersion() > currentLastItem.GetVersion() {
return true, nil
}
}
return false, nil
}
// SetCurrentVersionHistoryIndex set the current VersionHistory index.
func SetCurrentVersionHistoryIndex(h *historyspb.VersionHistories, currentVersionHistoryIndex int32) error {
if currentVersionHistoryIndex < 0 || currentVersionHistoryIndex >= int32(len(h.Histories)) {
return serviceerror.NewInternal("invalid current version history index.")
}
h.CurrentVersionHistoryIndex = currentVersionHistoryIndex
return nil
}
// GetCurrentVersionHistory gets the current VersionHistory.
func GetCurrentVersionHistory(h *historyspb.VersionHistories) (*historyspb.VersionHistory, error) {
return GetVersionHistory(h, h.GetCurrentVersionHistoryIndex())
}