Files
tasks/common/persistence/visibility/store/visibility_store.go
Hazel KimandGitHub 5cf3b8fb23 Deprecate ListOpen/ClosedWorkflowExecutions (#5920)
## What changed?
<!-- Describe what has changed in this PR -->
- deprecated ListOpen/ClosedWorkflowExecutions in visibility store and
in visibility manager

## Why?
<!-- Tell your future self why have you made these changes -->
- use general ListWorkflowExecutions with query in stead

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- modified
[common/persistence/tests/visibility_persistence_suite.go](https://github.com/temporalio/temporal/compare/main...hazel/deprecate-open-close-wf-exec#diff-47a40c6c44b463ab240c9904a44e129548ceb90d83561ead69d51b3d7af30639)
to use ListWorkflowExecutions
- tested locally: ran TestAdvancedVisibilitySuite,
ESVisibilitySuite, FunctionalSuite/TestVisibility,
VisibilityPersistenceSuite

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-05-15 14:34:47 -04:00

141 lines
5.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package store
// -aux_files is required here due to Closeable interface being in another file.
//go:generate mockgen -copyright_file ../../../../LICENSE -package $GOPACKAGE -source $GOFILE -destination visibility_store_mock.go -aux_files go.temporal.io/server/common/persistence=../../data_interfaces.go
import (
"context"
"time"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/visibility/manager"
)
type (
// VisibilityStore is the store interface for visibility
VisibilityStore interface {
persistence.Closeable
GetName() string
GetIndexName() string
// Validate search attributes based on the store constraints. It returns a new map containing
// only search attributes with valid values. If there are invalid values, an error of type
// VisibilityStoreInvalidValuesError wraps all invalid values errors.
ValidateCustomSearchAttributes(searchAttributes map[string]any) (map[string]any, error)
// Write APIs.
RecordWorkflowExecutionStarted(ctx context.Context, request *InternalRecordWorkflowExecutionStartedRequest) error
RecordWorkflowExecutionClosed(ctx context.Context, request *InternalRecordWorkflowExecutionClosedRequest) error
UpsertWorkflowExecution(ctx context.Context, request *InternalUpsertWorkflowExecutionRequest) error
DeleteWorkflowExecution(ctx context.Context, request *manager.VisibilityDeleteWorkflowExecutionRequest) error
// Read APIs.
ListWorkflowExecutions(ctx context.Context, request *manager.ListWorkflowExecutionsRequestV2) (*InternalListWorkflowExecutionsResponse, error)
ScanWorkflowExecutions(ctx context.Context, request *manager.ListWorkflowExecutionsRequestV2) (*InternalListWorkflowExecutionsResponse, error)
CountWorkflowExecutions(ctx context.Context, request *manager.CountWorkflowExecutionsRequest) (*manager.CountWorkflowExecutionsResponse, error)
GetWorkflowExecution(ctx context.Context, request *manager.GetWorkflowExecutionRequest) (*InternalGetWorkflowExecutionResponse, error)
}
// InternalWorkflowExecutionInfo is visibility info for internal response
InternalWorkflowExecutionInfo struct {
WorkflowID string
RunID string
TypeName string
StartTime time.Time
ExecutionTime time.Time
CloseTime time.Time
ExecutionDuration time.Duration
Status enumspb.WorkflowExecutionStatus
HistoryLength int64
HistorySizeBytes int64
StateTransitionCount int64
Memo *commonpb.DataBlob
TaskQueue string
SearchAttributes *commonpb.SearchAttributes
ParentWorkflowID string
ParentRunID string
RootWorkflowID string
RootRunID string
}
// InternalListWorkflowExecutionsResponse is response from ListWorkflowExecutions
InternalListWorkflowExecutionsResponse struct {
Executions []*InternalWorkflowExecutionInfo
// Token to read next page if there are more workflow executions beyond page size.
// Use this to set NextPageToken on ListWorkflowExecutionsRequest to read the next page.
NextPageToken []byte
}
// InternalGetWorkflowExecutionResponse is response from GetWorkflowExecution
InternalGetWorkflowExecutionResponse struct {
Execution *InternalWorkflowExecutionInfo
}
// InternalVisibilityRequestBase is a base request to visibility APIs.
InternalVisibilityRequestBase struct {
NamespaceID string
WorkflowID string
RunID string
WorkflowTypeName string
StartTime time.Time
Status enumspb.WorkflowExecutionStatus
ExecutionTime time.Time
TaskID int64
ShardID int32
Memo *commonpb.DataBlob
TaskQueue string
SearchAttributes *commonpb.SearchAttributes
ParentWorkflowID *string
ParentRunID *string
RootWorkflowID string
RootRunID string
}
// InternalRecordWorkflowExecutionStartedRequest request to RecordWorkflowExecutionStarted
InternalRecordWorkflowExecutionStartedRequest struct {
*InternalVisibilityRequestBase
}
// InternalRecordWorkflowExecutionClosedRequest is request to RecordWorkflowExecutionClosed
InternalRecordWorkflowExecutionClosedRequest struct {
*InternalVisibilityRequestBase
CloseTime time.Time
HistoryLength int64
HistorySizeBytes int64
ExecutionDuration time.Duration
StateTransitionCount int64
}
// InternalUpsertWorkflowExecutionRequest is request to UpsertWorkflowExecution
InternalUpsertWorkflowExecutionRequest struct {
*InternalVisibilityRequestBase
}
)