Files
Roey BermanandGitHub 8a400ec9cf Fix local frontend HTTP client creation (#6198)
## What changed?

Fixed the mechanism to get a local frontend HTTP client to use a similar
approach to getting a gRPC client.
Now we'll use a dedicated user provided config or default to membership
lookup.

## How did you test it?

Added unit tests and ran existing functional tests.
2024-06-27 02:37:54 +00:00

103 lines
3.6 KiB
Go

// The MIT License
//
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package callbacks
import (
"fmt"
"net/http"
"go.uber.org/fx"
"go.temporal.io/server/common"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/collection"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/service/history/queues"
)
// Header key used to identify callbacks that originate from and target the same cluster.
const callbackSourceHeader = "source"
var Module = fx.Module(
"component.callbacks",
fx.Provide(ConfigProvider),
fx.Provide(HTTPCallerProviderProvider),
fx.Invoke(RegisterTaskSerializers),
fx.Invoke(RegisterStateMachine),
fx.Invoke(RegisterExecutor),
)
func HTTPCallerProviderProvider(
clusterMetadata cluster.Metadata,
rpcFactory common.RPCFactory,
httpClientCache *cluster.FrontendHTTPClientCache,
logger log.Logger,
) (HTTPCallerProvider, error) {
localClient, err := rpcFactory.CreateLocalFrontendHTTPClient()
if err != nil {
return nil, fmt.Errorf("cannot create local frontend HTTP client: %w", err)
}
m := collection.NewOnceMap(func(queues.NamespaceIDAndDestination) HTTPCaller {
// Create this once and reuse for all outgoing requests.
// Note that this may not ever be used but it cheap enough to create and is better to avoid the complexities of
// lazily creating it.
client := &http.Client{}
return func(r *http.Request) (*http.Response, error) {
if r.Header == nil || r.Header.Get(callbackSourceHeader) == "" {
return client.Do(r)
}
callbackSource := r.Header.Get(callbackSourceHeader)
for clusterName, clusterInfo := range clusterMetadata.GetAllClusterInfo() {
if callbackSource == clusterInfo.ClusterID {
var frontendClient *common.FrontendHTTPClient
if clusterMetadata.GetCurrentClusterName() == clusterName {
frontendClient = localClient
} else {
frontendClient, err = httpClientCache.Get(clusterName)
if err != nil {
logger.Warn(
"HTTPCallerProviderProvider unable to get FrontendHTTPClient for callback target cluster. Using default HTTP client.",
tag.SourceCluster(clusterMetadata.GetCurrentClusterName()),
tag.TargetCluster(clusterName),
)
return client.Do(r)
}
}
r.URL.Scheme = frontendClient.Scheme
r.URL.Host = frontendClient.Address
r.Host = frontendClient.Address
return frontendClient.Do(r)
}
}
// We don't know this calling cluster, use the default client.
return client.Do(r)
}
})
return m.Get, nil
}