Files
pdoernerandGitHub a706eb9fdb CompleteNexusOperation request forwarding (#6117)
## What changed?
<!-- Describe what has changed in this PR -->
Added support for forwarding `CompleteNexusOperation` requests from
standby to active clusters.

## Why?
<!-- Tell your future self why have you made these changes -->
To avoid breaking operations if namespace failover occurs.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
New xdc functional test

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-06-20 13:08:32 -04:00

73 lines
2.9 KiB
Go

// The MIT License
//
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package frontend
import (
"net/http"
"github.com/gorilla/mux"
"github.com/nexus-rpc/sdk-go/nexus"
"go.uber.org/fx"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
commonnexus "go.temporal.io/server/common/nexus"
"go.temporal.io/server/common/rpc"
)
var Module = fx.Module(
"component.nexusoperations.frontend",
fx.Provide(ConfigProvider),
fx.Provide(commonnexus.NewCallbackTokenGenerator),
fx.Invoke(RegisterHTTPHandler),
)
func ConfigProvider(coll *dynamicconfig.Collection) *Config {
return &Config{
Enabled: dynamicconfig.EnableNexus.Get(coll),
PayloadSizeLimit: dynamicconfig.BlobSizeLimitError.Get(coll),
ForwardingEnabledForNamespace: dynamicconfig.EnableNamespaceNotActiveAutoForwarding.Get(coll),
}
}
func RegisterHTTPHandler(options HandlerOptions, logger log.Logger, router *mux.Router) {
h := nexus.NewCompletionHTTPHandler(nexus.CompletionHandlerOptions{
Handler: &completionHandler{
options,
headers.NewDefaultVersionChecker(),
options.MetricsHandler.Counter(metrics.NexusCompletionRequestPreProcessErrors.Name()),
},
Logger: log.NewSlogLogger(logger),
Serializer: commonnexus.PayloadSerializer,
})
router.Path("/" + commonnexus.RouteCompletionCallback.Representation()).HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// Limit the request body to max allowed Payload size.
// Content headers are transformed to Payload metadata and contribute to the Payload size as well. A separate
// limit is enforced on top of this in the CompleteOperation method.
r.Body = http.MaxBytesReader(w, r.Body, rpc.MaxNexusAPIRequestBodyBytes)
h.ServeHTTP(w, r)
})
}