Files
tasks/service/history/ndc/events_reapplier.go
Roey BermanandGitHub 3871008a84 Nexus events cherry pick (reapply) support (#6263)
## What changed?

Add the `CherryPick` (a better name than "reapply" IMHO) method to the
`hsm.EventDefinition` interface and use this method when "reapplying"
events from a different branch.

Note that workflow reset with nexus operations is broken right now (and
was already broken) as the completion token allocated in the start
request targets a specific run. That will be fixed later on.

## Why?

Found an edge case during replication when namespace failover happens as
a `NexusOperationCompleted` event is buffered causing the caller
workflow to get stuck waiting for completion to arrive.

## How did you test it?

Functional + unit tests
2024-07-12 16:04:10 +00:00

125 lines
4.1 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//go:generate mockgen -copyright_file ../../../LICENSE -package $GOPACKAGE -source $GOFILE -destination events_reapplier_mock.go
package ndc
import (
"context"
enumspb "go.temporal.io/api/enums/v1"
historypb "go.temporal.io/api/history/v1"
"go.temporal.io/api/serviceerror"
enumsspb "go.temporal.io/server/api/enums/v1"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/service/history/hsm"
"go.temporal.io/server/service/history/workflow"
"go.temporal.io/server/service/history/workflow/update"
)
type (
EventsReapplier interface {
ReapplyEvents(
ctx context.Context,
ms workflow.MutableState,
updateRegistry update.Registry,
historyEvents []*historypb.HistoryEvent,
runID string,
) ([]*historypb.HistoryEvent, error)
}
EventsReapplierImpl struct {
stateMachineRegistry *hsm.Registry
metricsHandler metrics.Handler
logger log.Logger
}
)
func NewEventsReapplier(
stateMachineRegistry *hsm.Registry,
metricsHandler metrics.Handler,
logger log.Logger,
) *EventsReapplierImpl {
return &EventsReapplierImpl{
stateMachineRegistry: stateMachineRegistry,
metricsHandler: metricsHandler,
logger: logger,
}
}
func (r *EventsReapplierImpl) ReapplyEvents(
ctx context.Context,
ms workflow.MutableState,
updateRegistry update.Registry,
historyEvents []*historypb.HistoryEvent,
runID string,
) ([]*historypb.HistoryEvent, error) {
// sanity check workflow still running
if !ms.IsWorkflowExecutionRunning() {
return nil, serviceerror.NewInternal("unable to reapply events to closed workflow.")
}
reappliedEvents, err := reapplyEvents(ms, updateRegistry, r.stateMachineRegistry, historyEvents, nil, runID)
if err != nil {
return nil, err
}
if len(reappliedEvents) == 0 {
return nil, nil
}
shouldScheduleWorkflowTask := false
for _, event := range reappliedEvents {
switch event.GetEventType() { //nolint:exhaustive
case enumspb.EVENT_TYPE_WORKFLOW_EXECUTION_SIGNALED:
signal := event.GetWorkflowExecutionSignaledEventAttributes()
shouldScheduleWorkflowTask = shouldScheduleWorkflowTask || !signal.GetSkipGenerateWorkflowTask()
case enumspb.EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_ADMITTED, enumspb.EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_ACCEPTED:
shouldScheduleWorkflowTask = true
}
}
// After reapply event, checking if we should schedule a workflow task
if ms.IsWorkflowPendingOnWorkflowTaskBackoff() {
// Do not create workflow task when the workflow has first workflow task backoff and execution is not started yet
return reappliedEvents, nil
}
if !shouldScheduleWorkflowTask {
// Do not create workflow task when all reapplied signals had SkipGenerateWorkflowTask=true flag set
return reappliedEvents, nil
}
if !ms.HasPendingWorkflowTask() {
if _, err := ms.AddWorkflowTaskScheduledEvent(
false,
enumsspb.WORKFLOW_TASK_TYPE_NORMAL,
); err != nil {
return nil, err
}
}
return reappliedEvents, nil
}