mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Yichao YangandGitHub
49960c02a9
## What changed? <!-- Describe what has changed in this PR --> - Remove queue reader registration error handling logic - This PR is a follow up of https://github.com/temporalio/temporal/pull/5420 ## Why? <!-- Tell your future self why have you made these changes --> - Queue reader creation is an in-memory operation and should always succeed. Those error handling logic was added for a deprecated design where upon creating a queue reader, the logic also needs to talk to persistence layer. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Existing tests ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - Risk is low as those logic are never triggered. However, is a bug is introduced in this PR, task can be lost. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> - N/A ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> - No
110 lines
3.2 KiB
Go
110 lines
3.2 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package queues
|
|
|
|
import (
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/service/history/tasks"
|
|
)
|
|
|
|
var _ Action = (*actionReaderStuck)(nil)
|
|
|
|
type (
|
|
actionReaderStuck struct {
|
|
attributes *AlertAttributesReaderStuck
|
|
logger log.Logger
|
|
}
|
|
)
|
|
|
|
func newReaderStuckAction(
|
|
attributes *AlertAttributesReaderStuck,
|
|
logger log.Logger,
|
|
) *actionReaderStuck {
|
|
return &actionReaderStuck{
|
|
attributes: attributes,
|
|
logger: logger,
|
|
}
|
|
}
|
|
|
|
func (a *actionReaderStuck) Name() string {
|
|
return "reader-stuck"
|
|
}
|
|
|
|
func (a *actionReaderStuck) Run(readerGroup *ReaderGroup) {
|
|
reader, ok := readerGroup.ReaderByID(a.attributes.ReaderID)
|
|
if !ok {
|
|
a.logger.Info("Failed to get queue with readerID for reader stuck action", tag.QueueReaderID(a.attributes.ReaderID))
|
|
return
|
|
}
|
|
|
|
stuckRange := NewRange(
|
|
a.attributes.CurrentWatermark,
|
|
tasks.NewKey(
|
|
a.attributes.CurrentWatermark.FireTime.Add(monitorWatermarkPrecision),
|
|
a.attributes.CurrentWatermark.TaskID,
|
|
),
|
|
)
|
|
|
|
var splitSlices []Slice
|
|
reader.SplitSlices(func(s Slice) ([]Slice, bool) {
|
|
r := s.Scope().Range
|
|
if stuckRange.ContainsRange(r) {
|
|
splitSlices = append(splitSlices, s)
|
|
return nil, true
|
|
}
|
|
|
|
remaining := make([]Slice, 0, 2)
|
|
if s.CanSplitByRange(stuckRange.InclusiveMin) {
|
|
left, right := s.SplitByRange(stuckRange.InclusiveMin)
|
|
remaining = append(remaining, left)
|
|
s = right
|
|
}
|
|
|
|
if s.CanSplitByRange(stuckRange.ExclusiveMax) {
|
|
left, right := s.SplitByRange(stuckRange.ExclusiveMax)
|
|
remaining = append(remaining, right)
|
|
s = left
|
|
}
|
|
|
|
if len(remaining) == 0 {
|
|
// s can't split by both min and max of stuck range,
|
|
// and stuck range does not contain the range of s,
|
|
// the only possible case is s is not overlapping with stuck range at all.
|
|
return nil, false
|
|
}
|
|
|
|
splitSlices = append(splitSlices, s)
|
|
return remaining, true
|
|
})
|
|
|
|
if len(splitSlices) == 0 {
|
|
return
|
|
}
|
|
|
|
nextReader := readerGroup.GetOrCreateReader(a.attributes.ReaderID + 1)
|
|
nextReader.MergeSlices(splitSlices...)
|
|
}
|