Files
tasks/service/history/workflow/command_handler.go
Lina JodoinandGitHub d69b752e2c terminate (instead of fail) workflows whose tasks fail to complete due to payload size limit breach (#6180)
## What changed?
<!-- Describe what has changed in this PR -->
When a workflow task is being acknowledged as completed by the history
service, the payload size is validated. Previously, a payload size
exceeding the limit would result in a workflow failure (usually
indicating a failure from the application code). Now, payload size limit
breaches result in workflow termination (indicating a failure originated
from the service).

## Why?
<!-- Tell your future self why have you made these changes -->
This helps customers delineate between failures originating from their
application (via SDK call) and failures originating from the Temporal
service/backend.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- `make unit-test`. The [existing
tests](https://github.com/temporalio/temporal/blob/main/service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler_test.go#L264-L268),
which validate the correct failure messages are set from the handler,
continues to pass.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
Temrination of workflows is unexpected in metrics or logs, given that
it's a behavior change. Existing dashboards that don't surface workflow
terminations may lose visibility.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No
2024-06-25 16:45:34 +00:00

94 lines
3.5 KiB
Go

// The MIT License
//
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package workflow
import (
"context"
"errors"
"fmt"
commandpb "go.temporal.io/api/command/v1"
enumspb "go.temporal.io/api/enums/v1"
)
// ErrDuplicateRegistration is returned by a [CommandHandlerRegistry] when it detects duplicate registration.
var ErrDuplicateRegistration = errors.New("duplicate registration")
// FailWorkflowTaskError is an error that can be returned from a [CommandHandler] to fail the current workflow task and
// optionally terminate the entire workflow.
type FailWorkflowTaskError struct {
// The cause to set on the WorkflowTaskFailed event.
Cause enumspb.WorkflowTaskFailedCause
Message string
TerminateWorkflow bool
}
func (e FailWorkflowTaskError) Error() string {
return e.Message
}
// CommandHandler is a function for handling a workflow command as part of processing a RespondWorkflowTaskCompleted
// worker request.
type CommandHandler func(
context.Context,
MutableState,
CommandValidator,
int64,
*commandpb.Command,
) error
// CommandHandlerRegistry maintains a mapping of command type to [CommandHandler].
type CommandHandlerRegistry struct {
handlers map[enumspb.CommandType]CommandHandler
}
// CommandValidator is a helper for validating workflow commands.
type CommandValidator interface {
// IsValidPayloadSize validates that a payload size is within the configured limits.
IsValidPayloadSize(size int) bool
}
// NewCommandHandlerRegistry creates a new [CommandHandlerRegistry].
func NewCommandHandlerRegistry() *CommandHandlerRegistry {
return &CommandHandlerRegistry{
handlers: make(map[enumspb.CommandType]CommandHandler),
}
}
// Register registers a [CommandHandler] for a given command type.
// Returns an [ErrDuplicateRegistration] if a handler for the given command is already registered.
// All registration is expected to happen in a single thread on process initialization.
func (r *CommandHandlerRegistry) Register(t enumspb.CommandType, handler CommandHandler) error {
if existing, ok := r.handlers[t]; ok {
return fmt.Errorf("%w: command handler for %v: %v", ErrDuplicateRegistration, t, existing)
}
r.handlers[t] = handler
return nil
}
// Handler returns a [CommandHandler] for a given type and a boolean indicating whether it was found.
func (r *CommandHandlerRegistry) Handler(t enumspb.CommandType) (handler CommandHandler, ok bool) {
handler, ok = r.handlers[t]
return
}