Files
LuanandGitHub ea53aa9362 Migrate usage of metrics.Handler to metricDefinition.With (#5435)
## What changed?
Using the new metricDefinition.With approach.

## Why?
The usage of metrics.Handler could be both redundant and unsafe:

```
 handler.Histogram( myHisto.Name(), myHisto.Unit() ).Record(...)
                │             │               └───┐
                │             │                   │
                └─────┐       └───────────┐       │
                      │                   │       │
       Redundant and Unsafe: 'Histogram'  │       │
       is specified despite knowing       │       │
       'myHisto' is a histogram. There's  │       │
       also a risk if 'myHisto.Name()'    │       │
       refers to a metric definition that │       │
       is not a histogram.                │       │
                                          └─── Redundant information
```

And using the new With(Handler) method, there's no need to specify
redundant information.


## How did you test it?
Already exists an ExampleHandler which tests all the new approach
methods.

## Potential risks
People can still use the old approach, because we are keeping
the Handler interface as-is.

## Is hotfix candidate?
No.
2024-03-07 23:09:49 +00:00

255 lines
8.3 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package parentclosepolicy
import (
"context"
"time"
"github.com/pborman/uuid"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/api/taskqueue/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/sdk/activity"
"go.temporal.io/sdk/converter"
"go.temporal.io/sdk/temporal"
"go.temporal.io/sdk/workflow"
"google.golang.org/protobuf/types/known/durationpb"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/client"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/primitives"
)
const (
// processorTaskQueueName is the taskqueue name
processorTaskQueueName = "temporal-sys-processor-parent-close-policy"
// processorWFTypeName is the workflow type
processorWFTypeName = "temporal-sys-parent-close-policy-workflow"
processorActivityName = "temporal-sys-parent-close-policy-activity"
processorChannelName = "ParentClosePolicyProcessorChannelName"
)
type (
// RequestDetail defines detail of each workflow to process
RequestDetail struct {
Namespace string
NamespaceID string
WorkflowID string
RunID string
Policy enumspb.ParentClosePolicy
}
// Request defines the request for parent close policy
Request struct {
ParentExecution *commonpb.WorkflowExecution
Executions []RequestDetail
}
processorContextKeyType struct{}
)
var (
processorContextKey = processorContextKeyType{}
retryPolicy = temporal.RetryPolicy{
InitialInterval: 10 * time.Second,
BackoffCoefficient: 1.7,
MaximumInterval: 5 * time.Minute,
}
activityOptions = workflow.ActivityOptions{
ScheduleToStartTimeout: time.Minute,
StartToCloseTimeout: 5 * time.Minute,
RetryPolicy: &retryPolicy,
}
)
// ProcessorWorkflow is the workflow that performs actions for ParentClosePolicy
func ProcessorWorkflow(ctx workflow.Context) error {
requestCh := workflow.GetSignalChannel(ctx, processorChannelName)
for {
var request Request
if !requestCh.ReceiveAsync(&request) {
// no more request
break
}
opt := workflow.WithActivityOptions(ctx, activityOptions)
_ = workflow.ExecuteActivity(opt, processorActivityName, request).Get(ctx, nil)
}
return nil
}
// ProcessorActivity is activity for processing batch operation
func ProcessorActivity(ctx context.Context, request Request) error {
processor := ctx.Value(processorContextKey).(*Processor)
client := processor.clientBean.GetHistoryClient()
// this is for backward compatibility
// ideally we should always have childWorkflowOnly = true
// however if ParentExecution is not specified, setting it to false
// will cause terminate or cancel request to return mismatch error
childWorkflowOnly := request.ParentExecution.GetWorkflowId() != "" &&
request.ParentExecution.GetRunId() != ""
remoteExecutions := make(map[string][]RequestDetail)
for _, execution := range request.Executions {
requestCtx := headers.SetCallerName(ctx, execution.Namespace)
var err error
switch execution.Policy {
case enumspb.PARENT_CLOSE_POLICY_ABANDON:
// no-op
continue
case enumspb.PARENT_CLOSE_POLICY_TERMINATE:
_, err = client.TerminateWorkflowExecution(requestCtx, &historyservice.TerminateWorkflowExecutionRequest{
NamespaceId: execution.NamespaceID,
TerminateRequest: &workflowservice.TerminateWorkflowExecutionRequest{
Namespace: execution.Namespace,
WorkflowExecution: &commonpb.WorkflowExecution{
WorkflowId: execution.WorkflowID,
},
Reason: "by parent close policy",
Identity: processorWFTypeName,
FirstExecutionRunId: execution.RunID,
},
ExternalWorkflowExecution: request.ParentExecution,
ChildWorkflowOnly: childWorkflowOnly,
})
case enumspb.PARENT_CLOSE_POLICY_REQUEST_CANCEL:
_, err = client.RequestCancelWorkflowExecution(requestCtx, &historyservice.RequestCancelWorkflowExecutionRequest{
NamespaceId: execution.NamespaceID,
CancelRequest: &workflowservice.RequestCancelWorkflowExecutionRequest{
Namespace: execution.Namespace,
WorkflowExecution: &commonpb.WorkflowExecution{
WorkflowId: execution.WorkflowID,
},
Identity: processorWFTypeName,
FirstExecutionRunId: execution.RunID,
},
ExternalWorkflowExecution: request.ParentExecution,
ChildWorkflowOnly: childWorkflowOnly,
})
}
switch typedErr := err.(type) {
case nil:
metrics.ParentClosePolicyProcessorSuccess.With(processor.metricsHandler).Record(1)
case *serviceerror.NotFound, *serviceerror.NamespaceNotFound:
// no-op
case *serviceerror.NamespaceNotActive:
remoteExecutions[typedErr.ActiveCluster] = append(remoteExecutions[typedErr.ActiveCluster], execution)
default:
metrics.ParentClosePolicyProcessorFailures.With(processor.metricsHandler).Record(1)
getActivityLogger(ctx).Error("failed to process parent close policy", tag.Error(err))
return err
}
}
if err := signalRemoteCluster(
ctx,
processor.currentCluster,
processor.clientBean,
request.ParentExecution,
remoteExecutions,
processor.cfg.NumParentClosePolicySystemWorkflows(),
); err != nil {
getActivityLogger(ctx).Error("Failed to signal remote parent close policy workflow", tag.Error(err))
return err
}
return nil
}
func signalRemoteCluster(
ctx context.Context,
currentCluster string,
clientBean client.Bean,
parentExecution *commonpb.WorkflowExecution,
remoteExecutions map[string][]RequestDetail,
numWorkflows int,
) error {
for cluster, executions := range remoteExecutions {
_, remoteClient, err := clientBean.GetRemoteFrontendClient(cluster)
if err != nil {
return err
}
signalValue := Request{
ParentExecution: parentExecution,
Executions: executions,
}
signalInput, err := converter.GetDefaultDataConverter().ToPayloads(signalValue)
if err != nil {
return err
}
signalCtx, cancel := context.WithTimeout(ctx, signalTimeout)
_, err = remoteClient.SignalWithStartWorkflowExecution(
signalCtx,
&workflowservice.SignalWithStartWorkflowExecutionRequest{
Namespace: primitives.SystemLocalNamespace,
RequestId: uuid.New(),
WorkflowId: getWorkflowID(numWorkflows),
WorkflowType: &commonpb.WorkflowType{
Name: processorWFTypeName,
},
TaskQueue: &taskqueue.TaskQueue{
Name: processorTaskQueueName,
},
Input: nil,
WorkflowTaskTimeout: durationpb.New(workflowTaskTimeout),
Identity: currentCluster + "-" + string(primitives.WorkerService) + "-service",
WorkflowIdReusePolicy: workflowIDReusePolicy,
SignalName: processorChannelName,
SignalInput: signalInput,
},
)
cancel()
if err != nil {
return err
}
}
return nil
}
func getActivityLogger(ctx context.Context) log.Logger {
processor := ctx.Value(processorContextKey).(*Processor)
wfInfo := activity.GetInfo(ctx)
return log.With(
processor.logger,
tag.WorkflowID(wfInfo.WorkflowExecution.ID),
tag.WorkflowRunID(wfInfo.WorkflowExecution.RunID),
tag.WorkflowNamespace(wfInfo.WorkflowNamespace),
)
}