Files
Alex ShtinandGitHub 3e6639d573 Replace golang.org/x/exp with stdlib where possible (#6366)
## What changed?
<!-- Describe what has changed in this PR -->
Replace `golang.org/x/exp` with stdlib where possible. Unfortunately,
`maps` doesn't provide all methods that `expmaps` does, so I still have
`golang.org/x/exp` in `go.mod`.

## Why?
<!-- Tell your future self why have you made these changes -->
Follow up to #6018.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Build.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2024-08-01 19:33:04 +00:00

101 lines
3.4 KiB
Go

// The MIT License
//
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package scheduler
import (
"errors"
"fmt"
"go.temporal.io/api/serviceerror"
expmaps "golang.org/x/exp/maps"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence/visibility/store/elasticsearch"
"go.temporal.io/server/common/persistence/visibility/store/query"
"go.temporal.io/server/common/searchattribute"
)
type (
fieldNameAggInterceptor struct {
baseInterceptor query.FieldNameInterceptor
names map[string]bool
}
)
var _ query.FieldNameInterceptor = (*fieldNameAggInterceptor)(nil)
func (i *fieldNameAggInterceptor) Name(name string, usage query.FieldNameUsage) (string, error) {
i.names[name] = true
return i.baseInterceptor.Name(name, usage)
}
func newFieldNameAggInterceptor(
namespaceName namespace.Name,
saNameType searchattribute.NameTypeMap,
saMapperProvider searchattribute.MapperProvider,
) *fieldNameAggInterceptor {
return &fieldNameAggInterceptor{
baseInterceptor: elasticsearch.NewNameInterceptor(namespaceName, saNameType, saMapperProvider),
names: make(map[string]bool),
}
}
func ValidateVisibilityQuery(
namespaceName namespace.Name,
saNameType searchattribute.NameTypeMap,
saMapperProvider searchattribute.MapperProvider,
queryString string,
) error {
fields, err := getQueryFields(namespaceName, saNameType, saMapperProvider, queryString)
if err != nil {
return err
}
for _, field := range fields {
if searchattribute.IsReserved(field) && field != searchattribute.TemporalSchedulePaused {
return serviceerror.NewInvalidArgument(
fmt.Sprintf("invalid query filter for schedules: cannot filter on %q", field),
)
}
}
return nil
}
func getQueryFields(
namespaceName namespace.Name,
saNameType searchattribute.NameTypeMap,
saMapperProvider searchattribute.MapperProvider,
queryString string,
) ([]string, error) {
fnInterceptor := newFieldNameAggInterceptor(namespaceName, saNameType, saMapperProvider)
queryConverter := elasticsearch.NewQueryConverter(fnInterceptor, nil, saNameType)
_, err := queryConverter.ConvertWhereOrderBy(queryString)
if err != nil {
var converterErr *query.ConverterError
if errors.As(err, &converterErr) {
return nil, converterErr.ToInvalidArgument()
}
return nil, err
}
return expmaps.Keys(fnInterceptor.names), nil
}