mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? <!-- Describe what has changed in this PR --> Added `WithStaticHosts` start option. It is not explicitly exposed via the Server's CLI options. I'm assuming most users start the Server via https://github.com/temporalio/cli. **In a follow-up PR, I will add this option to the CLI dev server.** ## Why? Dynamic service membership isn't always required; when running all services locally, a static host map is sufficient. This will reduce the startup time slightly - but more importantly, not print "Not enough hosts to serve the request" randomly anymore. This change is based on the assumption that fixing the root cause of this issue is very much non-trivial. Therefore, opting out of the complex membership machinery when it's not needed seemed like a pragmatic change. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> For the regular path, dynamic membership, there's a test case. ### ✅ (Minor) startup speedup Ran a simple Workflow Update example; with and without the option. `hyperfine --runs 10 'go run cmd/main.go'` | Before | **After** | |--------|--------| | <img width="632" alt="Screenshot 2024-03-07 at 8 38 41 PM" src="https://github.com/temporalio/temporal/assets/159852/6d237e1b-e976-4694-ab8e-41b7b06cb263"> | <img width="628" alt="Screenshot 2024-03-07 at 8 39 19 PM" src="https://github.com/temporalio/temporal/assets/159852/25452405-e756-4df7-8e14-957a1c4688dc"> | ### ✅ Less noisy <details><summary>script</summary> <p> ``` for i in {1..10}; do echo "Run #$i" output=$( { go run cmd/main.go ; } 2>&1 ) if echo "$output" | grep -q "Not enough hosts to serve the request"; then echo "'Not enough hosts to serve the request'" fi done ``` </p> </details> | Before | **After** | |--------|--------| | <img width="325" alt="Screenshot 2024-03-07 at 8 47 49 PM" src="https://github.com/temporalio/temporal/assets/159852/a3579f63-adf2-40af-ad08-432a9a73cc8f"> | <img width="68" alt="Screenshot 2024-03-07 at 8 48 30 PM" src="https://github.com/temporalio/temporal/assets/159852/cf568a56-2878-499f-97ab-a13f5c056311"> | ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> --------- Co-authored-by: David Reiss <[email protected]>
209 lines
7.7 KiB
Go
209 lines
7.7 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package temporal
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"google.golang.org/grpc"
|
|
|
|
"go.temporal.io/server/client"
|
|
"go.temporal.io/server/common/authorization"
|
|
"go.temporal.io/server/common/config"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/membership/static"
|
|
"go.temporal.io/server/common/metrics"
|
|
persistenceclient "go.temporal.io/server/common/persistence/client"
|
|
"go.temporal.io/server/common/persistence/visibility"
|
|
"go.temporal.io/server/common/primitives"
|
|
"go.temporal.io/server/common/resolver"
|
|
"go.temporal.io/server/common/rpc/encryption"
|
|
"go.temporal.io/server/common/searchattribute"
|
|
)
|
|
|
|
type (
|
|
ServerOption interface {
|
|
apply(*serverOptions)
|
|
}
|
|
|
|
applyFunc func(*serverOptions)
|
|
)
|
|
|
|
func (f applyFunc) apply(s *serverOptions) { f(s) }
|
|
|
|
// WithConfig sets a custom configuration
|
|
func WithConfig(cfg *config.Config) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.config = cfg
|
|
})
|
|
}
|
|
|
|
// WithConfigLoader sets a custom configuration load
|
|
func WithConfigLoader(configDir string, env string, zone string) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.configDir, s.env, s.zone = configDir, env, zone
|
|
})
|
|
}
|
|
|
|
// ForServices indicates which supplied services (e.g. frontend, history, matching, worker) within the server to start
|
|
func ForServices(names []string) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.serviceNames = make(map[primitives.ServiceName]struct{})
|
|
for _, name := range names {
|
|
s.serviceNames[primitives.ServiceName(name)] = struct{}{}
|
|
}
|
|
})
|
|
}
|
|
|
|
// WithStaticHosts disables dynamic service membership and resolves service hosts statically.
|
|
// At least one host must be provided for all required services (frontend, history, matching, worker).
|
|
// And a self-address must be provided for all services passed to ForServices.
|
|
func WithStaticHosts(hostsByService map[primitives.ServiceName]static.Hosts) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.hostsByService = hostsByService
|
|
})
|
|
}
|
|
|
|
// InterruptOn interrupts server on the signal from server. If channel is nil Start() will block forever.
|
|
func InterruptOn(interruptCh <-chan interface{}) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.startupSynchronizationMode.blockingStart = true
|
|
s.startupSynchronizationMode.interruptCh = interruptCh
|
|
})
|
|
}
|
|
|
|
// WithLogger sets a custom logger
|
|
func WithLogger(logger log.Logger) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.logger = logger
|
|
})
|
|
}
|
|
|
|
// WithNamespaceLogger sets an optional logger for all frontend operations
|
|
func WithNamespaceLogger(namespaceLogger log.Logger) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.namespaceLogger = namespaceLogger
|
|
})
|
|
}
|
|
|
|
// WithAuthorizer sets a low level authorizer to allow/deny all API calls
|
|
func WithAuthorizer(authorizer authorization.Authorizer) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.authorizer = authorizer
|
|
})
|
|
}
|
|
|
|
// WithTLSConfigFactory overrides default provider of TLS configuration
|
|
func WithTLSConfigFactory(tlsConfigProvider encryption.TLSConfigProvider) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.tlsConfigProvider = tlsConfigProvider
|
|
})
|
|
}
|
|
|
|
// WithClaimMapper configures a role mapper for authorization
|
|
func WithClaimMapper(claimMapper func(cfg *config.Config) authorization.ClaimMapper) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.claimMapper = claimMapper(s.config)
|
|
})
|
|
}
|
|
|
|
// WithAudienceGetter configures JWT audience getter for authorization
|
|
func WithAudienceGetter(audienceGetter func(cfg *config.Config) authorization.JWTAudienceMapper) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.audienceGetter = audienceGetter(s.config)
|
|
})
|
|
}
|
|
|
|
// WithPersistenceServiceResolver sets a custom persistence service resolver which will convert service name or address value from config to another address
|
|
func WithPersistenceServiceResolver(r resolver.ServiceResolver) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.persistenceServiceResolver = r
|
|
})
|
|
}
|
|
|
|
// WithElasticsearchHttpClient sets a custom HTTP client which is used to make requests to Elasticsearch
|
|
func WithElasticsearchHttpClient(c *http.Client) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.elasticsearchHttpClient = c
|
|
})
|
|
}
|
|
|
|
// WithDynamicConfigClient sets custom client for reading dynamic configuration.
|
|
func WithDynamicConfigClient(c dynamicconfig.Client) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.dynamicConfigClient = c
|
|
})
|
|
}
|
|
|
|
// WithCustomDataStoreFactory sets a custom AbstractDataStoreFactory
|
|
// NOTE: this option is experimental and may be changed or removed in future release.
|
|
func WithCustomDataStoreFactory(customFactory persistenceclient.AbstractDataStoreFactory) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.customDataStoreFactory = customFactory
|
|
})
|
|
}
|
|
|
|
func WithCustomVisibilityStoreFactory(customFactory visibility.VisibilityStoreFactory) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.customVisibilityStoreFactory = customFactory
|
|
})
|
|
}
|
|
|
|
// WithClientFactoryProvider sets a custom ClientFactoryProvider
|
|
// NOTE: this option is experimental and may be changed or removed in future release.
|
|
func WithClientFactoryProvider(clientFactoryProvider client.FactoryProvider) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.clientFactoryProvider = clientFactoryProvider
|
|
})
|
|
}
|
|
|
|
// WithSearchAttributesMapper sets a custom search attributes mapper which converts search attributes aliases to field names and vice versa.
|
|
func WithSearchAttributesMapper(m searchattribute.Mapper) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.searchAttributesMapper = m
|
|
})
|
|
}
|
|
|
|
// WithChainedFrontendGrpcInterceptors sets a chain of ordered custom grpc interceptors that will be invoked for all
|
|
// Frontend gRPC API calls. The list of custom interceptors will be appended to the end of the internal
|
|
// ServerInterceptors. The custom interceptors will be invoked in the order as they appear in the supplied list, after
|
|
// the internal ServerInterceptors.
|
|
func WithChainedFrontendGrpcInterceptors(
|
|
interceptors ...grpc.UnaryServerInterceptor,
|
|
) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.customFrontendInterceptors = interceptors
|
|
})
|
|
}
|
|
|
|
// WithCustomerMetricsProvider sets a custom implementation of the metrics.MetricsHandler interface
|
|
// metrics.MetricsHandler is the base interface for publishing metric events
|
|
func WithCustomMetricsHandler(provider metrics.Handler) ServerOption {
|
|
return applyFunc(func(s *serverOptions) {
|
|
s.metricHandler = provider
|
|
})
|
|
}
|