Files
tasks/tests/admin.go
YuriandGitHub ce2b36e872 Use start time to dedup executions start (#6360)
## What changed?
<!-- Describe what has changed in this PR -->
1. Populate StartTime filed when CurrentWorkflowConditionFailedError
error happens
2. Use workflow start time from
WorfklowExecutionState/CurrentWorkflowConditionFailedError (so avoid
loading mutable state)
3. Add tests to verify that StartTime field in WorfklowExecutionState is
populated
4. Refactor some dedup tests.
5. Mark StartTime in ExecutionInfo as deprecated.

## Why?
To allow blocking frequent restarts without loading mutable state (and
thus without latency increase)

## How did you test it?
Add some unit tests, modify existing unit tests.


## Is hotfix candidate?
No
2024-08-01 10:26:30 -07:00

130 lines
4.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package tests
import (
"context"
"time"
"github.com/google/uuid"
commonpb "go.temporal.io/api/common/v1"
sdkclient "go.temporal.io/sdk/client"
"go.temporal.io/sdk/workflow"
"go.temporal.io/server/api/adminservice/v1"
"go.temporal.io/server/common/primitives/timestamp"
)
func (s *ClientFunctionalSuite) TestAdminRebuildMutableState() {
workflowFn := func(ctx workflow.Context) error {
var randomUUID string
err := workflow.SideEffect(
ctx,
func(workflow.Context) interface{} { return uuid.New().String() },
).Get(&randomUUID)
s.NoError(err)
_ = workflow.Sleep(ctx, 10*time.Minute)
return nil
}
s.worker.RegisterWorkflow(workflowFn)
workflowID := "functional-admin-rebuild-mutable-state-test"
workflowOptions := sdkclient.StartWorkflowOptions{
ID: workflowID,
TaskQueue: s.taskQueue,
WorkflowRunTimeout: 20 * time.Second,
}
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
s.NoError(err)
runID := workflowRun.GetRunID()
// there are total 6 events, 3 state transitions
// 1. WorkflowExecutionStarted
// 2. WorkflowTaskScheduled
//
// 3. WorkflowTaskStarted
//
// 4. WorkflowTaskCompleted
// 5. MarkerRecord
// 6. TimerStarted
var response1 *adminservice.DescribeMutableStateResponse
for {
response1, err = s.adminClient.DescribeMutableState(ctx, &adminservice.DescribeMutableStateRequest{
Namespace: s.namespace,
Execution: &commonpb.WorkflowExecution{
WorkflowId: workflowID,
RunId: runID,
},
})
s.NoError(err)
if response1.DatabaseMutableState.ExecutionInfo.StateTransitionCount == 3 {
break
}
time.Sleep(20 * time.Millisecond)
}
_, err = s.adminClient.RebuildMutableState(ctx, &adminservice.RebuildMutableStateRequest{
Namespace: s.namespace,
Execution: &commonpb.WorkflowExecution{
WorkflowId: workflowID,
RunId: runID,
},
})
s.NoError(err)
response2, err := s.adminClient.DescribeMutableState(ctx, &adminservice.DescribeMutableStateRequest{
Namespace: s.namespace,
Execution: &commonpb.WorkflowExecution{
WorkflowId: workflowID,
RunId: runID,
},
})
s.NoError(err)
s.Equal(response1.DatabaseMutableState.ExecutionInfo.VersionHistories, response2.DatabaseMutableState.ExecutionInfo.VersionHistories)
s.Equal(response1.DatabaseMutableState.ExecutionInfo.StateTransitionCount, response2.DatabaseMutableState.ExecutionInfo.StateTransitionCount)
// rebuild explicitly sets start time, thus start time will change after rebuild
s.Equal(response1.DatabaseMutableState.ExecutionState.CreateRequestId, response2.DatabaseMutableState.ExecutionState.CreateRequestId)
s.Equal(response1.DatabaseMutableState.ExecutionState.RunId, response2.DatabaseMutableState.ExecutionState.RunId)
s.Equal(response1.DatabaseMutableState.ExecutionState.State, response2.DatabaseMutableState.ExecutionState.State)
s.Equal(response1.DatabaseMutableState.ExecutionState.Status, response2.DatabaseMutableState.ExecutionState.Status)
s.Equal(response1.DatabaseMutableState.ExecutionState.LastUpdateVersionedTransition, response2.DatabaseMutableState.ExecutionState.LastUpdateVersionedTransition)
s.NotNil(response1.DatabaseMutableState.ExecutionState.StartTime)
s.NotNil(response2.DatabaseMutableState.ExecutionState.StartTime)
timeBefore := timestamp.TimeValue(response1.DatabaseMutableState.ExecutionState.StartTime)
timeAfter := timestamp.TimeValue(response2.DatabaseMutableState.ExecutionState.StartTime)
s.False(timeAfter.Before(timeBefore))
}