mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Before: if there was not workflow task scheduled just fail. After: check if query will actually time out while waiting, and if it will not - wait. ## Why? To reduce avoidable failures. Query shouldn't fail if it can wait until successful conditions will be met. ## How did you test it? Extend existing functional test to cover both situations. ## Potential risks N/A ## Documentation N/A ## Is hotfix candidate? No --------- Co-authored-by: Alex Shtin <[email protected]> Co-authored-by: Alex Shtin <[email protected]>
349 lines
10 KiB
Go
349 lines
10 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package tests
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
sdkclient "go.temporal.io/sdk/client"
|
|
"go.temporal.io/sdk/worker"
|
|
"go.temporal.io/sdk/workflow"
|
|
|
|
"go.temporal.io/server/common/testing/testvars"
|
|
"go.temporal.io/server/service/history/consts"
|
|
|
|
"go.temporal.io/api/serviceerror"
|
|
|
|
"go.temporal.io/server/common/log/tag"
|
|
)
|
|
|
|
func (s *ClientFunctionalSuite) TestQueryWorkflow_Sticky() {
|
|
var replayCount int32
|
|
workflowFn := func(ctx workflow.Context) (string, error) {
|
|
// every replay will start from here
|
|
atomic.AddInt32(&replayCount, 1)
|
|
|
|
workflow.SetQueryHandler(ctx, "test", func() (string, error) {
|
|
return "query works", nil
|
|
})
|
|
|
|
signalCh := workflow.GetSignalChannel(ctx, "test")
|
|
var msg string
|
|
signalCh.Receive(ctx, &msg)
|
|
return msg, nil
|
|
}
|
|
|
|
s.worker.RegisterWorkflow(workflowFn)
|
|
|
|
id := "test-query-sticky"
|
|
workflowOptions := sdkclient.StartWorkflowOptions{
|
|
ID: id,
|
|
TaskQueue: s.taskQueue,
|
|
WorkflowRunTimeout: 20 * time.Second,
|
|
}
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
|
|
if err != nil {
|
|
s.Logger.Fatal("Start workflow failed with err", tag.Error(err))
|
|
}
|
|
|
|
s.NotNil(workflowRun)
|
|
s.True(workflowRun.GetRunID() != "")
|
|
|
|
queryResult, err := s.sdkClient.QueryWorkflow(ctx, id, "", "test", "test")
|
|
s.NoError(err)
|
|
|
|
var queryResultStr string
|
|
err = queryResult.Get(&queryResultStr)
|
|
s.NoError(err)
|
|
s.Equal("query works", queryResultStr)
|
|
|
|
// verify query is handed by sticky worker (no replay)
|
|
s.Equal(int32(1), replayCount)
|
|
}
|
|
|
|
func (s *ClientFunctionalSuite) TestQueryWorkflow_Consistent_PiggybackQuery() {
|
|
workflowFn := func(ctx workflow.Context) (string, error) {
|
|
var receivedMsgs string
|
|
workflow.SetQueryHandler(ctx, "test", func() (string, error) {
|
|
return receivedMsgs, nil
|
|
})
|
|
|
|
signalCh := workflow.GetSignalChannel(ctx, "test")
|
|
for {
|
|
var msg string
|
|
signalCh.Receive(ctx, &msg)
|
|
receivedMsgs += msg
|
|
if msg == "pause" {
|
|
// block workflow task for 3s.
|
|
workflow.ExecuteLocalActivity(ctx, func() {
|
|
time.Sleep(time.Second * 3)
|
|
}).Get(ctx, nil)
|
|
}
|
|
}
|
|
}
|
|
|
|
s.worker.RegisterWorkflow(workflowFn)
|
|
|
|
id := "test-query-consistent"
|
|
workflowOptions := sdkclient.StartWorkflowOptions{
|
|
ID: id,
|
|
TaskQueue: s.taskQueue,
|
|
WorkflowRunTimeout: 20 * time.Second,
|
|
}
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
|
|
if err != nil {
|
|
s.Logger.Fatal("Start workflow failed with err", tag.Error(err))
|
|
}
|
|
|
|
s.NotNil(workflowRun)
|
|
s.True(workflowRun.GetRunID() != "")
|
|
|
|
err = s.sdkClient.SignalWorkflow(ctx, id, "", "test", "pause")
|
|
s.NoError(err)
|
|
|
|
err = s.sdkClient.SignalWorkflow(ctx, id, "", "test", "abc")
|
|
s.NoError(err)
|
|
|
|
queryResult, err := s.sdkClient.QueryWorkflow(ctx, id, "", "test")
|
|
s.NoError(err)
|
|
|
|
var queryResultStr string
|
|
err = queryResult.Get(&queryResultStr)
|
|
s.NoError(err)
|
|
|
|
// verify query sees all signals before it
|
|
s.Equal("pauseabc", queryResultStr)
|
|
}
|
|
|
|
func (s *ClientFunctionalSuite) TestQueryWorkflow_QueryWhileBackoff() {
|
|
|
|
tv := testvars.New(s.T())
|
|
workflowFn := func(ctx workflow.Context) error {
|
|
_ = workflow.SetQueryHandler(ctx, tv.QueryType(), func() (string, error) {
|
|
return tv.Any().String(), nil
|
|
})
|
|
return nil
|
|
}
|
|
s.worker.RegisterWorkflow(workflowFn)
|
|
|
|
testCases := []struct {
|
|
testName string
|
|
contextTimeout time.Duration
|
|
startDelay time.Duration
|
|
err error
|
|
}{
|
|
{
|
|
testName: "backoff query will fail",
|
|
contextTimeout: 10 * time.Second,
|
|
startDelay: 5 * time.Second,
|
|
err: nil,
|
|
},
|
|
{
|
|
testName: "backoff query will pass",
|
|
contextTimeout: 8 * time.Second,
|
|
startDelay: 10 * time.Second,
|
|
err: consts.ErrWorkflowTaskNotScheduled,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
s.T().Run(tc.testName, func(t *testing.T) {
|
|
workflowOptions := sdkclient.StartWorkflowOptions{
|
|
ID: tv.WorkflowID(t.Name()),
|
|
TaskQueue: s.taskQueue,
|
|
StartDelay: tc.startDelay,
|
|
}
|
|
|
|
// contextTimeout is not going to be the provided timeout.
|
|
// It is going to be timeout / 2. See newGRPCContext implementation.
|
|
ctx, cancel := context.WithTimeout(context.Background(), 2*tc.contextTimeout)
|
|
defer cancel()
|
|
|
|
t.Log(fmt.Sprintf("Start workflow with delay %v", tc.startDelay))
|
|
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
|
|
assert.NoError(t, err, "Start workflow failed")
|
|
assert.NotNil(t, workflowRun)
|
|
assert.NotEmpty(t, workflowRun.GetRunID())
|
|
|
|
queryResp, err := s.sdkClient.QueryWorkflow(ctx, tv.WorkflowID(t.Name()), workflowRun.GetRunID(), tv.QueryType())
|
|
|
|
if tc.err != nil {
|
|
assert.Error(t, err)
|
|
assert.ErrorContains(t, err, tc.err.Error())
|
|
assert.Nil(t, queryResp)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, queryResp)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *ClientFunctionalSuite) TestQueryWorkflow_QueryBeforeStart() {
|
|
// stop the worker, so the workflow won't be started before query
|
|
s.worker.Stop()
|
|
|
|
workflowFn := func(ctx workflow.Context) (string, error) {
|
|
status := "initialized"
|
|
workflow.SetQueryHandler(ctx, "test", func() (string, error) {
|
|
return status, nil
|
|
})
|
|
|
|
status = "started"
|
|
workflow.Sleep(ctx, time.Hour)
|
|
return "", nil
|
|
}
|
|
|
|
id := "test-query-before-start"
|
|
workflowOptions := sdkclient.StartWorkflowOptions{
|
|
ID: id,
|
|
TaskQueue: s.taskQueue,
|
|
WorkflowRunTimeout: 20 * time.Second,
|
|
}
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
|
|
if err != nil {
|
|
s.Logger.Fatal("Start workflow failed with err", tag.Error(err))
|
|
}
|
|
|
|
s.NotNil(workflowRun)
|
|
s.True(workflowRun.GetRunID() != "")
|
|
|
|
wg := sync.WaitGroup{}
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
|
|
startTime := time.Now()
|
|
queryResult, err := s.sdkClient.QueryWorkflow(ctx, id, "", "test")
|
|
endTime := time.Now()
|
|
s.NoError(err)
|
|
var queryResultStr string
|
|
err = queryResult.Get(&queryResultStr)
|
|
s.NoError(err)
|
|
|
|
// verify query sees all signals before it
|
|
s.Equal("started", queryResultStr)
|
|
|
|
s.True(endTime.Sub(startTime) > time.Second)
|
|
}()
|
|
|
|
// delay 2s to start worker, this will block query for 2s
|
|
time.Sleep(time.Second * 2)
|
|
s.worker = worker.New(s.sdkClient, s.taskQueue, worker.Options{})
|
|
s.worker.RegisterWorkflow(workflowFn)
|
|
if err := s.worker.Start(); err != nil {
|
|
s.Logger.Fatal("Error when start worker", tag.Error(err))
|
|
}
|
|
|
|
// wait query
|
|
wg.Wait()
|
|
}
|
|
|
|
func (s *ClientFunctionalSuite) TestQueryWorkflow_QueryFailedWorkflowTask() {
|
|
testname := s.T().Name()
|
|
var failures int32
|
|
workflowFn := func(ctx workflow.Context) (string, error) {
|
|
err := workflow.SetQueryHandler(ctx, testname, func() (string, error) {
|
|
return "", nil
|
|
})
|
|
|
|
if err != nil {
|
|
s.T().Fatalf("SetQueryHandler failed: %s", err.Error())
|
|
}
|
|
atomic.AddInt32(&failures, 1)
|
|
// force workflow task to fail
|
|
panic("Workflow failed")
|
|
}
|
|
|
|
s.worker.RegisterWorkflow(workflowFn)
|
|
|
|
id := "test-query-failed-workflow-task"
|
|
workflowOptions := sdkclient.StartWorkflowOptions{
|
|
ID: id,
|
|
TaskQueue: s.taskQueue,
|
|
WorkflowTaskTimeout: time.Second * 1, // use shorter wft timeout to make this test faster
|
|
WorkflowRunTimeout: 20 * time.Second,
|
|
}
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
|
|
if err != nil {
|
|
s.Logger.Fatal("Start workflow failed with err", tag.Error(err))
|
|
}
|
|
|
|
s.NotNil(workflowRun)
|
|
s.True(workflowRun.GetRunID() != "")
|
|
|
|
s.Eventually(func() bool {
|
|
// wait for workflow task to fail 3 times
|
|
return atomic.LoadInt32(&failures) >= 3
|
|
}, 10*time.Second, 50*time.Millisecond)
|
|
|
|
_, err = s.sdkClient.QueryWorkflow(ctx, id, "", testname)
|
|
s.Error(err)
|
|
s.IsType(&serviceerror.WorkflowNotReady{}, err)
|
|
|
|
}
|
|
|
|
func (s *ClientFunctionalSuite) TestQueryWorkflow_ClosedWithoutWorkflowTaskStarted() {
|
|
testname := s.T().Name()
|
|
workflowFn := func(ctx workflow.Context) (string, error) {
|
|
return "", errors.New("workflow should never execute")
|
|
}
|
|
id := "test-query-after-terminate"
|
|
workflowOptions := sdkclient.StartWorkflowOptions{
|
|
ID: id,
|
|
TaskQueue: s.taskQueue,
|
|
}
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
workflowRun, err := s.sdkClient.ExecuteWorkflow(ctx, workflowOptions, workflowFn)
|
|
if err != nil {
|
|
s.Logger.Fatal("Start workflow failed with err", tag.Error(err))
|
|
}
|
|
s.NotNil(workflowRun)
|
|
s.True(workflowRun.GetRunID() != "")
|
|
|
|
err = s.sdkClient.TerminateWorkflow(ctx, id, "", "terminating to make sure query fails")
|
|
s.NoError(err)
|
|
|
|
_, err = s.sdkClient.QueryWorkflow(ctx, id, "", testname)
|
|
s.Error(err)
|
|
s.ErrorContains(err, consts.ErrWorkflowClosedBeforeWorkflowTaskStarted.Error())
|
|
}
|