mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Shahab TajikandGitHub
ee00da67b9
## What changed? <!-- Describe what has changed in this PR --> - Send BuildIdRedirectInfo from Matching to History on Record*TaskStarted call containing information about redirect intention. - History validates the redirect info against current MS and fails the request if the redirect does not have source build if equal to the current assigned build of the workflow. - If redirect is valid, workflow is assigned to the new build id and all pending but not started task are rescheduled to be sent to the new build id. ## Why? <!-- Tell your future self why have you made these changes --> To prevent the following problems from happening for workflows with concurrent tasks when redirect rules are deleted or not fully propagated yet: 1. Assign wf back to an old build id after processing task using a newer build id 2. Interleaved Starts: for some duration tasks are dispatched to a mix of old or new build IDs 3. New activity output being fed to old wf 4. Execution gets stuck after being (partially) redirected ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Functional test. More unit tests to be added in a followup PR. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> As it is right now, in rare situations when a redirect rule is applied to a WF with concurrent activities and some of them are in backoff period due to failure, we may schedule (and start) them on the newer build without waiting for the backoff to finish. This is planed to be improved in the futuer. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> None. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.
579 lines
25 KiB
Go
579 lines
25 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
//go:build !race
|
|
|
|
// need to run xdc tests with race detector off because of ringpop bug causing data race issue
|
|
|
|
package xdc
|
|
|
|
import (
|
|
"flag"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/suite"
|
|
commandpb "go.temporal.io/api/command/v1"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
taskqueuepb "go.temporal.io/api/taskqueue/v1"
|
|
"go.temporal.io/api/workflowservice/v1"
|
|
sdkclient "go.temporal.io/sdk/client"
|
|
replicationspb "go.temporal.io/server/api/replication/v1"
|
|
"go.temporal.io/server/service/worker/migration"
|
|
"go.temporal.io/server/service/worker/scanner/build_ids"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
"go.temporal.io/server/api/adminservice/v1"
|
|
"go.temporal.io/server/api/enums/v1"
|
|
"go.temporal.io/server/api/matchingservice/v1"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common"
|
|
"go.temporal.io/server/common/clock/hybrid_logical_clock"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/primitives"
|
|
"go.temporal.io/server/common/worker_versioning"
|
|
"go.temporal.io/server/tests"
|
|
)
|
|
|
|
type (
|
|
UserDataReplicationTestSuite struct {
|
|
xdcBaseSuite
|
|
}
|
|
)
|
|
|
|
func TestUserDataReplicationTestSuite(t *testing.T) {
|
|
flag.Parse()
|
|
suite.Run(t, new(UserDataReplicationTestSuite))
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) SetupSuite() {
|
|
s.dynamicConfigOverrides = map[dynamicconfig.Key]any{
|
|
// Make sure we don't hit the rate limiter in tests
|
|
dynamicconfig.FrontendGlobalNamespaceNamespaceReplicationInducingAPIsRPS.Key(): 1000,
|
|
dynamicconfig.FrontendMaxNamespaceNamespaceReplicationInducingAPIsBurstRatioPerInstance.Key(): 1,
|
|
dynamicconfig.FrontendNamespaceReplicationInducingAPIsRPS.Key(): 1000,
|
|
dynamicconfig.FrontendEnableWorkerVersioningDataAPIs.Key(): true,
|
|
dynamicconfig.FrontendEnableWorkerVersioningWorkflowAPIs.Key(): true,
|
|
dynamicconfig.FrontendEnableWorkerVersioningRuleAPIs.Key(): true,
|
|
dynamicconfig.BuildIdScavengerEnabled.Key(): true,
|
|
// Ensure the scavenger can immediately delete build ids that are not in use.
|
|
dynamicconfig.RemovableBuildIdDurationSinceDefault.Key(): time.Microsecond,
|
|
}
|
|
s.setupSuite([]string{"task_queue_repl_active", "task_queue_repl_standby"})
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) SetupTest() {
|
|
s.setupTest()
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) TearDownSuite() {
|
|
s.tearDownSuite()
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) TestUserDataIsReplicatedFromActiveToPassive() {
|
|
namespace := s.T().Name() + "-" + common.GenerateRandomString(5)
|
|
taskQueue := "versioned"
|
|
activeFrontendClient := s.cluster1.GetFrontendClient()
|
|
regReq := &workflowservice.RegisterNamespaceRequest{
|
|
Namespace: namespace,
|
|
IsGlobalNamespace: true,
|
|
Clusters: s.clusterReplicationConfig(),
|
|
ActiveClusterName: s.clusterNames[0],
|
|
WorkflowExecutionRetentionPeriod: durationpb.New(7 * time.Hour * 24),
|
|
}
|
|
_, err := activeFrontendClient.RegisterNamespace(tests.NewContext(), regReq)
|
|
s.NoError(err)
|
|
|
|
description, err := activeFrontendClient.DescribeNamespace(tests.NewContext(), &workflowservice.DescribeNamespaceRequest{Namespace: namespace})
|
|
s.Require().NoError(err)
|
|
|
|
standbyMatchingClient := s.cluster2.GetMatchingClient()
|
|
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(tests.NewContext(), &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{AddNewBuildIdInNewDefaultSet: "0.1"},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
s.Eventually(func() bool {
|
|
// Call matching directly in case frontend is configured to redirect API calls to the active cluster
|
|
response, err := standbyMatchingClient.GetWorkerBuildIdCompatibility(tests.NewContext(), &matchingservice.GetWorkerBuildIdCompatibilityRequest{
|
|
NamespaceId: description.GetNamespaceInfo().Id,
|
|
Request: &workflowservice.GetWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
},
|
|
})
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return len(response.GetResponse().GetMajorVersionSets()) == 1
|
|
}, 15*time.Second, 500*time.Millisecond)
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) TestUserDataIsReplicatedFromPassiveToActive() {
|
|
namespace := s.T().Name() + "-" + common.GenerateRandomString(5)
|
|
taskQueue := "versioned"
|
|
activeFrontendClient := s.cluster1.GetFrontendClient()
|
|
regReq := &workflowservice.RegisterNamespaceRequest{
|
|
Namespace: namespace,
|
|
IsGlobalNamespace: true,
|
|
Clusters: s.clusterReplicationConfig(),
|
|
ActiveClusterName: s.clusterNames[0],
|
|
WorkflowExecutionRetentionPeriod: durationpb.New(7 * time.Hour * 24),
|
|
}
|
|
_, err := activeFrontendClient.RegisterNamespace(tests.NewContext(), regReq)
|
|
s.NoError(err)
|
|
// Wait for namespace cache to pick the change
|
|
time.Sleep(cacheRefreshInterval)
|
|
|
|
standbyFrontendClient := s.cluster2.GetFrontendClient()
|
|
|
|
s.Eventually(func() bool {
|
|
_, err = standbyFrontendClient.UpdateWorkerBuildIdCompatibility(tests.NewContext(), &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{AddNewBuildIdInNewDefaultSet: "0.1"},
|
|
})
|
|
return err == nil
|
|
}, 15*time.Second, 500*time.Millisecond)
|
|
|
|
s.Eventually(func() bool {
|
|
response, err := activeFrontendClient.GetWorkerBuildIdCompatibility(tests.NewContext(), &workflowservice.GetWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
})
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return len(response.GetMajorVersionSets()) == 1
|
|
}, 15*time.Second, 500*time.Millisecond)
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) TestUserDataEntriesAreReplicatedOnDemand() {
|
|
if !tests.UsingSQLAdvancedVisibility() {
|
|
s.T().Skip("Test requires advanced visibility")
|
|
}
|
|
|
|
ctx := tests.NewContext()
|
|
namespace := s.T().Name() + "-" + common.GenerateRandomString(5)
|
|
activeFrontendClient := s.cluster1.GetFrontendClient()
|
|
numTaskQueues := 20
|
|
regReq := &workflowservice.RegisterNamespaceRequest{
|
|
Namespace: namespace,
|
|
IsGlobalNamespace: true,
|
|
Clusters: s.clusterReplicationConfig(),
|
|
ActiveClusterName: s.clusterNames[0],
|
|
WorkflowExecutionRetentionPeriod: durationpb.New(7 * time.Hour * 24),
|
|
}
|
|
_, err := activeFrontendClient.RegisterNamespace(tests.NewContext(), regReq)
|
|
s.NoError(err)
|
|
// Wait for namespace cache to pick the change
|
|
time.Sleep(cacheRefreshInterval)
|
|
description, err := activeFrontendClient.DescribeNamespace(tests.NewContext(), &workflowservice.DescribeNamespaceRequest{Namespace: namespace})
|
|
s.Require().NoError(err)
|
|
|
|
exectedReplicatedTaskQueues := make(map[string]struct{}, numTaskQueues)
|
|
for i := 0; i < numTaskQueues; i++ {
|
|
taskQueue := fmt.Sprintf("q%v", i)
|
|
res, err := activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{
|
|
AddNewBuildIdInNewDefaultSet: "v0.1",
|
|
},
|
|
})
|
|
exectedReplicatedTaskQueues[taskQueue] = struct{}{}
|
|
s.NoError(err)
|
|
s.NotNil(res)
|
|
}
|
|
adminClient := s.cluster1.GetAdminClient()
|
|
|
|
// start force-replicate wf
|
|
sysClient, err := sdkclient.Dial(sdkclient.Options{
|
|
HostPort: s.cluster1.GetHost().FrontendGRPCAddress(),
|
|
Namespace: primitives.SystemLocalNamespace,
|
|
})
|
|
s.NoError(err)
|
|
run, err := sysClient.ExecuteWorkflow(ctx, sdkclient.StartWorkflowOptions{
|
|
ID: "force-replication-wf",
|
|
TaskQueue: primitives.DefaultWorkerTaskQueue,
|
|
WorkflowRunTimeout: time.Second * 30,
|
|
}, "force-replication", migration.ForceReplicationParams{
|
|
Namespace: namespace,
|
|
OverallRps: 10,
|
|
})
|
|
s.NoError(err)
|
|
err = run.Get(ctx, nil)
|
|
s.NoError(err)
|
|
|
|
replicationResponse, err := adminClient.GetNamespaceReplicationMessages(ctx, &adminservice.GetNamespaceReplicationMessagesRequest{
|
|
ClusterName: "follower",
|
|
LastRetrievedMessageId: -1,
|
|
LastProcessedMessageId: -1,
|
|
})
|
|
s.NoError(err)
|
|
var replicationTasks []*replicationspb.ReplicationTask
|
|
for _, task := range replicationResponse.GetMessages().ReplicationTasks {
|
|
if task.GetTaskQueueUserDataAttributes().GetNamespaceId() == description.GetNamespaceInfo().Id {
|
|
replicationTasks = append(replicationTasks, task)
|
|
}
|
|
}
|
|
numReplicationTasks := len(replicationTasks)
|
|
s.Equal(numReplicationTasks, numTaskQueues*2)
|
|
|
|
lastTasks := replicationTasks[:numTaskQueues]
|
|
s.Equal(numTaskQueues, len(lastTasks))
|
|
seenTaskQueues := make(map[string]struct{}, numTaskQueues)
|
|
// Check the seeded messages
|
|
for _, task := range lastTasks {
|
|
s.Equal(enums.REPLICATION_TASK_TYPE_TASK_QUEUE_USER_DATA, task.TaskType)
|
|
attrs := task.GetTaskQueueUserDataAttributes()
|
|
seenTaskQueues[attrs.TaskQueueName] = struct{}{}
|
|
}
|
|
|
|
s.Equal(exectedReplicatedTaskQueues, seenTaskQueues)
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) TestUserDataTombstonesAreReplicated() {
|
|
ctx := tests.NewContext()
|
|
namespace := s.T().Name() + "-" + common.GenerateRandomString(5)
|
|
activeFrontendClient := s.cluster1.GetFrontendClient()
|
|
taskQueue := "test-task-queue"
|
|
regReq := &workflowservice.RegisterNamespaceRequest{
|
|
Namespace: namespace,
|
|
IsGlobalNamespace: true,
|
|
Clusters: s.clusterReplicationConfig(),
|
|
ActiveClusterName: s.clusterNames[0],
|
|
WorkflowExecutionRetentionPeriod: durationpb.New(7 * time.Hour * 24),
|
|
}
|
|
_, err := activeFrontendClient.RegisterNamespace(tests.NewContext(), regReq)
|
|
s.NoError(err)
|
|
// Wait for namespace cache to pick the change
|
|
time.Sleep(cacheRefreshInterval)
|
|
description, err := activeFrontendClient.DescribeNamespace(tests.NewContext(), &workflowservice.DescribeNamespaceRequest{Namespace: namespace})
|
|
s.Require().NoError(err)
|
|
|
|
for i := 0; i < 3; i++ {
|
|
buildId := fmt.Sprintf("v%d", i)
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{
|
|
AddNewBuildIdInNewDefaultSet: buildId,
|
|
},
|
|
})
|
|
s.NoError(err)
|
|
}
|
|
activeAdminClient := s.cluster1.GetAdminClient()
|
|
|
|
// start build ID scavenger workflow
|
|
sysClient, err := sdkclient.Dial(sdkclient.Options{
|
|
HostPort: s.cluster1.GetHost().FrontendGRPCAddress(),
|
|
Namespace: primitives.SystemLocalNamespace,
|
|
})
|
|
s.NoError(err)
|
|
workflowID := s.T().Name() + "-workflow"
|
|
run, err := sysClient.ExecuteWorkflow(ctx, sdkclient.StartWorkflowOptions{
|
|
ID: workflowID,
|
|
TaskQueue: build_ids.BuildIdScavengerTaskQueueName,
|
|
WorkflowRunTimeout: time.Second * 30,
|
|
}, build_ids.BuildIdScavangerWorkflowName, build_ids.BuildIdScavangerInput{
|
|
IgnoreRetentionTime: true,
|
|
})
|
|
s.NoError(err)
|
|
err = run.Get(ctx, nil)
|
|
s.NoError(err)
|
|
|
|
replicationResponse, err := activeAdminClient.GetNamespaceReplicationMessages(ctx, &adminservice.GetNamespaceReplicationMessagesRequest{
|
|
ClusterName: "follower",
|
|
LastRetrievedMessageId: -1,
|
|
LastProcessedMessageId: -1,
|
|
})
|
|
s.NoError(err)
|
|
numReplicationTasks := len(replicationResponse.GetMessages().ReplicationTasks)
|
|
task := replicationResponse.GetMessages().ReplicationTasks[numReplicationTasks-1]
|
|
|
|
s.Equal(enums.REPLICATION_TASK_TYPE_TASK_QUEUE_USER_DATA, task.TaskType)
|
|
attrs := task.GetTaskQueueUserDataAttributes()
|
|
s.Equal(description.GetNamespaceInfo().Id, attrs.NamespaceId)
|
|
s.Equal(taskQueue, attrs.TaskQueueName)
|
|
s.Equal(3, len(attrs.UserData.VersioningData.VersionSets))
|
|
s.Equal("v0", attrs.UserData.VersioningData.VersionSets[0].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_DELETED, attrs.UserData.VersioningData.VersionSets[0].BuildIds[0].State)
|
|
s.Equal("v1", attrs.UserData.VersioningData.VersionSets[1].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_DELETED, attrs.UserData.VersioningData.VersionSets[1].BuildIds[0].State)
|
|
s.Equal("v2", attrs.UserData.VersioningData.VersionSets[2].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_ACTIVE, attrs.UserData.VersioningData.VersionSets[2].BuildIds[0].State)
|
|
|
|
// Add another build ID to verify that tombstones were deleted after the first scavenger run
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{
|
|
AddNewBuildIdInNewDefaultSet: "v3",
|
|
},
|
|
})
|
|
s.NoError(err)
|
|
|
|
replicationResponse, err = activeAdminClient.GetNamespaceReplicationMessages(ctx, &adminservice.GetNamespaceReplicationMessagesRequest{
|
|
ClusterName: "follower",
|
|
LastRetrievedMessageId: -1,
|
|
LastProcessedMessageId: -1,
|
|
})
|
|
s.NoError(err)
|
|
numReplicationTasks = len(replicationResponse.GetMessages().ReplicationTasks)
|
|
task = replicationResponse.GetMessages().ReplicationTasks[numReplicationTasks-1]
|
|
|
|
s.Equal(enums.REPLICATION_TASK_TYPE_TASK_QUEUE_USER_DATA, task.TaskType)
|
|
attrs = task.GetTaskQueueUserDataAttributes()
|
|
s.Equal(description.GetNamespaceInfo().Id, attrs.NamespaceId)
|
|
s.Equal(taskQueue, attrs.TaskQueueName)
|
|
s.Equal(2, len(attrs.UserData.VersioningData.VersionSets))
|
|
s.Equal("v2", attrs.UserData.VersioningData.VersionSets[0].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_ACTIVE, attrs.UserData.VersioningData.VersionSets[0].BuildIds[0].State)
|
|
s.Equal("v3", attrs.UserData.VersioningData.VersionSets[1].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_ACTIVE, attrs.UserData.VersioningData.VersionSets[1].BuildIds[0].State)
|
|
|
|
// Add a new build ID in standby cluster to verify it did not persist the replicated tombstones
|
|
standbyFrontendClient := s.cluster2.GetFrontendClient()
|
|
|
|
s.Eventually(func() bool {
|
|
// Wait for propagation
|
|
response, err := standbyFrontendClient.GetWorkerBuildIdCompatibility(tests.NewContext(), &workflowservice.GetWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
})
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return len(response.GetMajorVersionSets()) == 2 && response.MajorVersionSets[1].BuildIds[0] == "v3"
|
|
}, 15*time.Second, 500*time.Millisecond)
|
|
|
|
_, err = standbyFrontendClient.UpdateWorkerBuildIdCompatibility(tests.NewContext(), &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{
|
|
AddNewBuildIdInNewDefaultSet: "v4",
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
standbyAdminClient := s.cluster2.GetAdminClient()
|
|
replicationResponse, err = standbyAdminClient.GetNamespaceReplicationMessages(ctx, &adminservice.GetNamespaceReplicationMessagesRequest{
|
|
ClusterName: "follower",
|
|
LastRetrievedMessageId: -1,
|
|
LastProcessedMessageId: -1,
|
|
})
|
|
s.NoError(err)
|
|
numReplicationTasks = len(replicationResponse.GetMessages().ReplicationTasks)
|
|
task = replicationResponse.GetMessages().ReplicationTasks[numReplicationTasks-1]
|
|
|
|
s.Equal(enums.REPLICATION_TASK_TYPE_TASK_QUEUE_USER_DATA, task.TaskType)
|
|
attrs = task.GetTaskQueueUserDataAttributes()
|
|
s.Equal(description.GetNamespaceInfo().Id, attrs.NamespaceId)
|
|
s.Equal(taskQueue, attrs.TaskQueueName)
|
|
s.Equal(3, len(attrs.UserData.VersioningData.VersionSets))
|
|
s.Equal("v2", attrs.UserData.VersioningData.VersionSets[0].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_ACTIVE, attrs.UserData.VersioningData.VersionSets[0].BuildIds[0].State)
|
|
s.Equal("v3", attrs.UserData.VersioningData.VersionSets[1].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_ACTIVE, attrs.UserData.VersioningData.VersionSets[1].BuildIds[0].State)
|
|
s.Equal("v4", attrs.UserData.VersioningData.VersionSets[2].BuildIds[0].Id)
|
|
s.Equal(persistencespb.STATE_ACTIVE, attrs.UserData.VersioningData.VersionSets[2].BuildIds[0].State)
|
|
}
|
|
|
|
func (s *UserDataReplicationTestSuite) TestApplyReplicationEventRevivesInUseTombstones() {
|
|
ctx := tests.NewContext()
|
|
namespace := s.T().Name() + "-" + common.GenerateRandomString(5)
|
|
taskQueue := "test-task-queue"
|
|
activeFrontendClient := s.cluster1.GetFrontendClient()
|
|
|
|
_, err := activeFrontendClient.RegisterNamespace(tests.NewContext(), &workflowservice.RegisterNamespaceRequest{
|
|
Namespace: namespace,
|
|
IsGlobalNamespace: true,
|
|
Clusters: s.clusterReplicationConfig(),
|
|
ActiveClusterName: s.clusterNames[0],
|
|
WorkflowExecutionRetentionPeriod: durationpb.New(7 * time.Hour * 24),
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
// Create v0 and process a workflow with it - should be revived
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{
|
|
AddNewBuildIdInNewDefaultSet: "v0",
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
_, err = activeFrontendClient.StartWorkflowExecution(ctx, &workflowservice.StartWorkflowExecutionRequest{
|
|
Namespace: namespace,
|
|
WorkflowId: "test",
|
|
RequestId: uuid.NewString(),
|
|
WorkflowType: &commonpb.WorkflowType{Name: "workflow"},
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: taskQueue, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
})
|
|
s.Require().NoError(err)
|
|
task, err := activeFrontendClient.PollWorkflowTaskQueue(ctx, &workflowservice.PollWorkflowTaskQueueRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: taskQueue, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
Identity: "test",
|
|
WorkerVersionCapabilities: &commonpb.WorkerVersionCapabilities{
|
|
BuildId: "v0",
|
|
UseVersioning: true,
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
_, err = activeFrontendClient.RespondWorkflowTaskCompleted(ctx, &workflowservice.RespondWorkflowTaskCompletedRequest{
|
|
TaskToken: task.TaskToken,
|
|
Commands: []*commandpb.Command{
|
|
{
|
|
CommandType: enumspb.COMMAND_TYPE_COMPLETE_WORKFLOW_EXECUTION,
|
|
Attributes: &commandpb.Command_CompleteWorkflowExecutionCommandAttributes{
|
|
CompleteWorkflowExecutionCommandAttributes: &commandpb.CompleteWorkflowExecutionCommandAttributes{},
|
|
},
|
|
},
|
|
},
|
|
WorkerVersionStamp: &commonpb.WorkerVersionStamp{
|
|
BuildId: "v0",
|
|
UseVersioning: true,
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
// Create v0.1 as compatible with v0 - should not be revived
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewCompatibleBuildId{
|
|
AddNewCompatibleBuildId: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewCompatibleVersion{
|
|
NewBuildId: "v0.1",
|
|
ExistingCompatibleBuildId: "v0",
|
|
},
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
// Create v0.2 as compatible with v0 - check later that it is revived
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewCompatibleBuildId{
|
|
AddNewCompatibleBuildId: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewCompatibleVersion{
|
|
NewBuildId: "v0.2",
|
|
ExistingCompatibleBuildId: "v0",
|
|
},
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
// Create v1 as queue default - it never gets deleted
|
|
_, err = activeFrontendClient.UpdateWorkerBuildIdCompatibility(ctx, &workflowservice.UpdateWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
Operation: &workflowservice.UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet{
|
|
AddNewBuildIdInNewDefaultSet: "v1",
|
|
},
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
// Wait for visibility propagation
|
|
s.Eventually(func() bool {
|
|
resp, err := activeFrontendClient.CountWorkflowExecutions(ctx, &workflowservice.CountWorkflowExecutionsRequest{
|
|
Namespace: namespace,
|
|
Query: fmt.Sprintf("TaskQueue = %q AND BuildIds = %q", taskQueue, worker_versioning.VersionedBuildIdSearchAttribute("v0")),
|
|
})
|
|
s.Require().NoError(err)
|
|
return resp.Count == 1
|
|
}, time.Second*15, time.Millisecond*150)
|
|
|
|
adminClient := s.cluster1.GetAdminClient()
|
|
replicationResponse, err := adminClient.GetNamespaceReplicationMessages(ctx, &adminservice.GetNamespaceReplicationMessagesRequest{
|
|
ClusterName: "follower",
|
|
LastRetrievedMessageId: -1,
|
|
LastProcessedMessageId: -1,
|
|
})
|
|
s.Require().NoError(err)
|
|
attrsPreApply := replicationResponse.Messages.ReplicationTasks[len(replicationResponse.Messages.ReplicationTasks)-1].GetTaskQueueUserDataAttributes()
|
|
preApplyClock := common.CloneProto(attrsPreApply.UserData.Clock)
|
|
|
|
attrsPreApply.UserData.Clock.WallClock = time.Now().UnixMilli()
|
|
attrsPreApply.UserData.Clock.Version++
|
|
// Delete all v0 buildIds
|
|
attrsPreApply.UserData.VersioningData.VersionSets[0].BuildIds[0].State = persistencespb.STATE_DELETED
|
|
attrsPreApply.UserData.VersioningData.VersionSets[0].BuildIds[0].StateUpdateTimestamp = attrsPreApply.UserData.Clock
|
|
attrsPreApply.UserData.VersioningData.VersionSets[0].BuildIds[1].State = persistencespb.STATE_DELETED
|
|
attrsPreApply.UserData.VersioningData.VersionSets[0].BuildIds[1].StateUpdateTimestamp = attrsPreApply.UserData.Clock
|
|
attrsPreApply.UserData.VersioningData.VersionSets[0].BuildIds[2].State = persistencespb.STATE_DELETED
|
|
attrsPreApply.UserData.VersioningData.VersionSets[0].BuildIds[2].StateUpdateTimestamp = attrsPreApply.UserData.Clock
|
|
|
|
matchingClient := s.cluster1.GetMatchingClient()
|
|
_, err = matchingClient.ApplyTaskQueueUserDataReplicationEvent(ctx, &matchingservice.ApplyTaskQueueUserDataReplicationEventRequest{
|
|
NamespaceId: attrsPreApply.NamespaceId,
|
|
TaskQueue: taskQueue,
|
|
UserData: attrsPreApply.UserData,
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
// Check that v0 and v2 were revived
|
|
compat, err := activeFrontendClient.GetWorkerBuildIdCompatibility(ctx, &workflowservice.GetWorkerBuildIdCompatibilityRequest{
|
|
Namespace: namespace,
|
|
TaskQueue: taskQueue,
|
|
})
|
|
s.Require().NoError(err)
|
|
s.Require().Equal([]*taskqueuepb.CompatibleVersionSet{
|
|
{BuildIds: []string{"v0", "v0.2"}},
|
|
{BuildIds: []string{"v1"}},
|
|
}, compat.GetMajorVersionSets())
|
|
|
|
// Check that v0 and v2 were revived in the replication event
|
|
replicationResponse, err = adminClient.GetNamespaceReplicationMessages(ctx, &adminservice.GetNamespaceReplicationMessagesRequest{
|
|
ClusterName: "follower",
|
|
LastRetrievedMessageId: -1,
|
|
LastProcessedMessageId: -1,
|
|
})
|
|
s.Require().NoError(err)
|
|
|
|
attrsPostApply := replicationResponse.Messages.ReplicationTasks[len(replicationResponse.Messages.ReplicationTasks)-1].GetTaskQueueUserDataAttributes()
|
|
|
|
s.Require().True(hybrid_logical_clock.Greater(attrsPostApply.UserData.Clock, preApplyClock))
|
|
|
|
s.Require().Equal("v0", attrsPostApply.UserData.VersioningData.VersionSets[0].BuildIds[0].Id)
|
|
s.Require().Equal(persistencespb.STATE_ACTIVE, attrsPostApply.UserData.VersioningData.VersionSets[0].BuildIds[0].State)
|
|
s.Require().True(hybrid_logical_clock.Greater(attrsPostApply.UserData.VersioningData.VersionSets[0].BuildIds[0].StateUpdateTimestamp, preApplyClock))
|
|
|
|
s.Require().Equal("v0.2", attrsPostApply.UserData.VersioningData.VersionSets[0].BuildIds[1].Id)
|
|
s.Require().Equal(persistencespb.STATE_ACTIVE, attrsPostApply.UserData.VersioningData.VersionSets[0].BuildIds[1].State)
|
|
s.Require().True(hybrid_logical_clock.Greater(attrsPostApply.UserData.VersioningData.VersionSets[0].BuildIds[1].StateUpdateTimestamp, preApplyClock))
|
|
|
|
s.Require().Equal("v1", attrsPostApply.UserData.VersioningData.VersionSets[1].BuildIds[0].Id)
|
|
s.Require().Equal(persistencespb.STATE_ACTIVE, attrsPostApply.UserData.VersioningData.VersionSets[1].BuildIds[0].State)
|
|
s.Require().True(hybrid_logical_clock.Equal(attrsPostApply.UserData.VersioningData.VersionSets[1].BuildIds[0].StateUpdateTimestamp, preApplyClock))
|
|
}
|