Files
tasks/tools/cassandra/handler.go
973b3aacee Set allowed authenticators in tools and via env variables (#6194)
## What changed?
https://github.com/temporalio/temporal/pull/6155 introduced the config
value `allowedAuthenticators`. This PR updates the
`temporal-cassandra-tool` to use this config value. It also updates
`config_template.yaml` so that the config value can be set in docker
images as well.

## Why?
Cassandra supports several authenticators to verify the login
credentials. Gocql implements a subset of them as [default allowed list
of
authenticators](https://github.com/gocql/gocql/blob/34fdeebefcbf183ed7f916f931aa0586fdaa1b40/conn.go#L27).
It allows customization of this list to allow supporting additional
authenticators.
So with this change Temporal can connect to Cassandra clusters that have
authenticators other than the default ones provided by Gocql.

## How did you test it?
Ran `./temporal-cassandra-tool` and verified that it picked up the
values in environment variable `CASSANDRA_ALLOWED_AUTHENTICATORS`.
Couldn't test docker build since it's in a different repo.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
No

---------

Co-authored-by: Rob Holland <[email protected]>
2024-06-28 14:19:48 -07:00

261 lines
8.0 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package cassandra
import (
"fmt"
"strings"
"github.com/urfave/cli"
"go.temporal.io/server/common/auth"
c "go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/environment"
"go.temporal.io/server/tools/common/schema"
)
const defaultNumReplicas = 1
// SetupSchemaConfig contains the configuration params needed to setup schema tables
type SetupSchemaConfig struct {
CQLClientConfig
schema.SetupConfig
}
// setupSchema executes the setupSchemaTask
// using the given command line arguments
// as input
func setupSchema(cli *cli.Context, logger log.Logger) error {
config, err := newCQLClientConfig(cli)
if err != nil {
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
client, err := newCQLClient(config, logger)
if err != nil {
logger.Error("Unable to establish CQL session.", tag.Error(err))
return err
}
defer client.Close()
if err := schema.Setup(cli, client, logger); err != nil {
logger.Error("Unable to setup CQL schema.", tag.Error(err))
return err
}
return nil
}
// updateSchema executes the updateSchemaTask
// using the given command line args as input
func updateSchema(cli *cli.Context, logger log.Logger) error {
config, err := newCQLClientConfig(cli)
if err != nil {
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
client, err := newCQLClient(config, logger)
if err != nil {
logger.Error("Unable to establish CQL session.", tag.Error(err))
return err
}
defer client.Close()
if err := schema.Update(cli, client, logger); err != nil {
logger.Error("Unable to update CQL schema.", tag.Error(err))
return err
}
return nil
}
func createKeyspace(cli *cli.Context, logger log.Logger) error {
config, err := newCQLClientConfig(cli)
if err != nil {
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
keyspace := cli.String(schema.CLIOptKeyspace)
if keyspace == "" {
err := fmt.Errorf("missing %s argument", flag(schema.CLIOptKeyspace))
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
err = doCreateKeyspace(config, keyspace, logger)
if err != nil {
logger.Error("Unable to create keyspace.", tag.Error(err))
return err
}
return nil
}
func dropKeyspace(cli *cli.Context, logger log.Logger) error {
config, err := newCQLClientConfig(cli)
if err != nil {
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
keyspace := cli.String(schema.CLIOptKeyspace)
if keyspace == "" {
err := fmt.Errorf("missing %s argument", flag(schema.CLIOptKeyspace))
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
err = doDropKeyspace(config, keyspace, logger)
if err != nil {
logger.Error("Unable to drop keyspace.", tag.Error(err))
return err
}
return nil
}
func validateHealth(cli *cli.Context, logger log.Logger) error {
config, err := newCQLClientConfig(cli)
if err != nil {
logger.Error("Unable to read config.", tag.Error(schema.NewConfigError(err.Error())))
return err
}
config.Keyspace = systemKeyspace
client, err := newCQLClient(config, logger)
if err != nil {
logger.Error("Unable to establish CQL session.", tag.Error(err))
return err
}
defer client.Close()
return nil
}
func doCreateKeyspace(cfg *CQLClientConfig, name string, logger log.Logger) error {
cfg.Keyspace = systemKeyspace
client, err := newCQLClient(cfg, logger)
if err != nil {
return err
}
defer client.Close()
return client.createKeyspace(name)
}
func doDropKeyspace(cfg *CQLClientConfig, name string, logger log.Logger) error {
cfg.Keyspace = systemKeyspace
client, err := newCQLClient(cfg, logger)
if err != nil {
return err
}
defer client.Close()
return client.dropKeyspace(name)
}
func newCQLClientConfig(cli *cli.Context) (*CQLClientConfig, error) {
config := &CQLClientConfig{
Hosts: cli.GlobalString(schema.CLIOptEndpoint),
Port: cli.GlobalInt(schema.CLIOptPort),
User: cli.GlobalString(schema.CLIOptUser),
Password: cli.GlobalString(schema.CLIOptPassword),
AllowedAuthenticators: cli.GlobalStringSlice(schema.CLIOptAllowedAuthenticators),
Timeout: cli.GlobalInt(schema.CLIOptTimeout),
Keyspace: cli.GlobalString(schema.CLIOptKeyspace),
numReplicas: cli.Int(schema.CLIOptReplicationFactor),
Datacenter: cli.String(schema.CLIOptDatacenter),
Consistency: cli.String(schema.CLIOptConsistency),
DisableInitialHostLookup: cli.GlobalBool(schema.CLIFlagDisableInitialHostLookup),
}
if cli.GlobalBool(schema.CLIFlagEnableTLS) {
config.TLS = &auth.TLS{
Enabled: true,
CertFile: cli.GlobalString(schema.CLIFlagTLSCertFile),
KeyFile: cli.GlobalString(schema.CLIFlagTLSKeyFile),
CaFile: cli.GlobalString(schema.CLIFlagTLSCaFile),
ServerName: cli.GlobalString(schema.CLIFlagTLSHostName),
EnableHostVerification: !cli.GlobalBool(schema.CLIFlagTLSDisableHostVerification),
}
}
config.AddressTranslator = &c.CassandraAddressTranslator{
Translator: cli.GlobalString(schema.CLIOptAddressTranslator),
Options: parseOptionsMap(cli.GlobalString(schema.CLIOptAddressTranslatorOptions)),
}
if err := validateCQLClientConfig(config); err != nil {
return nil, err
}
return config, nil
}
func parseOptionsMap(value string) map[string]string {
if len(value) == 0 {
return make(map[string]string)
}
split := strings.Split(value, ",")
parsedMap := make(map[string]string)
for _, pair := range split {
trimmedPair := strings.ReplaceAll(pair, " ", "")
if len(trimmedPair) == 0 {
continue
}
splitPair := strings.Split(trimmedPair, "=")
if len(splitPair) != 2 {
continue
}
if len(splitPair[0]) == 0 || len(splitPair[1]) == 0 {
continue
}
parsedMap[splitPair[0]] = splitPair[1]
}
return parsedMap
}
func validateCQLClientConfig(config *CQLClientConfig) error {
if len(config.Hosts) == 0 {
return schema.NewConfigError("missing cassandra endpoint argument " + flag(schema.CLIOptEndpoint))
}
if config.Keyspace == "" {
return schema.NewConfigError("missing " + flag(schema.CLIOptKeyspace) + " argument ")
}
if config.Port == 0 {
config.Port = environment.GetCassandraPort()
}
if config.numReplicas == 0 {
config.numReplicas = defaultNumReplicas
}
if config.AddressTranslator != nil && len(config.AddressTranslator.Options) != 0 {
if len(config.AddressTranslator.Translator) == 0 {
return schema.NewConfigError("missing address translator argument " + flag(schema.CLIOptAddressTranslator))
}
}
return nil
}
func flag(opt string) string {
return "(-" + opt + ")"
}