Files
tasks/tools/common/schema/handler_test.go
Rodrigo ZhouandGitHub 0280e70e5b Remove support for standard visibility (#5387)
## What changed?
<!-- Describe what has changed in this PR -->
Remove support for standard visibility

## Why?
<!-- Tell your future self why have you made these changes -->
Standard visibility is deprecated.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-02-29 12:05:20 -06:00

150 lines
4.5 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package schema
import (
"testing"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
)
type (
HandlerTestSuite struct {
*require.Assertions // override suite.Suite.Assertions with require.Assertions; this means that s.NotNil(nil) will stop the test, not merely log an error
suite.Suite
db *mockSQLDB
}
)
func TestHandlerTestSuite(t *testing.T) {
suite.Run(t, new(HandlerTestSuite))
}
func (s *HandlerTestSuite) SetupTest() {
s.Assertions = require.New(s.T()) // Have to define our overridden assertions in the test setup. If we did it earlier, s.T() will return nil
s.db = new(mockSQLDB)
}
func (s *HandlerTestSuite) TestValidateSetupConfig() {
config := new(SetupConfig)
s.assertValidateSetupFails(config, s.db)
s.assertValidateSetupFails(config, s.db)
config.InitialVersion = "0.1"
config.DisableVersioning = true
config.SchemaFilePath = ""
s.assertValidateSetupFails(config, s.db)
config.InitialVersion = "0.1"
config.DisableVersioning = true
config.SchemaFilePath = "/tmp/foo.cql"
s.assertValidateSetupFails(config, s.db)
config.InitialVersion = ""
config.DisableVersioning = true
config.SchemaFilePath = ""
s.assertValidateSetupFails(config, s.db)
config.InitialVersion = "0.1"
config.DisableVersioning = false
config.SchemaFilePath = "/tmp/foo.cql"
s.assertValidateSetupSucceeds(config, s.db)
config.InitialVersion = "0.1"
config.DisableVersioning = false
config.SchemaFilePath = ""
s.assertValidateSetupSucceeds(config, s.db)
config.InitialVersion = ""
config.DisableVersioning = true
config.SchemaFilePath = "/tmp/foo.cql"
s.assertValidateSetupSucceeds(config, s.db)
config.SchemaName = "mysql/v8/temporal"
s.assertValidateSetupFails(config, s.db)
config.SchemaFilePath = ""
s.assertValidateSetupSucceeds(config, s.db)
config.SchemaName = "foo"
s.assertValidateSetupFails(config, s.db)
}
func (s *HandlerTestSuite) TestValidateUpdateConfig() {
config := new(UpdateConfig)
s.assertValidateUpdateFails(config, s.db)
s.assertValidateUpdateFails(config, s.db)
config.SchemaDir = "/tmp"
config.TargetVersion = "abc"
s.assertValidateUpdateFails(config, s.db)
config.SchemaDir = "/tmp"
config.TargetVersion = ""
s.assertValidateUpdateSucceeds(config, s.db)
config.SchemaDir = "/tmp"
config.TargetVersion = "1.2"
s.assertValidateUpdateSucceeds(config, s.db)
config.SchemaDir = "/tmp"
config.TargetVersion = "v1.2"
s.assertValidateUpdateSucceeds(config, s.db)
s.Equal("1.2", config.TargetVersion)
config.SchemaName = "mysql/v8/temporal"
s.assertValidateUpdateFails(config, s.db)
config.SchemaDir = ""
s.assertValidateUpdateSucceeds(config, s.db)
config.SchemaName = "foo"
s.assertValidateUpdateFails(config, s.db)
}
func (s *HandlerTestSuite) assertValidateSetupSucceeds(input *SetupConfig, db DB) {
err := validateSetupConfig(input, db)
s.Nil(err)
}
func (s *HandlerTestSuite) assertValidateSetupFails(input *SetupConfig, db DB) {
err := validateSetupConfig(input, db)
s.NotNil(err)
_, ok := err.(*ConfigError)
s.True(ok)
}
func (s *HandlerTestSuite) assertValidateUpdateSucceeds(input *UpdateConfig, db DB) {
err := validateUpdateConfig(input, db)
s.Nil(err)
}
func (s *HandlerTestSuite) assertValidateUpdateFails(input *UpdateConfig, db DB) {
err := validateUpdateConfig(input, db)
s.NotNil(err)
_, ok := err.(*ConfigError)
s.True(ok)
}