mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? <!-- Describe what has changed in this PR --> Make `Finalizer` release memory earlier. ## Why? <!-- Tell your future self why have you made these changes --> See PR comment to explain the background. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Existing tests still pass. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> Since `callbacks` is never read/written again after clearing it, it should be safe. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
186 lines
5.4 KiB
Go
186 lines
5.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package finalizer
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
cclock "go.temporal.io/server/common/clock"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/internal/goro"
|
|
)
|
|
|
|
var (
|
|
FinalizerAlreadyDoneErr = errors.New("finalizer already finalized")
|
|
FinalizerUnknownIdErr = errors.New("finalizer callback not found")
|
|
FinalizerDuplicateIdErr = errors.New("finalizer callback already registered")
|
|
)
|
|
|
|
type Finalizer struct {
|
|
logger log.Logger
|
|
metricsHandler metrics.Handler
|
|
mu sync.Mutex
|
|
finalized bool
|
|
callbacks map[string]func(context.Context) error
|
|
}
|
|
|
|
func New(
|
|
logger log.Logger,
|
|
metricsHandler metrics.Handler,
|
|
) *Finalizer {
|
|
return &Finalizer{
|
|
logger: logger,
|
|
metricsHandler: metricsHandler,
|
|
callbacks: make(map[string]func(context.Context) error),
|
|
}
|
|
}
|
|
|
|
// Register adds a callback to the finalizer.
|
|
// Returns an error if the ID is already registered, or when the finalizer is/was already running.
|
|
func (f *Finalizer) Register(
|
|
id string,
|
|
callback func(context.Context) error,
|
|
) error {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
|
|
if f.finalized {
|
|
// aborting immediately once the finalizer is/was running
|
|
return FinalizerAlreadyDoneErr
|
|
}
|
|
|
|
if _, ok := f.callbacks[id]; ok {
|
|
return FinalizerDuplicateIdErr
|
|
}
|
|
f.callbacks[id] = callback
|
|
return nil
|
|
}
|
|
|
|
// Deregister removes a callback from the finalizer.
|
|
// Returns an error if the ID is not found, or when the finalizer is/was already running.
|
|
func (f *Finalizer) Deregister(
|
|
id string,
|
|
) (err error) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
|
|
if f.finalized {
|
|
// aborting immediately once the finalizer is/was running
|
|
return FinalizerAlreadyDoneErr
|
|
}
|
|
|
|
if _, ok := f.callbacks[id]; !ok {
|
|
return FinalizerUnknownIdErr
|
|
}
|
|
delete(f.callbacks, id)
|
|
return nil
|
|
}
|
|
|
|
// Run executes all registered callback functions within the given timeout (zero timeout skips execution).
|
|
// It can only be invoked once; calling it again has no effect.
|
|
// Returns the number of completed callbacks.
|
|
func (f *Finalizer) Run(
|
|
timeout time.Duration,
|
|
) int {
|
|
if timeout == 0 {
|
|
f.logger.Info("finalizer skipped: zero timeout")
|
|
return 0
|
|
}
|
|
|
|
f.mu.Lock()
|
|
if f.finalized {
|
|
f.logger.Warn("finalizer skipped: called more than once")
|
|
f.mu.Unlock()
|
|
return 0
|
|
}
|
|
f.finalized = true
|
|
f.mu.Unlock() // unlocking immediately to unblock any calls to Register/Deregister
|
|
|
|
totalCount := len(f.callbacks)
|
|
if totalCount == 0 {
|
|
f.logger.Debug("finalizer skipped: no callbacks")
|
|
return 0
|
|
}
|
|
|
|
f.logger.Info("finalizer starting",
|
|
tag.NewInt("items", totalCount),
|
|
tag.NewDurationTag("timeout", timeout))
|
|
|
|
startTime := time.Now()
|
|
defer func() { metrics.FinalizerLatency.With(f.metricsHandler).Record(time.Since(startTime)) }()
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), timeout)
|
|
defer cancel()
|
|
|
|
pool := goro.NewAdaptivePool(cclock.NewRealTimeSource(), 5, 15, 10*time.Millisecond, 10)
|
|
defer pool.Stop()
|
|
|
|
completionChannel := make(chan struct{})
|
|
go func() {
|
|
for _, callback := range f.callbacks {
|
|
// NOTE: Once `pool.Stop` is called, any remaining calls to `pool.Do` will do nothing.
|
|
pool.Do(func() {
|
|
defer func() { completionChannel <- struct{}{} }()
|
|
_ = callback(ctx)
|
|
})
|
|
}
|
|
|
|
// prevent holding on to the callbacks for longer than needed and allow garbage collection
|
|
// (safe since any calls to Register/Deregister will be aborted now that the finalizer ran)
|
|
f.callbacks = nil
|
|
|
|
f.logger.Info("finalizer loop ended")
|
|
}()
|
|
|
|
var completedCallbacks int
|
|
defer func() {
|
|
metrics.FinalizerItemsCompleted.With(f.metricsHandler).Record(int64(completedCallbacks))
|
|
metrics.FinalizerItemsUnfinished.With(f.metricsHandler).Record(int64(totalCount - completedCallbacks))
|
|
}()
|
|
|
|
for {
|
|
select {
|
|
case <-completionChannel:
|
|
completedCallbacks += 1
|
|
if completedCallbacks == totalCount {
|
|
f.logger.Info("finalizer completed",
|
|
tag.NewInt("completed", completedCallbacks))
|
|
return completedCallbacks
|
|
}
|
|
|
|
case <-ctx.Done():
|
|
f.logger.Error("finalizer timed out",
|
|
tag.NewInt("completed", completedCallbacks),
|
|
tag.NewInt("unfinished", totalCount-completedCallbacks))
|
|
return completedCallbacks
|
|
}
|
|
}
|
|
}
|