mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Shahab TajikandGitHub
816955769b
## What changed? <!-- Describe what has changed in this PR --> Added dynamic configs to allow controlling the metrics breakdown based on task queue name, partition ID, and Build ID. Refactored all the places in the code that used these tags to consider the dc value. ## Why? <!-- Tell your future self why have you made these changes --> - Task Queue cardinality may be a problem for some self-hosted users. These configs allow to reduce cardinality. - The dynamic config is per task queue so it allows to turn it on for one or few task queues under investigation while disabled for everything else. - Simply excluding the tag value is not a good enough solution because the gauges such as backlog size or age will be mixed across task queues and become invalid. In this change, I disable the gauge completely if the configs do not allow necessary breakdown. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Added few unit tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
109 lines
4.3 KiB
Go
109 lines
4.3 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package metrics
|
|
|
|
import (
|
|
"math"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/pborman/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/uber-go/tally/v4"
|
|
)
|
|
|
|
var defaultConfig = ClientConfig{
|
|
Tags: nil,
|
|
ExcludeTags: map[string][]string{
|
|
"taskqueue": {"__sticky__"},
|
|
"activityType": {},
|
|
"workflowType": {},
|
|
},
|
|
Prefix: "",
|
|
PerUnitHistogramBoundaries: map[string][]float64{Dimensionless: {0, 10, 100}, Bytes: {1024, 2048}, Milliseconds: {10, 500, 1000, 5000, 10000}},
|
|
}
|
|
|
|
func TestTallyScope(t *testing.T) {
|
|
scope := tally.NewTestScope("test", map[string]string{})
|
|
mp := NewTallyMetricsHandler(defaultConfig, scope)
|
|
recordTallyMetrics(mp)
|
|
|
|
snap := scope.Snapshot()
|
|
counters, gauges, timers, histograms := snap.Counters(), snap.Gauges(), snap.Timers(), snap.Histograms()
|
|
|
|
assert.EqualValues(t, 8, counters["test.hits+"].Value())
|
|
assert.EqualValues(t, map[string]string{}, counters["test.hits+"].Tags())
|
|
|
|
assert.EqualValues(t, 11, counters["test.hits-tagged+taskqueue=__sticky__"].Value())
|
|
assert.EqualValues(t, map[string]string{"taskqueue": "__sticky__"}, counters["test.hits-tagged+taskqueue=__sticky__"].Tags())
|
|
|
|
assert.EqualValues(t, 14, counters["test.hits-tagged-excluded+taskqueue="+tagExcludedValue].Value())
|
|
assert.EqualValues(t, map[string]string{"taskqueue": tagExcludedValue}, counters["test.hits-tagged-excluded+taskqueue="+tagExcludedValue].Tags())
|
|
|
|
assert.EqualValues(t, float64(-100), gauges["test.temp+location=Mare Imbrium"].Value())
|
|
assert.EqualValues(t, map[string]string{
|
|
"location": "Mare Imbrium",
|
|
}, gauges["test.temp+location=Mare Imbrium"].Tags())
|
|
|
|
assert.EqualValues(t, []time.Duration{
|
|
1248 * time.Millisecond,
|
|
5255 * time.Millisecond,
|
|
}, timers["test.latency+"].Values())
|
|
assert.EqualValues(t, map[string]string{}, timers["test.latency+"].Tags())
|
|
|
|
assert.EqualValues(t, map[float64]int64{
|
|
1024: 0,
|
|
2048: 0,
|
|
math.MaxFloat64: 1,
|
|
}, histograms["test.transmission+"].Values())
|
|
assert.EqualValues(t, map[time.Duration]int64(nil), histograms["test.transmission+"].Durations())
|
|
assert.EqualValues(t, map[string]string{}, histograms["test.transmission+"].Tags())
|
|
|
|
newTaggedHandler := mp.WithTags(NamespaceTag(uuid.New()))
|
|
recordTallyMetrics(newTaggedHandler)
|
|
snap = scope.Snapshot()
|
|
counters = snap.Counters()
|
|
|
|
assert.EqualValues(t, 11, counters["test.hits-tagged+taskqueue=__sticky__"].Value())
|
|
assert.EqualValues(t, map[string]string{"taskqueue": "__sticky__"}, counters["test.hits-tagged+taskqueue=__sticky__"].Tags())
|
|
}
|
|
|
|
func recordTallyMetrics(h Handler) {
|
|
hitsCounter := h.Counter("hits")
|
|
gauge := h.Gauge("temp")
|
|
timer := h.Timer("latency")
|
|
histogram := h.Histogram("transmission", Bytes)
|
|
hitsTaggedCounter := h.Counter("hits-tagged")
|
|
hitsTaggedExcludedCounter := h.Counter("hits-tagged-excluded")
|
|
|
|
hitsCounter.Record(8)
|
|
gauge.Record(-100, StringTag("location", "Mare Imbrium"))
|
|
timer.Record(1248 * time.Millisecond)
|
|
timer.Record(5255 * time.Millisecond)
|
|
histogram.Record(1234567)
|
|
hitsTaggedCounter.Record(11, UnsafeTaskQueueTag("__sticky__"))
|
|
hitsTaggedExcludedCounter.Record(14, UnsafeTaskQueueTag("filtered"))
|
|
}
|