mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
YuriandGitHub
ce2b36e872
## What changed? <!-- Describe what has changed in this PR --> 1. Populate StartTime filed when CurrentWorkflowConditionFailedError error happens 2. Use workflow start time from WorfklowExecutionState/CurrentWorkflowConditionFailedError (so avoid loading mutable state) 3. Add tests to verify that StartTime field in WorfklowExecutionState is populated 4. Refactor some dedup tests. 5. Mark StartTime in ExecutionInfo as deprecated. ## Why? To allow blocking frequent restarts without loading mutable state (and thus without latency increase) ## How did you test it? Add some unit tests, modify existing unit tests. ## Is hotfix candidate? No
60 lines
2.2 KiB
Go
60 lines
2.2 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package sql
|
|
|
|
import (
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
enumsspb "go.temporal.io/server/api/enums/v1"
|
|
p "go.temporal.io/server/common/persistence"
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin"
|
|
)
|
|
|
|
func extractCurrentWorkflowConflictError(
|
|
currentRow *sqlplugin.CurrentExecutionsRow,
|
|
message string,
|
|
) error {
|
|
if currentRow == nil {
|
|
return &p.CurrentWorkflowConditionFailedError{
|
|
Msg: message,
|
|
RequestID: "",
|
|
RunID: "",
|
|
State: enumsspb.WORKFLOW_EXECUTION_STATE_UNSPECIFIED,
|
|
Status: enumspb.WORKFLOW_EXECUTION_STATUS_UNSPECIFIED,
|
|
LastWriteVersion: 0,
|
|
StartTime: nil,
|
|
}
|
|
}
|
|
|
|
return &p.CurrentWorkflowConditionFailedError{
|
|
Msg: message,
|
|
RequestID: currentRow.CreateRequestID,
|
|
RunID: currentRow.RunID.String(),
|
|
State: currentRow.State,
|
|
Status: currentRow.Status,
|
|
LastWriteVersion: currentRow.LastWriteVersion,
|
|
StartTime: currentRow.StartTime,
|
|
}
|
|
}
|