mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Tim Deeb-SwihartandGitHub
be7b5514a5
## What changed? Both our PostgreSQL and MySQL database backends will now automatically reconnect to the database when certain errors occur: all errors chosen have been experienced when testing this behavior through an AWS Aurora RDS failover of either MySQL or PostgreSQL. For both backends we will reconnect when we see: - `ECONNRESET` - `ECONNABORTED` - `ECONNREFUSED` - `io.EOF` - `io.ErrUnexpectedEOF` - `database/sql/driver.ErrBadConn` for postgres we will also reconnect on the following SQLStates: - `25006` read-only transaction - `57P03` cannot connect now - `0A000` feature not supported, but ONLY when the message is `cannot set transaction read-write mode during recovery` for mysql we will also reconnect when we see the following error codes: - `1040` too many connections - `1792` read-only transaction (SQLstate `25006`) - `1836` running in read-only mode This logic is easily extensible should we discover more failure modes over time ## Why? We've had multiple community reports of Temporal problems during RDS failover. One part of this is the fact that we wouldn't necessarily reconnect; we were at the whims of our chosen SQL abstraction's connection pooling logic. ## How did you test it? I manually tested this functionality in the presence of repeated RDS failovers: - [x] postgres12 plugin with pq driver - [x] postgres12 plugin with pgx driver - [x] mysql plugin Automated testing will be added to our regular testing pipelines once our infrastructure friends have added the support I need (it's in progress) ## Potential risks We're concerned there's a correctness issue in our PostgreSQL backend that's related to our behavior during an RDS failover. If we merge this before I figure out what's going on, we could hide the issue and make it harder to reproduce. ## Documentation N/A ## Is hotfix candidate? Yes?
115 lines
3.8 KiB
Go
115 lines
3.8 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package mysql
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin"
|
|
)
|
|
|
|
const (
|
|
createEndpointsTableVersionQry = `INSERT INTO nexus_endpoints_partition_status(version) VALUES(1)`
|
|
incrementEndpointsTableVersionQry = `UPDATE nexus_endpoints_partition_status SET version = ? WHERE version = ?`
|
|
getEndpointsTableVersionQry = `SELECT version FROM nexus_endpoints_partition_status`
|
|
|
|
createEndpointQry = `INSERT INTO nexus_endpoints(id, data, data_encoding, version) VALUES (?, ?, ?, 1)`
|
|
updateEndpointQry = `UPDATE nexus_endpoints SET data = ?, data_encoding = ?, version = ? WHERE id = ? AND version = ?`
|
|
deleteEndpointQry = `DELETE FROM nexus_endpoints WHERE id = ?`
|
|
getEndpointByIdQry = `SELECT id, data, data_encoding, version FROM nexus_endpoints WHERE id = ?`
|
|
getEndpointsQry = `SELECT id, data, data_encoding, version FROM nexus_endpoints WHERE id > ? LIMIT ?`
|
|
)
|
|
|
|
func (mdb *db) InitializeNexusEndpointsTableVersion(ctx context.Context) (sql.Result, error) {
|
|
return mdb.ExecContext(ctx, createEndpointsTableVersionQry)
|
|
}
|
|
|
|
func (mdb *db) IncrementNexusEndpointsTableVersion(
|
|
ctx context.Context,
|
|
lastKnownTableVersion int64,
|
|
) (sql.Result, error) {
|
|
return mdb.ExecContext(ctx, incrementEndpointsTableVersionQry, lastKnownTableVersion+1, lastKnownTableVersion)
|
|
}
|
|
|
|
func (mdb *db) GetNexusEndpointsTableVersion(ctx context.Context) (int64, error) {
|
|
var version int64
|
|
err := mdb.GetContext(ctx, &version, getEndpointsTableVersionQry)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return 0, nil
|
|
}
|
|
return version, err
|
|
}
|
|
|
|
func (mdb *db) InsertIntoNexusEndpoints(
|
|
ctx context.Context,
|
|
row *sqlplugin.NexusEndpointsRow,
|
|
) (sql.Result, error) {
|
|
return mdb.ExecContext(
|
|
ctx,
|
|
createEndpointQry,
|
|
row.ID,
|
|
row.Data,
|
|
row.DataEncoding)
|
|
}
|
|
|
|
func (mdb *db) UpdateNexusEndpoint(
|
|
ctx context.Context,
|
|
row *sqlplugin.NexusEndpointsRow,
|
|
) (sql.Result, error) {
|
|
return mdb.ExecContext(
|
|
ctx,
|
|
updateEndpointQry,
|
|
row.Data,
|
|
row.DataEncoding,
|
|
row.Version+1,
|
|
row.ID,
|
|
row.Version)
|
|
}
|
|
|
|
func (mdb *db) DeleteFromNexusEndpoints(
|
|
ctx context.Context,
|
|
id []byte,
|
|
) (sql.Result, error) {
|
|
return mdb.ExecContext(ctx, deleteEndpointQry, id)
|
|
}
|
|
|
|
func (mdb *db) GetNexusEndpointByID(
|
|
ctx context.Context,
|
|
id []byte,
|
|
) (*sqlplugin.NexusEndpointsRow, error) {
|
|
var row sqlplugin.NexusEndpointsRow
|
|
err := mdb.GetContext(ctx, &row, getEndpointByIdQry, id)
|
|
return &row, err
|
|
}
|
|
|
|
func (mdb *db) ListNexusEndpoints(
|
|
ctx context.Context,
|
|
request *sqlplugin.ListNexusEndpointsRequest,
|
|
) ([]sqlplugin.NexusEndpointsRow, error) {
|
|
var rows []sqlplugin.NexusEndpointsRow
|
|
err := mdb.SelectContext(ctx, &rows, getEndpointsQry, request.LastID, request.Limit)
|
|
return rows, err
|
|
}
|