Files
tasks/common/persistence/visibility/visibility_manager_dual.go
Hazel KimandGitHub c6bebde733 enabled shadow read for secondary visibility store (#5976)
## What changed?
<!-- Describe what has changed in this PR -->
- added EnableShadowReadMode config (default to false)
- if shadow read mode is enabled, perform shadow read from the secondary
visibility store for visibility read requests

## Why?
<!-- Tell your future self why have you made these changes -->
- to measure latency metrics from both visibility stores

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- tested locally, and verified that visibility read requests from both
visibility stores are getting reasonably same latencies

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-05-23 18:45:58 -04:00

259 lines
7.5 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package visibility
import (
"context"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence/visibility/manager"
)
type (
VisibilityManagerDual struct {
visibilityManager manager.VisibilityManager
secondaryVisibilityManager manager.VisibilityManager
managerSelector managerSelector
enableShadowReadMode dynamicconfig.BoolPropertyFn
}
)
var _ manager.VisibilityManager = (*VisibilityManagerDual)(nil)
// NewVisibilityManagerDual create a visibility manager that operate on multiple manager
// implementations based on dynamic config.
func NewVisibilityManagerDual(
visibilityManager manager.VisibilityManager,
secondaryVisibilityManager manager.VisibilityManager,
managerSelector managerSelector,
enableShadowReadMode dynamicconfig.BoolPropertyFn,
) *VisibilityManagerDual {
return &VisibilityManagerDual{
visibilityManager: visibilityManager,
secondaryVisibilityManager: secondaryVisibilityManager,
managerSelector: managerSelector,
enableShadowReadMode: enableShadowReadMode,
}
}
func (v *VisibilityManagerDual) GetPrimaryVisibility() manager.VisibilityManager {
return v.visibilityManager
}
func (v *VisibilityManagerDual) GetSecondaryVisibility() manager.VisibilityManager {
return v.secondaryVisibilityManager
}
func (v *VisibilityManagerDual) Close() {
v.visibilityManager.Close()
v.secondaryVisibilityManager.Close()
}
func (v *VisibilityManagerDual) GetReadStoreName(nsName namespace.Name) string {
return v.managerSelector.readManager(nsName).GetReadStoreName(nsName)
}
func (v *VisibilityManagerDual) GetStoreNames() []string {
return append(v.visibilityManager.GetStoreNames(), v.secondaryVisibilityManager.GetStoreNames()...)
}
func (v *VisibilityManagerDual) HasStoreName(stName string) bool {
for _, sn := range v.GetStoreNames() {
if sn == stName {
return true
}
}
return false
}
func (v *VisibilityManagerDual) GetIndexName() string {
return v.visibilityManager.GetIndexName()
}
func (v *VisibilityManagerDual) ValidateCustomSearchAttributes(
searchAttributes map[string]any,
) (map[string]any, error) {
ms, err := v.managerSelector.writeManagers()
if err != nil {
return nil, err
}
for _, m := range ms {
searchAttributes, err = m.ValidateCustomSearchAttributes(searchAttributes)
if err != nil {
return nil, err
}
}
return searchAttributes, nil
}
func (v *VisibilityManagerDual) RecordWorkflowExecutionStarted(
ctx context.Context,
request *manager.RecordWorkflowExecutionStartedRequest,
) error {
ms, err := v.managerSelector.writeManagers()
if err != nil {
return err
}
for _, m := range ms {
err = m.RecordWorkflowExecutionStarted(ctx, request)
if err != nil {
return err
}
}
return nil
}
func (v *VisibilityManagerDual) RecordWorkflowExecutionClosed(
ctx context.Context,
request *manager.RecordWorkflowExecutionClosedRequest,
) error {
ms, err := v.managerSelector.writeManagers()
if err != nil {
return err
}
for _, m := range ms {
err = m.RecordWorkflowExecutionClosed(ctx, request)
if err != nil {
return err
}
}
return nil
}
func (v *VisibilityManagerDual) UpsertWorkflowExecution(
ctx context.Context,
request *manager.UpsertWorkflowExecutionRequest,
) error {
ms, err := v.managerSelector.writeManagers()
if err != nil {
return err
}
for _, m := range ms {
err = m.UpsertWorkflowExecution(ctx, request)
if err != nil {
return err
}
}
return nil
}
func (v *VisibilityManagerDual) DeleteWorkflowExecution(
ctx context.Context,
request *manager.VisibilityDeleteWorkflowExecutionRequest,
) error {
ms, err := v.managerSelector.writeManagers()
if err != nil {
return err
}
for _, m := range ms {
err = m.DeleteWorkflowExecution(ctx, request)
if err != nil {
return err
}
}
return nil
}
func (v *VisibilityManagerDual) ListWorkflowExecutions(
ctx context.Context,
request *manager.ListWorkflowExecutionsRequestV2,
) (*manager.ListWorkflowExecutionsResponse, error) {
if v.enableShadowReadMode() {
ms, err := v.managerSelector.readManagers(request.Namespace)
if err != nil {
return nil, err
}
//nolint:errcheck // ignore error since it's shadow request
go ms[1].ListWorkflowExecutions(ctx, request)
res, err := ms[0].ListWorkflowExecutions(ctx, request)
if err != nil {
return nil, err
}
return res, err
}
return v.managerSelector.readManager(request.Namespace).ListWorkflowExecutions(ctx, request)
}
func (v *VisibilityManagerDual) ScanWorkflowExecutions(
ctx context.Context,
request *manager.ListWorkflowExecutionsRequestV2,
) (*manager.ListWorkflowExecutionsResponse, error) {
if v.enableShadowReadMode() {
ms, err := v.managerSelector.readManagers(request.Namespace)
if err != nil {
return nil, err
}
//nolint:errcheck // ignore error since it's shadow request
go ms[1].ScanWorkflowExecutions(ctx, request)
res, err := ms[0].ScanWorkflowExecutions(ctx, request)
if err != nil {
return nil, err
}
return res, err
}
return v.managerSelector.readManager(request.Namespace).ScanWorkflowExecutions(ctx, request)
}
func (v *VisibilityManagerDual) CountWorkflowExecutions(
ctx context.Context,
request *manager.CountWorkflowExecutionsRequest,
) (*manager.CountWorkflowExecutionsResponse, error) {
if v.enableShadowReadMode() {
ms, err := v.managerSelector.readManagers(request.Namespace)
if err != nil {
return nil, err
}
//nolint:errcheck // ignore error since it's shadow request
go ms[1].CountWorkflowExecutions(ctx, request)
res, err := ms[0].CountWorkflowExecutions(ctx, request)
if err != nil {
return nil, err
}
return res, err
}
return v.managerSelector.readManager(request.Namespace).CountWorkflowExecutions(ctx, request)
}
func (v *VisibilityManagerDual) GetWorkflowExecution(
ctx context.Context,
request *manager.GetWorkflowExecutionRequest,
) (*manager.GetWorkflowExecutionResponse, error) {
if v.enableShadowReadMode() {
ms, err := v.managerSelector.readManagers(request.Namespace)
if err != nil {
return nil, err
}
//nolint:errcheck // ignore error since it's shadow request
go ms[1].GetWorkflowExecution(ctx, request)
res, err := ms[0].GetWorkflowExecution(ctx, request)
if err != nil {
return nil, err
}
return res, err
}
return v.managerSelector.readManager(request.Namespace).GetWorkflowExecution(ctx, request)
}