Files
tasks/common/quotas/rate_limiter_impl.go
4ba82252da Recycle task tokens for invalid matching tasks (#6599)
## What changed?
Add a `RecycleToken` function to our custom rate limiters. It seems that
most of the rate limiters just wrap the `ClockedRateLimiter`, so let the
`ClockedRateLimiter`'s `WaitN` function unblock the waiter if recycle is
called, thus allowing us to recycle tokens and give them to any waiters
if they exist.

## Why?
Lots of invalid tasks combined with Activity task dispatch rate limiting
can cause the actual rate to be noticeably below the maximum rate. This
will make the actual rate match the max rps, as long as
`time_to_recycle` is reasonably short and `recycle_rate` is reasonable
(see discussion in the comments)

## How did you test it?
ClockedRateLimiter unit test.

## Potential risks
The max Activity RPS could break.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

---------

Co-authored-by: David Reiss <[email protected]>
2024-10-12 01:46:05 +00:00

140 lines
3.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package quotas
import (
"sync"
"time"
"go.temporal.io/server/common/clock"
"golang.org/x/time/rate"
)
type (
// RateLimiterImpl is a wrapper around the golang rate limiter
RateLimiterImpl struct {
sync.RWMutex
rps float64
burst int
timeSource clock.TimeSource
ClockedRateLimiter
}
)
var _ RateLimiter = (*RateLimiterImpl)(nil)
// NewRateLimiter returns a new rate limiter that can handle dynamic
// configuration updates
func NewRateLimiter(newRPS float64, newBurst int) *RateLimiterImpl {
limiter := rate.NewLimiter(rate.Limit(newRPS), newBurst)
ts := clock.NewRealTimeSource()
rl := &RateLimiterImpl{
rps: newRPS,
burst: newBurst,
timeSource: ts,
ClockedRateLimiter: NewClockedRateLimiter(limiter, ts),
}
return rl
}
// SetRPS sets the rate of the rate limiter
func (rl *RateLimiterImpl) SetRPS(rps float64) {
rl.refreshInternalRateLimiterImpl(&rps, nil)
}
// SetBurst sets the burst of the rate limiter
func (rl *RateLimiterImpl) SetBurst(burst int) {
rl.refreshInternalRateLimiterImpl(nil, &burst)
}
func (rl *RateLimiterImpl) Reserve() Reservation {
return rl.ClockedRateLimiter.Reserve()
}
func (rl *RateLimiterImpl) ReserveN(now time.Time, n int) Reservation {
return rl.ClockedRateLimiter.ReserveN(now, n)
}
// SetRateBurst sets the rps & burst of the rate limiter
func (rl *RateLimiterImpl) SetRateBurst(rps float64, burst int) {
rl.refreshInternalRateLimiterImpl(&rps, &burst)
}
// Rate returns the rps for this rate limiter
func (rl *RateLimiterImpl) Rate() float64 {
rl.Lock()
defer rl.Unlock()
return rl.rps
}
// Burst returns the burst for this rate limiter
func (rl *RateLimiterImpl) Burst() int {
rl.Lock()
defer rl.Unlock()
return rl.burst
}
// TokensAt returns the number of tokens that will be available at time t
func (rl *RateLimiterImpl) TokensAt(t time.Time) int {
rl.Lock()
defer rl.Unlock()
return rl.ClockedRateLimiter.TokensAt(t)
}
func (rl *RateLimiterImpl) refreshInternalRateLimiterImpl(
newRate *float64,
newBurst *int,
) {
rl.Lock()
defer rl.Unlock()
refresh := false
if newRate != nil && rl.rps != *newRate {
rl.rps = *newRate
refresh = true
}
if newBurst != nil && rl.burst != *newBurst {
rl.burst = *newBurst
refresh = true
}
if refresh {
now := rl.timeSource.Now()
rl.SetLimitAt(now, rate.Limit(rl.rps))
rl.SetBurstAt(now, rl.burst)
}
}
// RecycleToken returns a token to the rate limiter
func (rl *RateLimiterImpl) RecycleToken() {
rl.ClockedRateLimiter.RecycleToken()
}