mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Stephan BehnkeandGitHub
44529ec9cb
## What changed? <!-- Describe what has changed in this PR --> **(1)** Adds the following OpenTelemetry (OTEL) span attributes: - `temporalWorkflowID` - `temporalRunID` These are the same OTEL attribute keys the SDKs emit. It makes sense to me to make them the same for consistency. **(2)** Replaces the deprecated approach of OTEL interceptors with `stats.Handler`s **(3)** If there are no exporters, disables the `stats.Handlers` completely. Right now we run through the OTEL processing even if it's disabled. ## Why? <!-- Tell your future self why have you made these changes --> Right now there is no way to query all spans for a workflow together. The newly added span attribute allows to correlate spans that belong to the same workflow execution. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> (1) Added unit tests (2) Manually Using ``` docker run -p 127.0.0.1:4317:4317 -p 127.0.0.1:55679:55679 otel/opentelemetry-collector:0.106.1 2>&1 | tee collector-output.txt ``` it outputs <img width="591" alt="image" src="https://github.com/user-attachments/assets/0a1dfcc3-b3ae-49b7-bd0b-9667e8ef3945"> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> It appears to be **no** breaking change. (ie same OTEL attributes as before) <img width="2011" alt="Screenshot 2024-10-26 at 10 00 41 AM" src="https://github.com/user-attachments/assets/c871eeac-ed7b-428e-9c0a-425c796d8761"> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->