mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? <!-- Describe what has changed in this PR --> **(1)** Adds the following OpenTelemetry (OTEL) span attributes: - `temporalWorkflowID` - `temporalRunID` These are the same OTEL attribute keys the SDKs emit. It makes sense to me to make them the same for consistency. **(2)** Replaces the deprecated approach of OTEL interceptors with `stats.Handler`s **(3)** If there are no exporters, disables the `stats.Handlers` completely. Right now we run through the OTEL processing even if it's disabled. ## Why? <!-- Tell your future self why have you made these changes --> Right now there is no way to query all spans for a workflow together. The newly added span attribute allows to correlate spans that belong to the same workflow execution. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> (1) Added unit tests (2) Manually Using ``` docker run -p 127.0.0.1:4317:4317 -p 127.0.0.1:55679:55679 otel/opentelemetry-collector:0.106.1 2>&1 | tee collector-output.txt ``` it outputs <img width="591" alt="image" src="https://github.com/user-attachments/assets/0a1dfcc3-b3ae-49b7-bd0b-9667e8ef3945"> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> It appears to be **no** breaking change. (ie same OTEL attributes as before) <img width="2011" alt="Screenshot 2024-10-26 at 10 00 41 AM" src="https://github.com/user-attachments/assets/c871eeac-ed7b-428e-9c0a-425c796d8761"> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
178 lines
6.6 KiB
Go
178 lines
6.6 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package service
|
|
|
|
import (
|
|
"sync/atomic"
|
|
|
|
"go.temporal.io/server/common"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/common/membership"
|
|
"go.temporal.io/server/common/metrics"
|
|
persistenceClient "go.temporal.io/server/common/persistence/client"
|
|
"go.temporal.io/server/common/primitives"
|
|
"go.temporal.io/server/common/quotas/calculator"
|
|
"go.temporal.io/server/common/rpc"
|
|
"go.temporal.io/server/common/rpc/interceptor"
|
|
"go.temporal.io/server/common/telemetry"
|
|
"go.uber.org/fx"
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
type (
|
|
PersistenceLazyLoadedServiceResolver struct {
|
|
*atomic.Value // value type is membership.ServiceResolver
|
|
}
|
|
|
|
PersistenceRateLimitingParams struct {
|
|
fx.Out
|
|
|
|
PersistenceMaxQps persistenceClient.PersistenceMaxQps
|
|
PersistenceNamespaceMaxQps persistenceClient.PersistenceNamespaceMaxQps
|
|
PersistencePerShardNamespaceMaxQPS persistenceClient.PersistencePerShardNamespaceMaxQPS
|
|
OperatorRPSRatio persistenceClient.OperatorRPSRatio
|
|
PersistenceBurstRatio persistenceClient.PersistenceBurstRatio
|
|
DynamicRateLimitingParams persistenceClient.DynamicRateLimitingParams
|
|
}
|
|
|
|
GrpcServerOptionsParams struct {
|
|
fx.In
|
|
|
|
Logger log.Logger
|
|
RpcFactory common.RPCFactory
|
|
RetryableInterceptor *interceptor.RetryableInterceptor
|
|
TelemetryInterceptor *interceptor.TelemetryInterceptor
|
|
RateLimitInterceptor *interceptor.RateLimitInterceptor
|
|
TracingStatsHandler telemetry.ServerStatsHandler
|
|
AdditionalInterceptors []grpc.UnaryServerInterceptor `optional:"true"`
|
|
}
|
|
)
|
|
|
|
var PersistenceLazyLoadedServiceResolverModule = fx.Options(
|
|
fx.Provide(func() PersistenceLazyLoadedServiceResolver {
|
|
return PersistenceLazyLoadedServiceResolver{
|
|
Value: &atomic.Value{},
|
|
}
|
|
}),
|
|
fx.Invoke(initPersistenceLazyLoadedServiceResolver),
|
|
)
|
|
|
|
func initPersistenceLazyLoadedServiceResolver(
|
|
serviceName primitives.ServiceName,
|
|
logger log.SnTaggedLogger,
|
|
serviceResolver membership.ServiceResolver,
|
|
lazyLoadedServiceResolver PersistenceLazyLoadedServiceResolver,
|
|
) {
|
|
lazyLoadedServiceResolver.Store(serviceResolver)
|
|
logger.Info("Initialized service resolver for persistence rate limiting", tag.Service(serviceName))
|
|
}
|
|
|
|
func (p PersistenceLazyLoadedServiceResolver) AvailableMemberCount() int {
|
|
if value := p.Load(); value != nil {
|
|
return value.(membership.ServiceResolver).AvailableMemberCount()
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func NewPersistenceRateLimitingParams(
|
|
maxQps dynamicconfig.IntPropertyFn,
|
|
globalMaxQps dynamicconfig.IntPropertyFn,
|
|
namespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
|
|
globalNamespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
|
|
perShardNamespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
|
|
operatorRPSRatio dynamicconfig.FloatPropertyFn,
|
|
burstRatio dynamicconfig.FloatPropertyFn,
|
|
dynamicRateLimitingParams dynamicconfig.TypedPropertyFn[dynamicconfig.DynamicRateLimitingParams],
|
|
lazyLoadedServiceResolver PersistenceLazyLoadedServiceResolver,
|
|
logger log.Logger,
|
|
) PersistenceRateLimitingParams {
|
|
hostCalculator := calculator.NewLoggedCalculator(
|
|
calculator.ClusterAwareQuotaCalculator{
|
|
MemberCounter: lazyLoadedServiceResolver,
|
|
PerInstanceQuota: maxQps,
|
|
GlobalQuota: globalMaxQps,
|
|
},
|
|
log.With(logger, tag.ComponentPersistence, tag.ScopeHost),
|
|
)
|
|
namespaceCalculator := calculator.NewLoggedNamespaceCalculator(
|
|
calculator.ClusterAwareNamespaceQuotaCalculator{
|
|
MemberCounter: lazyLoadedServiceResolver,
|
|
PerInstanceQuota: namespaceMaxQps,
|
|
GlobalQuota: globalNamespaceMaxQps,
|
|
},
|
|
log.With(logger, tag.ComponentPersistence, tag.ScopeNamespace),
|
|
)
|
|
return PersistenceRateLimitingParams{
|
|
PersistenceMaxQps: func() int {
|
|
return int(hostCalculator.GetQuota())
|
|
},
|
|
PersistenceNamespaceMaxQps: func(namespace string) int {
|
|
return int(namespaceCalculator.GetQuota(namespace))
|
|
},
|
|
PersistencePerShardNamespaceMaxQPS: persistenceClient.PersistencePerShardNamespaceMaxQPS(perShardNamespaceMaxQps),
|
|
OperatorRPSRatio: persistenceClient.OperatorRPSRatio(operatorRPSRatio),
|
|
PersistenceBurstRatio: persistenceClient.PersistenceBurstRatio(burstRatio),
|
|
DynamicRateLimitingParams: persistenceClient.DynamicRateLimitingParams(dynamicRateLimitingParams),
|
|
}
|
|
}
|
|
|
|
func GrpcServerOptionsProvider(
|
|
params GrpcServerOptionsParams,
|
|
) []grpc.ServerOption {
|
|
|
|
grpcServerOptions, err := params.RpcFactory.GetInternodeGRPCServerOptions()
|
|
if err != nil {
|
|
params.Logger.Fatal("creating gRPC server options failed", tag.Error(err))
|
|
}
|
|
|
|
if params.TracingStatsHandler != nil {
|
|
grpcServerOptions = append(grpcServerOptions, grpc.StatsHandler(params.TracingStatsHandler))
|
|
}
|
|
|
|
return append(
|
|
grpcServerOptions,
|
|
grpc.ChainUnaryInterceptor(getUnaryInterceptors(params)...),
|
|
grpc.ChainStreamInterceptor(params.TelemetryInterceptor.StreamIntercept),
|
|
)
|
|
}
|
|
|
|
func getUnaryInterceptors(params GrpcServerOptionsParams) []grpc.UnaryServerInterceptor {
|
|
interceptors := []grpc.UnaryServerInterceptor{
|
|
rpc.ServiceErrorInterceptor,
|
|
metrics.NewServerMetricsContextInjectorInterceptor(),
|
|
metrics.NewServerMetricsTrailerPropagatorInterceptor(params.Logger),
|
|
params.TelemetryInterceptor.UnaryIntercept,
|
|
}
|
|
|
|
interceptors = append(interceptors, params.AdditionalInterceptors...)
|
|
|
|
return append(
|
|
interceptors,
|
|
params.RateLimitInterceptor.Intercept,
|
|
params.RetryableInterceptor.Intercept)
|
|
}
|