Files
Yichao YangandGitHub 98088dde5d Fix force delete workflow warning message (#6688)
## What changed?
<!-- Describe what has changed in this PR -->
- Fix force delete workflow warning message
- Remove unused function

## Why?
<!-- Tell your future self why have you made these changes -->
- Vis record will always be deleted after standard visibility is
deprecated

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-10-22 11:48:40 -07:00

146 lines
5.2 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package forcedeleteworkflowexecution
import (
"context"
"fmt"
"math"
"go.temporal.io/server/api/adminservice/v1"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/common"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/visibility/manager"
)
func Invoke(
ctx context.Context,
request *historyservice.ForceDeleteWorkflowExecutionRequest,
shardID int32,
persistenceExecutionMgr persistence.ExecutionManager,
persistenceVisibilityMgr manager.VisibilityManager,
logger log.Logger,
) (_ *historyservice.ForceDeleteWorkflowExecutionResponse, retError error) {
req := request.Request
execution := req.Execution
logger = log.With(logger,
tag.WorkflowNamespaceID(request.NamespaceId),
tag.WorkflowID(execution.WorkflowId),
tag.WorkflowRunID(execution.RunId),
)
if execution.RunId == "" {
resp, err := persistenceExecutionMgr.GetCurrentExecution(ctx, &persistence.GetCurrentExecutionRequest{
ShardID: shardID,
NamespaceID: request.NamespaceId,
WorkflowID: execution.WorkflowId,
})
if err != nil {
return nil, err
}
execution.RunId = resp.RunID
}
var warnings []string
var branchTokens [][]byte
resp, err := persistenceExecutionMgr.GetWorkflowExecution(ctx, &persistence.GetWorkflowExecutionRequest{
ShardID: shardID,
NamespaceID: request.NamespaceId,
WorkflowID: execution.WorkflowId,
RunID: execution.RunId,
})
if err != nil {
if common.IsContextCanceledErr(err) || common.IsContextDeadlineExceededErr(err) {
return nil, err
}
// continue to deletion
warnMsg := "Unable to load mutable state. Skipping workflow history deletion."
logger.Warn(warnMsg, tag.Error(err))
warnings = append(warnings, fmt.Sprintf("%s. Error: %v", warnMsg, err.Error()))
} else {
// load necessary information from mutable state
executionInfo := resp.State.GetExecutionInfo()
histories := executionInfo.GetVersionHistories().GetHistories()
branchTokens = make([][]byte, 0, len(histories))
for _, historyItem := range histories {
branchTokens = append(branchTokens, historyItem.GetBranchToken())
}
}
// NOTE: the deletion is best effort, for sql visibility implementation,
// we can't guarantee there's no update or record close request for this workflow since
// visibility queue processing is async. Operator can call this api again to delete visibility
// record again if this happens.
if err := persistenceVisibilityMgr.DeleteWorkflowExecution(ctx, &manager.VisibilityDeleteWorkflowExecutionRequest{
NamespaceID: namespace.ID(request.GetNamespaceId()),
WorkflowID: execution.GetWorkflowId(),
RunID: execution.GetRunId(),
TaskID: math.MaxInt64,
}); err != nil {
return nil, err
}
if err := persistenceExecutionMgr.DeleteCurrentWorkflowExecution(ctx, &persistence.DeleteCurrentWorkflowExecutionRequest{
ShardID: shardID,
NamespaceID: request.NamespaceId,
WorkflowID: execution.WorkflowId,
RunID: execution.RunId,
}); err != nil {
return nil, err
}
if err := persistenceExecutionMgr.DeleteWorkflowExecution(ctx, &persistence.DeleteWorkflowExecutionRequest{
ShardID: shardID,
NamespaceID: request.NamespaceId,
WorkflowID: execution.WorkflowId,
RunID: execution.RunId,
}); err != nil {
return nil, err
}
for _, branchToken := range branchTokens {
if err := persistenceExecutionMgr.DeleteHistoryBranch(ctx, &persistence.DeleteHistoryBranchRequest{
ShardID: shardID,
BranchToken: branchToken,
}); err != nil {
warnMsg := "Failed to delete history branch, skip"
logger.Warn(warnMsg, tag.WorkflowBranchID(string(branchToken)), tag.Error(err))
warnings = append(warnings, fmt.Sprintf("%s. BranchToken: %v, Error: %v", warnMsg, branchToken, err.Error()))
}
}
return &historyservice.ForceDeleteWorkflowExecutionResponse{
Response: &adminservice.DeleteWorkflowExecutionResponse{
Warnings: warnings,
},
}, nil
}