Files
Stephan BehnkeandGitHub 9dc2ca1904 Remove ms parameter from UpdateRegistry (#6861)
## What changed?
<!-- Describe what has changed in this PR -->

Removes the `fallbackMutableState` from the workflow context's
`UpdateRegistry` method.

## Why?
<!-- Tell your future self why have you made these changes -->

Not needed anymore. Once
https://github.com/temporalio/temporal/pull/6858 is merged, the
MutableState should always be present in the workflow context.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

Existing tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-11-22 10:48:39 -08:00

207 lines
6.6 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package reapplyevents
import (
"context"
"github.com/google/uuid"
historypb "go.temporal.io/api/history/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence/versionhistory"
"go.temporal.io/server/service/history/api"
"go.temporal.io/server/service/history/ndc"
"go.temporal.io/server/service/history/shard"
wcache "go.temporal.io/server/service/history/workflow/cache"
)
func Invoke(
ctx context.Context,
namespaceUUID namespace.ID,
workflowID string,
runID string,
reapplyEvents []*historypb.HistoryEvent,
shard shard.Context,
workflowConsistencyChecker api.WorkflowConsistencyChecker,
workflowResetter ndc.WorkflowResetter,
eventsReapplier ndc.EventsReapplier,
) error {
if shard.GetConfig().SkipReapplicationByNamespaceID(namespaceUUID.String()) {
return nil
}
namespaceEntry, err := api.GetActiveNamespace(shard, namespace.ID(namespaceUUID.String()))
if err != nil {
return err
}
namespaceID := namespaceEntry.ID()
isGlobalNamespace := namespaceEntry.IsGlobalNamespace()
return api.GetAndUpdateWorkflowWithNew(
ctx,
nil,
definition.NewWorkflowKey(
namespaceID.String(),
workflowID,
"",
),
func(workflowLease api.WorkflowLease) (*api.UpdateWorkflowAction, error) {
context := workflowLease.GetContext()
mutableState := workflowLease.GetMutableState()
// Filter out reapply event from the same cluster
toReapplyEvents := make([]*historypb.HistoryEvent, 0, len(reapplyEvents))
clusterMetadata := shard.GetClusterMetadata()
currentCluster := clusterMetadata.GetCurrentClusterName()
for _, event := range reapplyEvents {
if clusterMetadata.ClusterNameForFailoverVersion(
isGlobalNamespace,
event.GetVersion(),
) == currentCluster {
// The reapply is from the same cluster. Ignoring.
continue
}
dedupResource := definition.NewEventReappliedID(runID, event.GetEventId(), event.GetVersion())
if mutableState.IsResourceDuplicated(dedupResource) {
// already apply the signal
continue
}
toReapplyEvents = append(toReapplyEvents, event)
}
if len(toReapplyEvents) == 0 {
return &api.UpdateWorkflowAction{
Noop: true,
CreateWorkflowTask: false,
}, nil
}
if !mutableState.IsWorkflowExecutionRunning() {
// need to reset target workflow (which is also the current workflow)
// to accept events to be reapplied
baseRunID := mutableState.GetExecutionState().GetRunId()
resetRunID := uuid.New()
baseRebuildLastEventID := mutableState.GetLastCompletedWorkflowTaskStartedEventId()
// TODO when https://github.com/uber/cadence/issues/2420 is finished, remove this block,
// since cannot reapply event to a finished workflow which had no workflow tasks started
if baseRebuildLastEventID == common.EmptyEventID {
shard.GetLogger().Warn("cannot reapply event to a finished workflow with no workflow task",
tag.WorkflowNamespaceID(namespaceID.String()),
tag.WorkflowID(workflowID),
)
metrics.EventReapplySkippedCount.With(shard.GetMetricsHandler()).Record(
1,
metrics.OperationTag(metrics.HistoryReapplyEventsScope))
return &api.UpdateWorkflowAction{
Noop: true,
CreateWorkflowTask: false,
}, nil
}
baseVersionHistories := mutableState.GetExecutionInfo().GetVersionHistories()
baseCurrentVersionHistory, err := versionhistory.GetCurrentVersionHistory(baseVersionHistories)
if err != nil {
return nil, err
}
baseRebuildLastEventVersion, err := versionhistory.GetVersionHistoryEventVersion(baseCurrentVersionHistory, baseRebuildLastEventID)
if err != nil {
return nil, err
}
baseCurrentBranchToken := baseCurrentVersionHistory.GetBranchToken()
baseNextEventID := mutableState.GetNextEventID()
baseWorkflow := ndc.NewWorkflow(
shard.GetClusterMetadata(),
context,
mutableState,
wcache.NoopReleaseFn,
)
err = workflowResetter.ResetWorkflow(
ctx,
namespaceID,
workflowID,
baseRunID,
baseCurrentBranchToken,
baseRebuildLastEventID,
baseRebuildLastEventVersion,
baseNextEventID,
resetRunID.String(),
uuid.New().String(),
baseWorkflow,
baseWorkflow,
ndc.EventsReapplicationResetWorkflowReason,
toReapplyEvents,
nil,
)
switch err.(type) {
case *serviceerror.InvalidArgument:
// no-op. Usually this is due to reset workflow with pending child workflows
shard.GetLogger().Warn("Cannot reset workflow. Ignoring reapply events.", tag.Error(err))
case nil:
// no-op
default:
return nil, err
}
return &api.UpdateWorkflowAction{
Noop: true,
CreateWorkflowTask: false,
}, nil
}
reappliedEvents, err := eventsReapplier.ReapplyEvents(
ctx,
mutableState,
context.UpdateRegistry(ctx),
toReapplyEvents,
runID,
)
if err != nil {
shard.GetLogger().Error("failed to re-apply stale events", tag.Error(err))
return nil, err
}
if len(reappliedEvents) == 0 {
return &api.UpdateWorkflowAction{
Noop: true,
CreateWorkflowTask: false,
}, nil
}
return &api.UpdateWorkflowAction{
Noop: false,
CreateWorkflowTask: false,
}, nil
},
nil,
shard,
workflowConsistencyChecker,
)
}