mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Alex ShtinandGitHub
99e3dababf
## What changed? <!-- Describe what has changed in this PR --> Remove `SkipGenerateWorkflowTask` flag from signal APIs request. Some sort of revert of #4091. ## Why? <!-- Tell your future self why have you made these changes --> This flag breaks important system invariant: Workflow history must end with Workflow Task event OR event that is no-op for SDK (such as `ActivityScheduled` or `TimerStarted`). This invariant will be leverage at #6709 where server must guarantee that it won't ship actual (non command) events to the worker twice. PR to remove flag from APIs: https://github.com/temporalio/api/pull/476. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Existing tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> Although this flag is not exposed by any SDK and not documented, there is a chance that someone use it in production scenarios. For them it will be a breaking change. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> Not documented. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.