Files
tasks/service/history/api/update_workflow_util.go
Stephan BehnkeandGitHub 9dc2ca1904 Remove ms parameter from UpdateRegistry (#6861)
## What changed?
<!-- Describe what has changed in this PR -->

Removes the `fallbackMutableState` from the workflow context's
`UpdateRegistry` method.

## Why?
<!-- Tell your future self why have you made these changes -->

Not needed anymore. Once
https://github.com/temporalio/temporal/pull/6858 is merged, the
MutableState should always be present in the workflow context.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

Existing tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-11-22 10:48:39 -08:00

151 lines
4.4 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package api
import (
"context"
clockspb "go.temporal.io/server/api/clock/v1"
enumsspb "go.temporal.io/server/api/enums/v1"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/locks"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/workflow"
"go.temporal.io/server/service/history/workflow/update"
)
func GetAndUpdateWorkflowWithNew(
ctx context.Context,
reqClock *clockspb.VectorClock,
workflowKey definition.WorkflowKey,
action UpdateWorkflowActionFunc,
newWorkflowFn func() (workflow.Context, workflow.MutableState, error),
shard shard.Context,
workflowConsistencyChecker WorkflowConsistencyChecker,
) (retError error) {
workflowLease, err := workflowConsistencyChecker.GetWorkflowLease(
ctx,
reqClock,
workflowKey,
locks.PriorityHigh,
)
if err != nil {
return err
}
defer func() { workflowLease.GetReleaseFn()(retError) }()
return UpdateWorkflowWithNew(shard, ctx, workflowLease, action, newWorkflowFn)
}
func GetAndUpdateWorkflowWithConsistencyCheck(
ctx context.Context,
reqClock *clockspb.VectorClock,
consistencyCheckFn MutableStateConsistencyPredicate,
workflowKey definition.WorkflowKey,
action UpdateWorkflowActionFunc,
newWorkflowFn func() (workflow.Context, workflow.MutableState, error),
shardContext shard.Context,
workflowConsistencyChecker WorkflowConsistencyChecker,
) (retError error) {
workflowLease, err := workflowConsistencyChecker.GetWorkflowLeaseWithConsistencyCheck(
ctx,
reqClock,
consistencyCheckFn,
workflowKey,
locks.PriorityHigh,
)
if err != nil {
return err
}
defer func() { workflowLease.GetReleaseFn()(retError) }()
return UpdateWorkflowWithNew(shardContext, ctx, workflowLease, action, newWorkflowFn)
}
func UpdateWorkflowWithNew(
shardContext shard.Context,
ctx context.Context,
workflowLease WorkflowLease,
action UpdateWorkflowActionFunc,
newWorkflowFn func() (workflow.Context, workflow.MutableState, error),
) (retError error) {
// conduct caller action
postActions, err := action(workflowLease)
if err != nil {
return err
}
if postActions.Noop {
return nil
}
mutableState := workflowLease.GetMutableState()
if postActions.CreateWorkflowTask {
// Create a transfer task to schedule a workflow task
if !mutableState.HasPendingWorkflowTask() {
if _, err := mutableState.AddWorkflowTaskScheduledEvent(
false,
enumsspb.WORKFLOW_TASK_TYPE_NORMAL,
); err != nil {
return err
}
}
}
var updateErr error
if newWorkflowFn != nil {
newContext, newMutableState, err := newWorkflowFn()
if err != nil {
return err
}
lastWriteVersion, err := mutableState.GetLastWriteVersion()
if err != nil {
return err
}
if err = NewWorkflowVersionCheck(shardContext, lastWriteVersion, newMutableState); err != nil {
return err
}
updateErr = workflowLease.GetContext().UpdateWorkflowExecutionWithNewAsActive(
ctx,
shardContext,
newContext,
newMutableState,
)
} else {
updateErr = workflowLease.GetContext().UpdateWorkflowExecutionAsActive(ctx, shardContext)
}
if updateErr != nil {
return updateErr
}
if postActions.AbortUpdates {
workflowLease.GetContext().UpdateRegistry(ctx).Abort(update.AbortReasonWorkflowCompleted)
}
return nil
}