Files
tasks/service/history/ndc/conflict_resolver.go
Yichao YangandGitHub 050a841f99 Separate version history Add and Switch (#6500)
## What changed?
<!-- Describe what has changed in this PR -->
- Separate util func for version history Add and Switch

## Why?
<!-- Tell your future self why have you made these changes -->
- In state-based replication world, current history version history can
have a smaller version than other history branches. This auto switch
logic will break that and needs to be separated.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Existing unit test

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2024-09-09 21:28:59 +00:00

205 lines
6.6 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//go:generate mockgen -copyright_file ../../../LICENSE -package $GOPACKAGE -source $GOFILE -destination conflict_resolver_mock.go
package ndc
import (
"context"
"github.com/pborman/uuid"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/persistence/versionhistory"
"go.temporal.io/server/common/primitives/timestamp"
"go.temporal.io/server/common/util"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/workflow"
)
type (
ConflictResolver interface {
GetOrRebuildCurrentMutableState(
ctx context.Context,
branchIndex int32,
incomingVersion int64,
) (workflow.MutableState, bool, error)
GetOrRebuildMutableState(
ctx context.Context,
branchIndex int32,
) (workflow.MutableState, bool, error)
}
ConflictResolverImpl struct {
shard shard.Context
stateRebuilder StateRebuilder
context workflow.Context
mutableState workflow.MutableState
logger log.Logger
}
)
var _ ConflictResolver = (*ConflictResolverImpl)(nil)
func NewConflictResolver(
shard shard.Context,
context workflow.Context,
mutableState workflow.MutableState,
logger log.Logger,
) *ConflictResolverImpl {
return &ConflictResolverImpl{
shard: shard,
stateRebuilder: NewStateRebuilder(shard, logger),
context: context,
mutableState: mutableState,
logger: logger,
}
}
func (r *ConflictResolverImpl) GetOrRebuildCurrentMutableState(
ctx context.Context,
branchIndex int32,
incomingVersion int64,
) (workflow.MutableState, bool, error) {
versionHistories := r.mutableState.GetExecutionInfo().GetVersionHistories()
currentVersionHistoryIndex := versionHistories.GetCurrentVersionHistoryIndex()
currentVersionHistory, err := versionhistory.GetVersionHistory(versionHistories, currentVersionHistoryIndex)
if err != nil {
return nil, false, err
}
currentLastItem, err := versionhistory.GetLastVersionHistoryItem(currentVersionHistory)
if err != nil {
return nil, false, err
}
// mutable state does not need Rebuild
if incomingVersion < currentLastItem.GetVersion() {
return r.mutableState, false, nil
}
if incomingVersion == currentLastItem.GetVersion() && branchIndex != currentVersionHistoryIndex {
return nil, false, serviceerror.NewInvalidArgument("ConflictResolver encountered replication task version == current branch last write version")
}
// incomingVersion > currentLastItem.GetVersion()
return r.getOrRebuildMutableStateByIndex(ctx, branchIndex)
}
func (r *ConflictResolverImpl) GetOrRebuildMutableState(
ctx context.Context,
branchIndex int32,
) (workflow.MutableState, bool, error) {
return r.getOrRebuildMutableStateByIndex(ctx, branchIndex)
}
func (r *ConflictResolverImpl) getOrRebuildMutableStateByIndex(
ctx context.Context,
branchIndex int32,
) (workflow.MutableState, bool, error) {
versionHistories := r.mutableState.GetExecutionInfo().GetVersionHistories()
currentVersionHistoryIndex := versionHistories.GetCurrentVersionHistoryIndex()
// replication task to be applied to current branch
if branchIndex == currentVersionHistoryIndex {
return r.mutableState, false, nil
}
// task.getVersion() > currentLastItem
// incoming replication task, after application, will become the current branch
// (because higher version wins), we need to Rebuild the mutable state for that
rebuiltMutableState, err := r.rebuild(ctx, branchIndex, uuid.New())
if err != nil {
return nil, false, err
}
return rebuiltMutableState, true, nil
}
func (r *ConflictResolverImpl) rebuild(
ctx context.Context,
branchIndex int32,
requestID string,
) (workflow.MutableState, error) {
versionHistories := r.mutableState.GetExecutionInfo().GetVersionHistories()
replayVersionHistory, err := versionhistory.GetVersionHistory(versionHistories, branchIndex)
if err != nil {
return nil, err
}
lastItem, err := versionhistory.GetLastVersionHistoryItem(replayVersionHistory)
if err != nil {
return nil, err
}
executionInfo := r.mutableState.GetExecutionInfo()
executionState := r.mutableState.GetExecutionState()
workflowKey := definition.NewWorkflowKey(
executionInfo.NamespaceId,
executionInfo.WorkflowId,
executionState.RunId,
)
historySize := r.mutableState.GetHistorySize()
rebuildMutableState, _, err := r.stateRebuilder.Rebuild(
ctx,
timestamp.TimeValue(executionState.StartTime),
workflowKey,
replayVersionHistory.GetBranchToken(),
lastItem.GetEventId(),
util.Ptr(lastItem.GetVersion()),
workflowKey,
replayVersionHistory.GetBranchToken(),
requestID,
)
if err != nil {
return nil, err
}
// after rebuilt verification
rebuildVersionHistories := rebuildMutableState.GetExecutionInfo().GetVersionHistories()
rebuildVersionHistory, err := versionhistory.GetCurrentVersionHistory(rebuildVersionHistories)
if err != nil {
return nil, err
}
if !rebuildVersionHistory.Equal(replayVersionHistory) {
return nil, serviceerror.NewInternal("ConflictResolver encounter mismatch version history after Rebuild")
}
// set the current branch index to target branch index
if err := versionhistory.SetCurrentVersionHistoryIndex(versionHistories, branchIndex); err != nil {
return nil, err
}
rebuildMutableState.GetExecutionInfo().VersionHistories = versionHistories
rebuildMutableState.AddHistorySize(historySize)
// set the update condition from original mutable state
rebuildMutableState.SetUpdateCondition(r.mutableState.GetUpdateCondition())
r.context.Clear()
return rebuildMutableState, nil
}