mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-03 03:56:04 +00:00
Hai ZhaoandYichao Yang
2cc2bbab24
## What changed? <!-- Describe what has changed in this PR --> Do not reapply cancellation in reset operation. ## Why? <!-- Tell your future self why have you made these changes --> Cancellation should only be reapplied for conflict resolution. For reset, we should not reapply cancel request. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
108 lines
3.4 KiB
Go
108 lines
3.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
//go:generate mockgen -copyright_file ../../../LICENSE -package $GOPACKAGE -source $GOFILE -destination events_reapplier_mock.go
|
|
|
|
package ndc
|
|
|
|
import (
|
|
"context"
|
|
|
|
historypb "go.temporal.io/api/history/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
enumsspb "go.temporal.io/server/api/enums/v1"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/service/history/hsm"
|
|
"go.temporal.io/server/service/history/workflow"
|
|
"go.temporal.io/server/service/history/workflow/update"
|
|
)
|
|
|
|
type (
|
|
EventsReapplier interface {
|
|
ReapplyEvents(
|
|
ctx context.Context,
|
|
ms workflow.MutableState,
|
|
updateRegistry update.Registry,
|
|
historyEvents []*historypb.HistoryEvent,
|
|
runID string,
|
|
) ([]*historypb.HistoryEvent, error)
|
|
}
|
|
|
|
EventsReapplierImpl struct {
|
|
stateMachineRegistry *hsm.Registry
|
|
metricsHandler metrics.Handler
|
|
logger log.Logger
|
|
}
|
|
)
|
|
|
|
func NewEventsReapplier(
|
|
stateMachineRegistry *hsm.Registry,
|
|
metricsHandler metrics.Handler,
|
|
logger log.Logger,
|
|
) *EventsReapplierImpl {
|
|
|
|
return &EventsReapplierImpl{
|
|
stateMachineRegistry: stateMachineRegistry,
|
|
metricsHandler: metricsHandler,
|
|
logger: logger,
|
|
}
|
|
}
|
|
|
|
func (r *EventsReapplierImpl) ReapplyEvents(
|
|
ctx context.Context,
|
|
ms workflow.MutableState,
|
|
updateRegistry update.Registry,
|
|
historyEvents []*historypb.HistoryEvent,
|
|
runID string,
|
|
) ([]*historypb.HistoryEvent, error) {
|
|
// sanity check workflow still running
|
|
if !ms.IsWorkflowExecutionRunning() {
|
|
return nil, serviceerror.NewInternal("unable to reapply events to closed workflow.")
|
|
}
|
|
reappliedEvents, err := reapplyEvents(ctx, ms, updateRegistry, r.stateMachineRegistry, historyEvents, nil, runID, false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(reappliedEvents) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
// After reapply event, checking if we should schedule a workflow task
|
|
if ms.IsWorkflowPendingOnWorkflowTaskBackoff() {
|
|
// Do not create workflow task when the workflow has first workflow task backoff and execution is not started yet
|
|
return reappliedEvents, nil
|
|
}
|
|
|
|
if !ms.HasPendingWorkflowTask() {
|
|
if _, err := ms.AddWorkflowTaskScheduledEvent(
|
|
false,
|
|
enumsspb.WORKFLOW_TASK_TYPE_NORMAL,
|
|
); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
return reappliedEvents, nil
|
|
}
|