mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-03 03:56:04 +00:00
## What changed?
Using the new metricDefinition.With approach.
## Why?
The usage of metrics.Handler could be both redundant and unsafe:
```
handler.Histogram( myHisto.Name(), myHisto.Unit() ).Record(...)
│ │ └───┐
│ │ │
└─────┐ └───────────┐ │
│ │ │
Redundant and Unsafe: 'Histogram' │ │
is specified despite knowing │ │
'myHisto' is a histogram. There's │ │
also a risk if 'myHisto.Name()' │ │
refers to a metric definition that │ │
is not a histogram. │ │
└─── Redundant information
```
And using the new With(Handler) method, there's no need to specify
redundant information.
## How did you test it?
Already exists an ExampleHandler which tests all the new approach
methods.
## Potential risks
People can still use the old approach, because we are keeping
the Handler interface as-is.
## Is hotfix candidate?
No.
172 lines
5.2 KiB
Go
172 lines
5.2 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package shard
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"go.temporal.io/server/common/convert"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/common/membership"
|
|
"go.temporal.io/server/common/metrics"
|
|
serviceerrors "go.temporal.io/server/common/serviceerror"
|
|
"go.temporal.io/server/internal/goro"
|
|
"go.temporal.io/server/service/history/configs"
|
|
)
|
|
|
|
const (
|
|
shardControllerMembershipUpdateListenerName = "ShardController"
|
|
)
|
|
|
|
type (
|
|
// ownership acts as intermediary between membership and the shard controller.
|
|
// Upon receiving membership update events, it calls the controller's
|
|
// acquireShards method, which acquires or closes shards as needed.
|
|
// The controller calls its verifyOwnership method when asked to
|
|
// acquire a shard, to check that membership believes this host should
|
|
// own the shard.
|
|
ownership struct {
|
|
acquireCh chan struct{}
|
|
config *configs.Config
|
|
goros goro.Group
|
|
historyServiceResolver membership.ServiceResolver
|
|
hostInfoProvider membership.HostInfoProvider
|
|
logger log.Logger
|
|
membershipUpdateCh chan *membership.ChangedEvent
|
|
metricsHandler metrics.Handler
|
|
}
|
|
)
|
|
|
|
func newOwnership(
|
|
config *configs.Config,
|
|
historyServiceResolver membership.ServiceResolver,
|
|
hostInfoProvider membership.HostInfoProvider,
|
|
logger log.Logger,
|
|
metricsHandler metrics.Handler,
|
|
) *ownership {
|
|
hostIdentity := hostInfoProvider.HostInfo().Identity()
|
|
logger = log.With(logger, tag.ComponentShardController, tag.Address(hostIdentity))
|
|
return &ownership{
|
|
acquireCh: make(chan struct{}, 1),
|
|
config: config,
|
|
historyServiceResolver: historyServiceResolver,
|
|
hostInfoProvider: hostInfoProvider,
|
|
logger: logger,
|
|
membershipUpdateCh: make(chan *membership.ChangedEvent, 1),
|
|
metricsHandler: metricsHandler,
|
|
}
|
|
}
|
|
|
|
func (o *ownership) start(controller *ControllerImpl) {
|
|
o.goros.Go(func(ctx context.Context) error {
|
|
o.eventLoop(ctx)
|
|
return nil
|
|
})
|
|
|
|
o.goros.Go(func(ctx context.Context) error {
|
|
o.acquireLoop(ctx, controller)
|
|
return nil
|
|
})
|
|
|
|
if err := o.historyServiceResolver.AddListener(
|
|
shardControllerMembershipUpdateListenerName,
|
|
o.membershipUpdateCh,
|
|
); err != nil {
|
|
o.logger.Fatal("Error adding listener", tag.Error(err))
|
|
}
|
|
}
|
|
|
|
func (o *ownership) eventLoop(ctx context.Context) {
|
|
acquireTicker := time.NewTicker(o.config.AcquireShardInterval())
|
|
defer acquireTicker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
case <-acquireTicker.C:
|
|
o.scheduleAcquire()
|
|
case changedEvent := <-o.membershipUpdateCh:
|
|
metrics.MembershipChangedCounter.With(o.metricsHandler).Record(1)
|
|
|
|
o.logger.Info("", tag.ValueRingMembershipChangedEvent,
|
|
tag.NumberProcessed(len(changedEvent.HostsAdded)),
|
|
tag.NumberDeleted(len(changedEvent.HostsRemoved)),
|
|
tag.NumberChanged(len(changedEvent.HostsChanged)),
|
|
)
|
|
|
|
o.scheduleAcquire()
|
|
}
|
|
}
|
|
}
|
|
|
|
func (o *ownership) scheduleAcquire() {
|
|
select {
|
|
case o.acquireCh <- struct{}{}:
|
|
default:
|
|
}
|
|
}
|
|
|
|
func (o *ownership) acquireLoop(ctx context.Context, controller *ControllerImpl) {
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
case <-o.acquireCh:
|
|
controller.acquireShards(ctx)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (o *ownership) stop() {
|
|
if err := o.historyServiceResolver.RemoveListener(
|
|
shardControllerMembershipUpdateListenerName,
|
|
); err != nil {
|
|
o.logger.Error("Error removing membership update listener", tag.Error(err), tag.OperationFailed)
|
|
}
|
|
|
|
o.goros.Cancel()
|
|
o.goros.Wait()
|
|
}
|
|
|
|
// verifyOwnership checks if the shard should be owned by this host's shard
|
|
// controller. If membership lists another host as the owner, it returns a
|
|
// ShardOwnershipLost error with the correct owner.
|
|
func (o *ownership) verifyOwnership(shardID int32) error {
|
|
ownerInfo, err := o.historyServiceResolver.Lookup(convert.Int32ToString(shardID))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
hostInfo := o.hostInfoProvider.HostInfo()
|
|
if ownerInfo.Identity() != hostInfo.Identity() {
|
|
return serviceerrors.NewShardOwnershipLost(ownerInfo.Identity(), hostInfo.GetAddress())
|
|
}
|
|
|
|
return nil
|
|
}
|