mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Alex ShtinandGitHub
32e8496b21
## What changed? <!-- Describe what has changed in this PR --> Delay Update abortion with effects package. ## Why? <!-- Tell your future self why have you made these changes --> To address race condition case when Update is accepted and WF is completed on the same WFT. In this scenario Update result waiters should have similar experience as if Update was failed with error on the same WFT, meaning that even waiters for `Accepted` stage should get Update result (which is abort failure). Previous implementation had race condition and those waiter might get Update failure, or "Update is accepted" response. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Added unit tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No risks. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> Yes, updated. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.
84 lines
2.4 KiB
Go
84 lines
2.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package update
|
|
|
|
import (
|
|
"fmt"
|
|
)
|
|
|
|
type (
|
|
state uint32
|
|
stateSet uint32
|
|
)
|
|
|
|
const (
|
|
stateCreated state = 1 << iota
|
|
stateProvisionallyAdmitted
|
|
stateAdmitted
|
|
stateSent
|
|
stateProvisionallyAccepted
|
|
stateAccepted
|
|
stateProvisionallyCompleted
|
|
stateProvisionallyCompletedAfterAccepted
|
|
stateCompleted
|
|
stateProvisionallyAborted
|
|
stateAborted
|
|
lastState
|
|
)
|
|
|
|
func (s state) String() string {
|
|
switch s {
|
|
case stateCreated:
|
|
return "Created"
|
|
case stateProvisionallyAdmitted:
|
|
return "ProvisionallyAdmitted"
|
|
case stateAdmitted:
|
|
return "Admitted"
|
|
case stateSent:
|
|
return "Sent"
|
|
case stateProvisionallyAccepted:
|
|
return "ProvisionallyAccepted"
|
|
case stateAccepted:
|
|
return "Accepted"
|
|
case stateProvisionallyCompleted:
|
|
return "ProvisionallyCompleted"
|
|
case stateProvisionallyCompletedAfterAccepted:
|
|
return "ProvisionallyCompletedAfterAccepted"
|
|
case stateCompleted:
|
|
return "Completed"
|
|
case stateProvisionallyAborted:
|
|
return "ProvisionallyAborted"
|
|
case stateAborted:
|
|
return "Aborted"
|
|
case lastState:
|
|
return fmt.Sprintf("invalid state %d", s)
|
|
}
|
|
return fmt.Sprintf("unrecognized state %d", s)
|
|
}
|
|
|
|
func (s state) Matches(mask stateSet) bool {
|
|
return uint32(s)&uint32(mask) == uint32(s)
|
|
}
|