mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
deb8ae15ef
## What changed? Building on #6065, this PR introduces the bulk of scheduler logic to the HSM-based prototype. This makes the prototype able to correctly start workflows according to a schedule, but does not yet port the original long-polling logic. The plan is to replace long-polling with HSM-based callbacks in the subsequent PR. HSM also makes most of the side-effects or activities based logic in the original scheduler obsolete. ## Why? #6065 ## How did you test it? Unit tests & Functional Tests ## Potential risks #6065 ## Documentation None ## Is hotfix candidate? No --------- Co-authored-by: Roey Berman <[email protected]>
196 lines
8.0 KiB
Go
196 lines
8.0 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package scheduler
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
)
|
|
|
|
type (
|
|
processBufferSuite struct {
|
|
suite.Suite
|
|
}
|
|
|
|
job struct {
|
|
id int
|
|
policy enumspb.ScheduleOverlapPolicy
|
|
}
|
|
)
|
|
|
|
func (j *job) GetOverlapPolicy() enumspb.ScheduleOverlapPolicy { return j.policy }
|
|
|
|
func jobIds(jobs []*job) (out []int) {
|
|
for _, j := range jobs {
|
|
out = append(out, j.id)
|
|
}
|
|
return
|
|
}
|
|
|
|
func identity[T any](v T) T { return v }
|
|
|
|
func TestProcessBuffer(t *testing.T) {
|
|
suite.Run(t, new(processBufferSuite))
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessBufferEmpty() {
|
|
buffer := []*job{}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessSkipRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_SKIP}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_SKIP}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_SKIP}}
|
|
action := ProcessBuffer(buffer, true, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessSkipNotRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_SKIP}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_SKIP}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_SKIP}}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Equal(3, action.NonOverlappingStart.id)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessBufferOneRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ONE}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ONE}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ONE}}
|
|
action := ProcessBuffer(buffer, true, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Equal([]int{3}, jobIds(action.NewBuffer))
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessBufferOneNotRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ONE}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ONE}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ONE}}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Equal(3, action.NonOverlappingStart.id)
|
|
s.Equal([]int{5}, jobIds(action.NewBuffer))
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessBufferAllRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ALL}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ALL}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ALL}}
|
|
action := ProcessBuffer(buffer, true, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Equal([]int{3, 5, 7}, jobIds(action.NewBuffer))
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessBufferAllNotRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ALL}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ALL}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_BUFFER_ALL}}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Equal(3, action.NonOverlappingStart.id)
|
|
s.Equal([]int{5, 7}, jobIds(action.NewBuffer))
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessCancelRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_CANCEL_OTHER}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_CANCEL_OTHER}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_CANCEL_OTHER}}
|
|
action := ProcessBuffer(buffer, true, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Equal([]int{3, 5, 7}, jobIds(action.NewBuffer))
|
|
s.True(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessCancelNotRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_CANCEL_OTHER}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_CANCEL_OTHER}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_CANCEL_OTHER}}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
// optimization: 3 and 5 don't even get started since they would be immediately cancelled
|
|
s.Equal(7, action.NonOverlappingStart.id)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessTerminateRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER}}
|
|
action := ProcessBuffer(buffer, true, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Equal([]int{3, 5, 7}, jobIds(action.NewBuffer))
|
|
s.False(action.NeedCancel)
|
|
s.True(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessTerminateNotRunning() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER}}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Empty(action.OverlappingStarts)
|
|
// optimization: 3 and 5 don't even get started since they would be immediately terminated
|
|
s.Equal(7, action.NonOverlappingStart.id)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessAllowAll() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_ALLOW_ALL}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_ALLOW_ALL}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_ALLOW_ALL}}
|
|
action := ProcessBuffer(buffer, false, identity[enumspb.ScheduleOverlapPolicy])
|
|
s.Equal([]int{3, 5, 7}, jobIds(action.OverlappingStarts))
|
|
s.Nil(action.NonOverlappingStart)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
func (s *processBufferSuite) TestProcessWithResolve() {
|
|
buffer := []*job{{3, enumspb.SCHEDULE_OVERLAP_POLICY_UNSPECIFIED}, {5, enumspb.SCHEDULE_OVERLAP_POLICY_UNSPECIFIED}, {7, enumspb.SCHEDULE_OVERLAP_POLICY_UNSPECIFIED}}
|
|
terminate := func(enumspb.ScheduleOverlapPolicy) enumspb.ScheduleOverlapPolicy {
|
|
return enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER
|
|
}
|
|
action := ProcessBuffer(buffer, false, terminate)
|
|
s.Empty(action.OverlappingStarts)
|
|
s.Equal(7, action.NonOverlappingStart.id)
|
|
s.Empty(action.NewBuffer)
|
|
s.False(action.NeedCancel)
|
|
s.False(action.NeedTerminate)
|
|
}
|
|
|
|
// TODO: add test cases for mixed policies
|