Files
tasks/client/matching/loadbalancer.go
1bf831546a Generic hooks for testing (#6938)
## What changed?
- Add generic hook interface for fine-grained control of behavior in
tests
- Use the hooks for matching varying behavior tests (force load balancer
to target partitions and disable sync match)
- Use the hooks to force a race condition in an update-with-start test
(by @stephanos)

## Why?
To write integration/functional tests that require tweaking behavior of
code under test, without affecting non-test builds.

## Potential risks
Hooks are disabled by default, so there should be zero risk to
production code, and zero overhead (assuming the Go compiler can do very
basic inlining and dead code elimination).

The downside is that functional tests now have to be run with `-tags
test_dep` everywhere.

---------

Co-authored-by: Stephan Behnke <[email protected]>
2025-01-17 17:21:04 -08:00

241 lines
7.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package matching
import (
"math/rand"
"sync"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/testing/testhooks"
"go.temporal.io/server/common/tqid"
)
type (
// LoadBalancer is the interface for implementers of
// component that distributes add/poll api calls across
// available task queue partitions when possible
LoadBalancer interface {
// PickWritePartition returns the task queue partition for adding
// an activity or workflow task. The input is the name of the
// original task queue (with no partition info). When forwardedFrom
// is non-empty, this call is forwardedFrom from a child partition
// to a parent partition in which case, no load balancing should be
// performed
PickWritePartition(
taskQueue *tqid.TaskQueue,
) *tqid.NormalPartition
// PickReadPartition returns the task queue partition to send a poller to.
// Input is name of the original task queue as specified by caller. When
// forwardedFrom is non-empty, no load balancing should be done.
PickReadPartition(
taskQueue *tqid.TaskQueue,
) *pollToken
}
defaultLoadBalancer struct {
namespaceIDToName func(id namespace.ID) (namespace.Name, error)
nReadPartitions dynamicconfig.IntPropertyFnWithTaskQueueFilter
nWritePartitions dynamicconfig.IntPropertyFnWithTaskQueueFilter
testHooks testhooks.TestHooks
lock sync.RWMutex
taskQueueLBs map[tqid.TaskQueue]*tqLoadBalancer
}
// Keeps track of polls per partition. Sends a poll to the partition with the fewest polls
tqLoadBalancer struct {
taskQueue *tqid.TaskQueue
pollerCounts []int // keep track of poller count of each partition
lock sync.Mutex
}
pollToken struct {
TQPartition *tqid.NormalPartition
balancer *tqLoadBalancer
}
)
// NewLoadBalancer returns an instance of matching load balancer that
// can help distribute api calls across task queue partitions
func NewLoadBalancer(
namespaceIDToName func(id namespace.ID) (namespace.Name, error),
dc *dynamicconfig.Collection,
testHooks testhooks.TestHooks,
) LoadBalancer {
lb := &defaultLoadBalancer{
namespaceIDToName: namespaceIDToName,
nReadPartitions: dynamicconfig.MatchingNumTaskqueueReadPartitions.Get(dc),
nWritePartitions: dynamicconfig.MatchingNumTaskqueueWritePartitions.Get(dc),
testHooks: testHooks,
taskQueueLBs: make(map[tqid.TaskQueue]*tqLoadBalancer),
}
return lb
}
func (lb *defaultLoadBalancer) PickWritePartition(
taskQueue *tqid.TaskQueue,
) *tqid.NormalPartition {
if n, ok := testhooks.Get[int](lb.testHooks, testhooks.MatchingLBForceWritePartition); ok {
return taskQueue.NormalPartition(n)
}
nsName, err := lb.namespaceIDToName(namespace.ID(taskQueue.NamespaceId()))
if err != nil {
return taskQueue.RootPartition()
}
n := max(1, lb.nWritePartitions(nsName.String(), taskQueue.Name(), taskQueue.TaskType()))
return taskQueue.NormalPartition(rand.Intn(n))
}
// PickReadPartition picks a partition for poller to poll task from, and keeps load balanced between partitions.
// Caller is responsible to call pollToken.Release() after complete the poll.
func (lb *defaultLoadBalancer) PickReadPartition(
taskQueue *tqid.TaskQueue,
) *pollToken {
tqlb := lb.getTaskQueueLoadBalancer(taskQueue)
// For read path it's safer to return global default partition count instead of root partition, when we fail to
// map namespace ID to name.
var partitionCount = dynamicconfig.GlobalDefaultNumTaskQueuePartitions
namespaceName, err := lb.namespaceIDToName(namespace.ID(taskQueue.NamespaceId()))
if err == nil {
partitionCount = lb.nReadPartitions(string(namespaceName), taskQueue.Name(), taskQueue.TaskType())
}
if n, ok := testhooks.Get[int](lb.testHooks, testhooks.MatchingLBForceWritePartition); ok {
return tqlb.forceReadPartition(partitionCount, n)
}
return tqlb.pickReadPartition(partitionCount)
}
func (lb *defaultLoadBalancer) getTaskQueueLoadBalancer(tq *tqid.TaskQueue) *tqLoadBalancer {
lb.lock.RLock()
tqlb, ok := lb.taskQueueLBs[*tq]
lb.lock.RUnlock()
if ok {
return tqlb
}
lb.lock.Lock()
tqlb, ok = lb.taskQueueLBs[*tq]
if !ok {
tqlb = newTaskQueueLoadBalancer(tq)
lb.taskQueueLBs[*tq] = tqlb
}
lb.lock.Unlock()
return tqlb
}
func newTaskQueueLoadBalancer(tq *tqid.TaskQueue) *tqLoadBalancer {
return &tqLoadBalancer{
taskQueue: tq,
}
}
func (b *tqLoadBalancer) pickReadPartition(partitionCount int) *pollToken {
b.lock.Lock()
defer b.lock.Unlock()
b.ensurePartitionCountLocked(partitionCount)
partitionID := b.pickReadPartitionWithFewestPolls(partitionCount)
b.pollerCounts[partitionID]++
return &pollToken{
TQPartition: b.taskQueue.NormalPartition(partitionID),
balancer: b,
}
}
func (b *tqLoadBalancer) forceReadPartition(partitionCount, partitionID int) *pollToken {
b.lock.Lock()
defer b.lock.Unlock()
b.ensurePartitionCountLocked(max(partitionCount, partitionID+1))
b.pollerCounts[partitionID]++
return &pollToken{
TQPartition: b.taskQueue.NormalPartition(partitionID),
balancer: b,
}
}
// caller to ensure that lock is obtained before call this function
func (b *tqLoadBalancer) pickReadPartitionWithFewestPolls(partitionCount int) int {
// pick a random partition to start with
startPartitionID := rand.Intn(partitionCount)
pickedPartitionID := startPartitionID
minPollerCount := b.pollerCounts[pickedPartitionID]
for i := 1; i < partitionCount && minPollerCount > 0; i++ {
currPartitionID := (startPartitionID + i) % int(partitionCount)
if b.pollerCounts[currPartitionID] < minPollerCount {
pickedPartitionID = currPartitionID
minPollerCount = b.pollerCounts[currPartitionID]
}
}
return pickedPartitionID
}
// caller to ensure that lock is obtained before call this function
func (b *tqLoadBalancer) ensurePartitionCountLocked(partitionCount int) {
if len(b.pollerCounts) == partitionCount {
return
}
if len(b.pollerCounts) < partitionCount {
// add more partition entries
for i := len(b.pollerCounts); i < partitionCount; i++ {
b.pollerCounts = append(b.pollerCounts, 0)
}
} else {
// truncate existing partition entries
b.pollerCounts = b.pollerCounts[:partitionCount]
}
}
func (b *tqLoadBalancer) Release(partitionID int) {
b.lock.Lock()
defer b.lock.Unlock()
// partitionID could be out of range if dynamic config reduce taskQueue partition count
if len(b.pollerCounts) > partitionID && b.pollerCounts[partitionID] > 0 {
b.pollerCounts[partitionID]--
}
}
func (t *pollToken) Release() {
if t.balancer != nil {
// t.balancer == nil is valid for example sticky task queue.
t.balancer.Release(t.TQPartition.PartitionId())
}
}