Files
tasks/common/metrics/task_queues.go
Shahab TajikandGitHub d19454c0e8 Consistent tags for task_schedule_to_start_latency metric (#6548)
## What changed?
<!-- Describe what has changed in this PR -->
Refactored code to emit the same number of tags in the
task_schedule_to_start_latency metric.

## Why?
<!-- Tell your future self why have you made these changes -->
Previously we were using both GetPerTaskQueueFamilyScope and
GetPerTaskQueuePartitionScope for the same metric, now we only use
GetPerTaskQueuePartitionTypeScope.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Added unit tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
None.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
None.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2024-10-01 13:09:22 -07:00

117 lines
3.6 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package metrics
import (
"strconv"
"go.temporal.io/server/common/tqid"
)
const (
omitted = "__omitted__"
normal = "__normal__"
sticky = "__sticky__"
)
// GetPerTaskQueueFamilyScope returns "namespace" and "taskqueue" tags. "taskqueue" will be "__omitted__" if
// taskQueueBreakdown is false.
func GetPerTaskQueueFamilyScope(
handler Handler,
namespaceName string,
taskQueueFamily *tqid.TaskQueueFamily,
taskQueueBreakdown bool,
tags ...Tag,
) Handler {
metricTaskQueueName := omitted
if taskQueueBreakdown {
metricTaskQueueName = taskQueueFamily.Name()
}
tags = append(tags, NamespaceTag(namespaceName), UnsafeTaskQueueTag(metricTaskQueueName))
return handler.WithTags(tags...)
}
// GetPerTaskQueueScope returns GetPerTaskQueueFamilyScope plus the "task_type" tag.
func GetPerTaskQueueScope(
handler Handler,
namespaceName string,
taskQueue *tqid.TaskQueue,
taskQueueBreakdown bool,
tags ...Tag,
) Handler {
return GetPerTaskQueueFamilyScope(handler, namespaceName, taskQueue.Family(), taskQueueBreakdown,
append(tags, TaskQueueTypeTag(taskQueue.TaskType()))...)
}
// GetPerTaskQueuePartitionIDScope is similar to GetPerTaskQueuePartitionTypeScope, except that the partition tag will
// hold the normal partition ID if partitionIDBreakdown is true.
func GetPerTaskQueuePartitionIDScope(
handler Handler,
namespaceName string,
partition tqid.Partition,
taskQueueBreakdown bool,
partitionIDBreakdown bool,
tags ...Tag,
) Handler {
var value string
if partition == nil {
value = unknownValue
} else if normalPartition, ok := partition.(*tqid.NormalPartition); ok {
if partitionIDBreakdown {
value = strconv.Itoa(normalPartition.PartitionId())
} else {
value = normal
}
} else {
value = sticky
}
return GetPerTaskQueueScope(handler, namespaceName, partition.TaskQueue(), taskQueueBreakdown,
append(tags, PartitionTag(value))...)
}
// GetPerTaskQueuePartitionTypeScope returns GetPerTaskQueueScope scope plus a "partition" tag which
// can be "__normal__", "__sticky__", or "_unknown_".
func GetPerTaskQueuePartitionTypeScope(
handler Handler,
namespaceName string,
partition tqid.Partition,
taskQueueBreakdown bool,
tags ...Tag,
) Handler {
var value string
if partition == nil {
value = unknownValue
} else if _, ok := partition.(*tqid.NormalPartition); ok {
value = normal
} else {
value = sticky
}
return GetPerTaskQueueScope(handler, namespaceName, partition.TaskQueue(), taskQueueBreakdown,
append(tags, PartitionTag(value))...)
}