Files
tasks/common/namespace/namespace.go
Alex ShtinandGitHub 2e9635e1ee Refactor: use Eventually in xdc tests (#7243)
## What changed?
<!-- Describe what has changed in this PR -->
1. Use `Eventually` in xdc tests.
2. Extract namespace creation logic into helper functions.
3. Created few other namespace management helpers which blocks until
operation is committed.
4. Left approximately 1 million TODOs for future refactoring.

## Why?
<!-- Tell your future self why have you made these changes -->
1. Random sleeps is a source of flakiness and slowness. 
2. Unify namespace creation code, reduce code duplication.

Before: 

![image](https://github.com/user-attachments/assets/c5d6ffea-a937-4082-aa92-45d6f4513082)
On this PR:

![image](https://github.com/user-attachments/assets/b3e4b776-6ef4-47f4-bf21-47c93a42e90d)


## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Run tests multiple times.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
I might create some new flakiness. Future monitoring over xdc tests is
needed. With all new helpers, fixes should be simple.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2025-02-05 21:49:27 -08:00

366 lines
11 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package namespace
import (
"fmt"
"maps"
"time"
"github.com/google/uuid"
enumspb "go.temporal.io/api/enums/v1"
namespacepb "go.temporal.io/api/namespace/v1"
"go.temporal.io/api/serviceerror"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common"
"go.temporal.io/server/common/util"
)
type (
// Mutation changes a Namespace "in-flight" during a Clone operation.
Mutation interface {
apply(*Namespace)
}
// BadBinaryError is an error type carrying additional information about
// when/why/who configured a given checksum as being bad.
BadBinaryError struct {
cksum string
info *namespacepb.BadBinaryInfo
}
// ID is the unique identifier type for a Namespace.
ID string
// Name is a user-supplied nickname for a Namespace.
Name string
// Namespaces is a *Namespace slice
Namespaces []*Namespace
// Namespace contains the info and config for a namespace
Namespace struct {
info *persistencespb.NamespaceInfo
config *persistencespb.NamespaceConfig
replicationConfig *persistencespb.NamespaceReplicationConfig
configVersion int64
failoverVersion int64
isGlobalNamespace bool
failoverNotificationVersion int64
notificationVersion int64
customSearchAttributesMapper CustomSearchAttributesMapper
}
CustomSearchAttributesMapper struct {
fieldToAlias map[string]string
aliasToField map[string]string
}
// ReplicationPolicy is the namespace's replication policy,
// derived from namespace's replication config
ReplicationPolicy int
)
const (
EmptyName Name = ""
EmptyID ID = ""
// ReplicationPolicyOneCluster indicate that workflows does not need to be replicated
// applicable to local namespace & global namespace with one cluster
ReplicationPolicyOneCluster ReplicationPolicy = 0
// ReplicationPolicyMultiCluster indicate that workflows need to be replicated
ReplicationPolicyMultiCluster ReplicationPolicy = 1
)
func NewID() ID {
return ID(uuid.NewString())
}
func FromPersistentState(
detail *persistencespb.NamespaceDetail,
mutations ...Mutation,
) *Namespace {
ns := &Namespace{
info: detail.Info,
config: detail.Config,
replicationConfig: detail.ReplicationConfig,
configVersion: detail.ConfigVersion,
failoverVersion: detail.FailoverVersion,
failoverNotificationVersion: detail.FailoverNotificationVersion,
customSearchAttributesMapper: CustomSearchAttributesMapper{
fieldToAlias: detail.Config.CustomSearchAttributeAliases,
aliasToField: util.InverseMap(detail.Config.CustomSearchAttributeAliases),
},
}
for _, m := range mutations {
m.apply(ns)
}
return ns
}
func (ns *Namespace) Clone(mutations ...Mutation) *Namespace {
detail := &persistencespb.NamespaceDetail{
Info: common.CloneProto(ns.info),
Config: common.CloneProto(ns.config),
ReplicationConfig: common.CloneProto(ns.replicationConfig),
ConfigVersion: ns.configVersion,
FailoverNotificationVersion: ns.failoverNotificationVersion,
FailoverVersion: ns.failoverVersion,
}
defaultMutations := []Mutation{
WithGlobalFlag(ns.isGlobalNamespace),
WithNotificationVersion(ns.notificationVersion),
}
return FromPersistentState(detail, append(defaultMutations, mutations...)...)
}
// VisibilityArchivalState observes the visibility archive configuration (state
// and URI) for this namespace.
func (ns *Namespace) VisibilityArchivalState() ArchivalConfigState {
return ArchivalConfigState{
State: ns.config.VisibilityArchivalState,
URI: ns.config.VisibilityArchivalUri,
}
}
// HistoryArchivalState observes the history archive configuration (state and
// URI) for this namespace.
func (ns *Namespace) HistoryArchivalState() ArchivalConfigState {
return ArchivalConfigState{
State: ns.config.HistoryArchivalState,
URI: ns.config.HistoryArchivalUri,
}
}
// VerifyBinaryChecksum returns an error if the provided checksum is one of this
// namespace's configured bad binary checksums. The returned error (if any) will
// be unwrappable as BadBinaryError.
func (ns *Namespace) VerifyBinaryChecksum(cksum string) error {
badBinMap := ns.config.GetBadBinaries().GetBinaries()
if badBinMap == nil {
return nil
}
if info, ok := badBinMap[cksum]; ok {
return BadBinaryError{cksum: cksum, info: info}
}
return nil
}
// ID observes this namespace's permanent unique identifier in string form.
func (ns *Namespace) ID() ID {
if ns.info == nil {
return ID("")
}
return ID(ns.info.Id)
}
// Name observes this namespace's configured name.
func (ns *Namespace) Name() Name {
if ns.info == nil {
return Name("")
}
return Name(ns.info.Name)
}
func (ns *Namespace) State() enumspb.NamespaceState {
if ns.info == nil {
return enumspb.NAMESPACE_STATE_UNSPECIFIED
}
return ns.info.State
}
func (ns *Namespace) ReplicationState() enumspb.ReplicationState {
if ns.replicationConfig == nil {
return enumspb.REPLICATION_STATE_UNSPECIFIED
}
return ns.replicationConfig.State
}
// ActiveClusterName observes the name of the cluster that is currently active
// for this namspace.
func (ns *Namespace) ActiveClusterName() string {
if ns.replicationConfig == nil {
return ""
}
return ns.replicationConfig.ActiveClusterName
}
// ClusterNames observes the names of the clusters to which this namespace is
// replicated.
func (ns *Namespace) ClusterNames() []string {
// copy slice to preserve immutability
out := make([]string, len(ns.replicationConfig.Clusters))
copy(out, ns.replicationConfig.Clusters)
return out
}
// IsOnCluster returns true is namespace is registered on cluster otherwise false.
func (ns *Namespace) IsOnCluster(clusterName string) bool {
for _, namespaceCluster := range ns.replicationConfig.Clusters {
if namespaceCluster == clusterName {
return true
}
}
return false
}
// ConfigVersion return the namespace config version
func (ns *Namespace) ConfigVersion() int64 {
return ns.configVersion
}
// FailoverVersion return the namespace failover version
func (ns *Namespace) FailoverVersion() int64 {
return ns.failoverVersion
}
// IsGlobalNamespace returns whether the namespace is a global namespace.
// Being a global namespace doesn't necessarily mean that there are multiple registered clusters for it, only that it
// has a failover version. To determine whether operations should be replicated for a namespace, see ReplicationPolicy.
func (ns *Namespace) IsGlobalNamespace() bool {
return ns.isGlobalNamespace
}
// FailoverNotificationVersion return the global notification version of when failover happened
func (ns *Namespace) FailoverNotificationVersion() int64 {
return ns.failoverNotificationVersion
}
// NotificationVersion return the global notification version of when namespace changed
func (ns *Namespace) NotificationVersion() int64 {
return ns.notificationVersion
}
// ActiveInCluster returns whether the namespace is active, i.e. non global
// namespace or global namespace which active cluster is the provided cluster
func (ns *Namespace) ActiveInCluster(clusterName string) bool {
if !ns.isGlobalNamespace {
// namespace is not a global namespace, meaning namespace is always
// "active" within each cluster
return true
}
return clusterName == ns.ActiveClusterName()
}
// ReplicationPolicy return the derived workflow replication policy
func (ns *Namespace) ReplicationPolicy() ReplicationPolicy {
// frontend guarantee that the clusters always contains the active
// namespace, so if the # of clusters is 1 then we do not need to send out
// any events for replication
if ns.isGlobalNamespace && len(ns.replicationConfig.Clusters) > 1 {
return ReplicationPolicyMultiCluster
}
return ReplicationPolicyOneCluster
}
func (ns *Namespace) GetCustomData(key string) string {
if ns.info.Data == nil {
return ""
}
return ns.info.Data[key]
}
// Retention returns retention duration for this namespace.
func (ns *Namespace) Retention() time.Duration {
if ns.config.Retention == nil {
return 0
}
return ns.config.Retention.AsDuration()
}
// CustomSearchAttributesMapper is a part of temporary solution. Do not use this method.
func (ns *Namespace) CustomSearchAttributesMapper() CustomSearchAttributesMapper {
return ns.customSearchAttributesMapper
}
// Error returns the reason associated with this bad binary.
func (e BadBinaryError) Error() string {
return e.info.Reason
}
// Reason returns the reason associated with this bad binary.
func (e BadBinaryError) Reason() string {
return e.info.Reason
}
// Operator returns the operator associated with this bad binary.
func (e BadBinaryError) Operator() string {
return e.info.Operator
}
// Created returns the time at which this bad binary was declared to be bad.
func (e BadBinaryError) Created() time.Time {
return e.info.CreateTime.AsTime()
}
// Checksum observes the binary checksum that caused this error.
func (e BadBinaryError) Checksum() string {
return e.cksum
}
func (id ID) String() string {
return string(id)
}
func (id ID) IsEmpty() bool {
return id == EmptyID
}
func (n Name) String() string {
return string(n)
}
func (n Name) IsEmpty() bool {
return n == EmptyName
}
func (m *CustomSearchAttributesMapper) GetAlias(fieldName string, namespace string) (string, error) {
alias, ok := m.fieldToAlias[fieldName]
if !ok {
return "", serviceerror.NewInvalidArgument(
fmt.Sprintf("Namespace %s has no mapping defined for field name %s", namespace, fieldName),
)
}
return alias, nil
}
func (m *CustomSearchAttributesMapper) GetFieldName(alias string, namespace string) (string, error) {
fieldName, ok := m.aliasToField[alias]
if !ok {
return "", serviceerror.NewInvalidArgument(
fmt.Sprintf("Namespace %s has no mapping defined for search attribute %s", namespace, alias),
)
}
return fieldName, nil
}
func (m *CustomSearchAttributesMapper) FieldToAliasMap() map[string]string {
return maps.Clone(m.fieldToAlias)
}