Files
tasks/common/namespace/nsmanager/attr_validator.go
Stephan BehnkeandGitHub 7576d3cfd0 Move namespace attr validator to own package (#7114)
## What changed?
<!-- Describe what has changed in this PR -->

Moved code from `common/namespace` to `common/namespace/nsattr`.

## Why?
<!-- Tell your future self why have you made these changes -->

This removes the dependency from `common/namespace` on `common/cluster`.
One step towards using `common/dynamicconfig` from `common/namespace`.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

No behavior changes here.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2025-01-18 00:56:56 +00:00

124 lines
3.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package nsmanager
import (
"fmt"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common/cluster"
)
type (
Validator struct {
clusterMetadata cluster.Metadata
}
)
// NewValidator create a new namespace attribute Validator
func NewValidator(
clusterMetadata cluster.Metadata,
) *Validator {
return &Validator{
clusterMetadata: clusterMetadata,
}
}
func (d *Validator) ValidateNamespaceConfig(config *persistencespb.NamespaceConfig) error {
if config.HistoryArchivalState == enumspb.ARCHIVAL_STATE_ENABLED && len(config.HistoryArchivalUri) == 0 {
return errInvalidArchivalConfig
}
if config.VisibilityArchivalState == enumspb.ARCHIVAL_STATE_ENABLED && len(config.VisibilityArchivalUri) == 0 {
return errInvalidArchivalConfig
}
return nil
}
func (d *Validator) ValidateNamespaceReplicationConfigForLocalNamespace(
replicationConfig *persistencespb.NamespaceReplicationConfig,
) error {
activeCluster := replicationConfig.ActiveClusterName
clusters := replicationConfig.Clusters
if err := d.validateClusterName(activeCluster); err != nil {
return err
}
for _, clusterName := range clusters {
if err := d.validateClusterName(clusterName); err != nil {
return err
}
}
if activeCluster != d.clusterMetadata.GetCurrentClusterName() {
return serviceerror.NewInvalidArgument("Invalid local namespace active cluster")
}
if len(clusters) != 1 || clusters[0] != activeCluster {
return serviceerror.NewInvalidArgument("Invalid local namespace clusters")
}
return nil
}
func (d *Validator) ValidateNamespaceReplicationConfigForGlobalNamespace(
replicationConfig *persistencespb.NamespaceReplicationConfig,
) error {
activeCluster := replicationConfig.ActiveClusterName
clusters := replicationConfig.Clusters
if err := d.validateClusterName(activeCluster); err != nil {
return err
}
for _, clusterName := range clusters {
if err := d.validateClusterName(clusterName); err != nil {
return err
}
}
activeClusterInClusters := false
for _, clusterName := range clusters {
if clusterName == activeCluster {
activeClusterInClusters = true
break
}
}
if !activeClusterInClusters {
return errActiveClusterNotInClusters
}
return nil
}
func (d *Validator) validateClusterName(
clusterName string,
) error {
if info, ok := d.clusterMetadata.GetAllClusterInfo()[clusterName]; !ok || !info.Enabled {
return serviceerror.NewInvalidArgument(fmt.Sprintf("Invalid cluster name: %v", clusterName))
}
return nil
}