mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Change to send raw history blobs from history service to frontend service. History service returns a new proto message that has a repeated bytes history field. This response is wire compatible with the original response which has temporal.api.history.v1.History type for this field. This allows history service to not deserialize events from this data blob. This considerably reduces CPU usage. History service still needs event_id and version decoded from history events. For this we use a new proto message StrippedHistoryEvent which has these two fields only. It takes considerably less CPU to decode events to this struct. ## Why? We have seen incidents of high history CPU usage when large number of GetWorkflowExecutionHistory calls are made to workflows which has large history. With this change we can reduce the CPU burden on history service during this API call. ## How did you test it? Existing unit and functional tests. ## Potential risks ## Documentation ## Is hotfix candidate?
198 lines
7.3 KiB
Go
198 lines
7.3 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package persistence
|
|
|
|
import (
|
|
"context"
|
|
"sort"
|
|
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
historypb "go.temporal.io/api/history/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
historyspb "go.temporal.io/server/api/history/v1"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
)
|
|
|
|
// ReadFullPageEvents reads a full page of history events from ExecutionManager. Due to storage format of V2 History
|
|
// it is not guaranteed that pageSize amount of data is returned. Function returns the list of history events, the size
|
|
// of data read, the next page token, and an error if present.
|
|
func ReadFullPageEvents(
|
|
ctx context.Context,
|
|
executionMgr ExecutionManager,
|
|
req *ReadHistoryBranchRequest,
|
|
) ([]*historypb.HistoryEvent, int, []byte, error) {
|
|
var historyEvents []*historypb.HistoryEvent
|
|
size := 0
|
|
for {
|
|
response, err := executionMgr.ReadHistoryBranch(ctx, req)
|
|
if err != nil {
|
|
return nil, 0, nil, err
|
|
}
|
|
historyEvents = append(historyEvents, response.HistoryEvents...)
|
|
size += response.Size
|
|
if len(historyEvents) >= req.PageSize || len(response.NextPageToken) == 0 {
|
|
return historyEvents, size, response.NextPageToken, nil
|
|
}
|
|
req.NextPageToken = response.NextPageToken
|
|
}
|
|
}
|
|
|
|
// ReadFullPageRawEvents reads a full page of raw history events from ExecutionManager. Due to storage format of V2 History
|
|
// it is not guaranteed that pageSize amount of data is returned. Function returns the list of history blobs, the size
|
|
// of data read, the next page token, and an error if present.
|
|
func ReadFullPageRawEvents(
|
|
ctx context.Context,
|
|
executionMgr ExecutionManager,
|
|
req *ReadHistoryBranchRequest,
|
|
) ([]*commonpb.DataBlob, int, []byte, error) {
|
|
var blobs []*commonpb.DataBlob
|
|
size := 0
|
|
for {
|
|
response, err := executionMgr.ReadRawHistoryBranch(ctx, req)
|
|
if err != nil {
|
|
return nil, 0, nil, err
|
|
}
|
|
blobs = append(blobs, response.HistoryEventBlobs...)
|
|
size += response.Size
|
|
if len(blobs) >= req.PageSize || len(response.NextPageToken) == 0 {
|
|
return blobs, size, response.NextPageToken, nil
|
|
}
|
|
req.NextPageToken = response.NextPageToken
|
|
}
|
|
}
|
|
|
|
// ReadFullPageEventsByBatch reads a full page of history events by batch from ExecutionManager. Due to storage format of V2 History
|
|
// it is not guaranteed that pageSize amount of data is returned. Function returns the list of history batches, the size
|
|
// of data read, the next page token, and an error if present.
|
|
func ReadFullPageEventsByBatch(
|
|
ctx context.Context,
|
|
executionMgr ExecutionManager,
|
|
req *ReadHistoryBranchRequest,
|
|
) ([]*historypb.History, int, []byte, error) {
|
|
var historyBatches []*historypb.History
|
|
eventsRead := 0
|
|
size := 0
|
|
for {
|
|
response, err := executionMgr.ReadHistoryBranchByBatch(ctx, req)
|
|
if err != nil {
|
|
return nil, 0, nil, err
|
|
}
|
|
historyBatches = append(historyBatches, response.History...)
|
|
for _, batch := range response.History {
|
|
eventsRead += len(batch.Events)
|
|
}
|
|
size += response.Size
|
|
if eventsRead >= req.PageSize || len(response.NextPageToken) == 0 {
|
|
return historyBatches, size, response.NextPageToken, nil
|
|
}
|
|
req.NextPageToken = response.NextPageToken
|
|
}
|
|
}
|
|
|
|
// ReadFullPageEventsReverse reads a full page of history events from ExecutionManager in reverse orcer. Due to storage
|
|
// format of V2 History it is not guaranteed that pageSize amount of data is returned. Function returns the list of
|
|
// history events, the size of data read, the next page token, and an error if present.
|
|
func ReadFullPageEventsReverse(
|
|
ctx context.Context,
|
|
executionMgr ExecutionManager,
|
|
req *ReadHistoryBranchReverseRequest,
|
|
) ([]*historypb.HistoryEvent, int, []byte, error) {
|
|
var historyEvents []*historypb.HistoryEvent
|
|
size := 0
|
|
for {
|
|
response, err := executionMgr.ReadHistoryBranchReverse(ctx, req)
|
|
if err != nil {
|
|
return nil, 0, nil, err
|
|
}
|
|
historyEvents = append(historyEvents, response.HistoryEvents...)
|
|
size += response.Size
|
|
if len(historyEvents) >= req.PageSize || len(response.NextPageToken) == 0 {
|
|
return historyEvents, size, response.NextPageToken, nil
|
|
}
|
|
req.NextPageToken = response.NextPageToken
|
|
}
|
|
}
|
|
|
|
// GetBeginNodeID gets node id from last ancestor
|
|
func GetBeginNodeID(bi *persistencespb.HistoryBranch) int64 {
|
|
if len(bi.Ancestors) == 0 {
|
|
// root branch
|
|
return 1
|
|
}
|
|
idx := len(bi.Ancestors) - 1
|
|
return bi.Ancestors[idx].GetEndNodeId()
|
|
}
|
|
|
|
func sortAncestors(ans []*persistencespb.HistoryBranchRange) {
|
|
if len(ans) > 0 {
|
|
// sort ans based onf EndNodeID so that we can set BeginNodeID
|
|
sort.Slice(ans, func(i, j int) bool { return (ans)[i].GetEndNodeId() < (ans)[j].GetEndNodeId() })
|
|
(ans)[0].BeginNodeId = int64(1)
|
|
for i := 1; i < len(ans); i++ {
|
|
(ans)[i].BeginNodeId = (ans)[i-1].GetEndNodeId()
|
|
}
|
|
}
|
|
}
|
|
|
|
func ValidateBatch(
|
|
batch []*historyspb.StrippedHistoryEvent,
|
|
branchToken []byte,
|
|
lastEventID int64,
|
|
logger log.Logger,
|
|
) error {
|
|
var firstEvent, lastEvent *historyspb.StrippedHistoryEvent
|
|
var eventCount int
|
|
dataLossTags := func(cause string) []tag.Tag {
|
|
return []tag.Tag{
|
|
tag.Cause(cause),
|
|
tag.WorkflowBranchToken(branchToken),
|
|
tag.WorkflowFirstEventID(firstEvent.GetEventId()),
|
|
tag.FirstEventVersion(firstEvent.GetVersion()),
|
|
tag.WorkflowNextEventID(lastEvent.GetEventId()),
|
|
tag.LastEventVersion(lastEvent.GetVersion()),
|
|
tag.Counter(eventCount),
|
|
tag.TokenLastEventID(lastEventID),
|
|
}
|
|
}
|
|
firstEvent = batch[0]
|
|
eventCount = len(batch)
|
|
lastEvent = batch[eventCount-1]
|
|
|
|
if firstEvent.GetVersion() != lastEvent.GetVersion() || firstEvent.GetEventId()+int64(eventCount-1) != lastEvent.GetEventId() {
|
|
// in a single batch, version should be the same, and ID should be contiguous
|
|
logger.Error(dataLossMsg, dataLossTags(errWrongVersion)...)
|
|
return serviceerror.NewDataLoss(errWrongVersion)
|
|
}
|
|
// If it is the first batch in the response, we cannot check the first event id here. That information is in the historyPagingToken.
|
|
// TODO: PPV refactor to move this check to ExecutionManager so that we can include that check as well.
|
|
if lastEventID != 0 && firstEvent.GetEventId() != lastEventID+1 {
|
|
logger.Error(dataLossMsg, dataLossTags(errNonContiguousEventID)...)
|
|
return serviceerror.NewDataLoss(errNonContiguousEventID)
|
|
}
|
|
return nil
|
|
}
|